0004306: LMS, TeamLMS, Possession and TeamPossession erroneously check for limits at the end of win sequences instead of start

MantisBT - Zandronum

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0004306

Zandronum

[All Projects] Bug

public

2024-06-05 06:00

2025-04-15 07:11

Reporter

unknownna

Assigned To

Priority

normal

Severity

trivial

Reproducibility

always

Status

new

Resolution

open

Platform

OS Version

Product Version

3.1

Target Version

Fixed in Version

Summary

0004306: LMS, TeamLMS, Possession and TeamPossession erroneously check for limits at the end of win sequences instead of start

Description

This was just something I noticed while testing the mode. If winlimit is technically reached after you remove all other players/bots and automatically win the game, and then you turn into a spectator yourself after that, the map will not change as intended.
The winlimit check isn't done properly early enough.

Edit:
The problem with these modes is that they check for limit hits at the end of a win sequence instead of start. This means that a limit can be reached and a game would normally be won and over, but if the winning players spectate during the win sequence, the game will not be over since it checks for the scores after win sequences instead of the start.

Steps To Reproduce

1. Start a teamlms game with winlimit set to 1 and join the game.
2. Add a bot and start the round.
3. Remove said bot and your team will win, however turn into a spectator during the win sequence. The map will not change.

1. zandronum +lastmanstanding 1 +sv_nomonsters 1 +winlimit 1 +map map01
2. Add a bot into the game and kill it after the countdown sequence.
3. Spectate during the win sequence and notice it doesn't progress to the next map since it only checks for limit hits at the end of the win sequence.

Additional Information