MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004130Doomseeker[All Projects] Bugpublic2023-04-30 16:562023-07-01 16:48
ReporterNecrodoom 
Assigned ToZalewa 
PrioritynormalSeverityminorReproducibilitysometimes
Statusneeds testingResolutionopen 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.4.1 
Target Version1.5.0Fixed in Version 
Summary0004130: Doomseeker requests with flag SQF2_PWAD_HASHES even if flag 'check the integrity of local wads' is disabled
DescriptionTicket opened as proxy for @AKMDM#7151 and @Iko#7646

According to Kaminsky, even if the integrity check is disabled, doomseeker is still requesting MD5 hashes for wads. This increases the packet size for servers and makes it easier to hit the issue outlined in 0004064.

Unfortunately i cant really test it on my own but i hope people will use this ticket for documentation.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0004064resolved DrinkyBird Zandronum Trouble with big UDP packets in launcher query responses from game servers 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-04-30 16:56NecrodoomNew Issue
2023-04-30 16:57WaTaKiDRelationship addedrelated to 0004064
2023-05-28 18:52ZalewaAssigned To => Zalewa
2023-05-28 18:52ZalewaStatusnew => acknowledged
2023-06-11 21:27ZalewaStatusacknowledged => assigned
2023-06-25 13:33ZalewaNote Added: 0022854
2023-06-25 13:33ZalewaStatusassigned => needs review
2023-06-25 13:33ZalewaTarget Version => 1.5.0
2023-07-01 16:48ZalewaStatusneeds review => needs testing

Notes
(0022854)
Zalewa   
2023-06-25 13:33   
With this change Zandronum and Q-Zandronum plugins won't ask for the WAD hashes anymore when the integrity check is disabled:

'https://bitbucket.org/Doomseeker/doomseeker/commits/cbf97265e46fbae5ac74d45e16cf447c36c0acd9 [^]'

Odamex also sends the checksums of WADs but from reading Odamex's source code I see no way to ask it not to.