MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004070DoomseekerUIpublic2022-12-30 13:452024-11-03 19:13
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynoneSeveritytweakReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSDebian GNU/LinuxOS Versionbookworm/sid
Product Version1.3.3 
Target Version1.4.0Fixed in Version1.4.0 
Summary0004070: Zalewa and Blzut3's email addresses in the about dialog are not mailto: hyperlinked
DescriptionHelp → About seems to support HTML notation, as an example the URL to'https://doomseeker.drdteam.org/ [^]' is clickable and has a menu option "Copy Link Location" (keyboard accessible). This is all good.
But below said URL, there are two email addresses for Blzut3 and Zalewa (the assumed maintainers of Doomseeker). Neither of these email addresses have this option to copy the email address (menu key / right click), nor can I click it to open my MUA to write them an email directly (should I assume my operating system understands mailto: scheme links).
Steps To ReproduceHelp → About.
mailto:foo@bar.example
Additional Information
TagsNo tags attached.
Relationships
related to 0004069closed Zalewa Ambiguous "contact information" in Doomseeker's about dialog 
Attached Filespng 2022-12-30-134552_maim.png (54,357) 2022-12-30 13:50
https://zandronum.com/tracker/file_download.php?file_id=2799&type=bug
png

patch 0001-ui-aboutdialog-Use-Qt-TextBrowserInteraction.patch (2,362) 2022-12-31 01:25
https://zandronum.com/tracker/file_download.php?file_id=2800&type=bug
patch 0002-ui-aboutdialog-Merge-name-and-email-address-labels.patch (3,378) 2022-12-31 01:51
https://zandronum.com/tracker/file_download.php?file_id=2801&type=bug
png 2022-12-31-015158_maim.png (9,912) 2022-12-31 01:52
https://zandronum.com/tracker/file_download.php?file_id=2802&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-12-30 13:45WubTheCaptainNew Issue
2022-12-30 13:50WubTheCaptainFile Added: 2022-12-30-134552_maim.png
2022-12-30 13:50WubTheCaptainNote Added: 0022574
2022-12-30 16:34ZalewaAssigned To => Zalewa
2022-12-30 16:34ZalewaStatusnew => assigned
2022-12-30 16:34ZalewaTarget Version => 1.4.0
2022-12-30 18:33ZalewaNote Added: 0022576
2022-12-30 18:33ZalewaStatusassigned => needs review
2022-12-31 00:55WubTheCaptainNote Added: 0022584
2022-12-31 00:56WubTheCaptainNote Edited: 0022584bug_revision_view_page.php?bugnote_id=22584#r13833
2022-12-31 00:58WubTheCaptainNote Added: 0022585
2022-12-31 00:59WubTheCaptainNote Edited: 0022585bug_revision_view_page.php?bugnote_id=22585#r13835
2022-12-31 01:00WubTheCaptainNote Edited: 0022585bug_revision_view_page.php?bugnote_id=22585#r13836
2022-12-31 01:25WubTheCaptainFile Added: 0001-ui-aboutdialog-Use-Qt-TextBrowserInteraction.patch
2022-12-31 01:26WubTheCaptainNote Added: 0022586
2022-12-31 01:51WubTheCaptainNote Added: 0022588
2022-12-31 01:51WubTheCaptainFile Added: 0002-ui-aboutdialog-Merge-name-and-email-address-labels.patch
2022-12-31 01:52WubTheCaptainFile Added: 2022-12-31-015158_maim.png
2022-12-31 01:54WubTheCaptainNote Added: 0022589
2022-12-31 01:55WubTheCaptainNote Edited: 0022589bug_revision_view_page.php?bugnote_id=22589#r13838
2022-12-31 02:16WubTheCaptainNote Added: 0022590
2022-12-31 02:18WubTheCaptainNote Edited: 0022590bug_revision_view_page.php?bugnote_id=22590#r13840
2022-12-31 11:24ZalewaRelationship addedrelated to 0004069
2022-12-31 13:21WubTheCaptainNote Added: 0022613
2023-01-05 12:23ZalewaStatusneeds review => resolved
2023-01-05 12:23ZalewaFixed in Version => 1.4.0
2023-01-05 12:23ZalewaResolutionopen => fixed
2024-11-03 19:13ZalewaStatusresolved => closed

Notes
(0022574)
WubTheCaptain   
2022-12-30 13:50   
foo@bar.example with MantisBT syntax...
(0022576)
Zalewa   
2022-12-30 18:33   
Converted to mailto links here:'https://bitbucket.org/Doomseeker/doomseeker/commits/f7fa5b937c25fd86d4874882596bfe3c584e6820 [^]'
(0022584)
WubTheCaptain   
2022-12-31 00:55   
(edited on: 2022-12-31 00:56)
Qt::TextBrowserInteraction|Qt::TextSelectableByKeyboard|Qt::TextSelectableByMouse is kinda janky, particularly with a keyboard. The first Tab key press starts text interaction / selection, which is not what I want because pressing Enter key here when reaching the email address will actually close the "About Doomseeker" window instead of opening my MUA; only the second Tab key press actually selects the full mailto: URI, and only then pressing Enter key opens my MUA.
(0022585)
WubTheCaptain   
2022-12-31 00:58   
(edited on: 2022-12-31 01:00)
I notice what I said in 0004070:0022584 does not occur with the IP2C Database URL below. That behaves perfectly as desired with a keyboard.
(0022586)
WubTheCaptain   
2022-12-31 01:26   
The attached patch (0001-ui-aboutdialog-Use-Qt-TextBrowserInteraction.patch) does not fix the underlying focus issue (two Tab key presses required), but may alleviate some confusion about the selection. It replaces the textInteractionFlags with TextBrowserInteraction on labels with URLs in this window.
(0022588)
WubTheCaptain   
2022-12-31 01:51   
I tried removing the mailto: labels (label_10 and label_12) and merging those labels with the maintainer name labels (label_9 and label_11) to figure out if that was causing the issue of needing to press the Tab key twice, but it didn't resolve the issue I had above. Though it seemed kinda neater for mouse text selection accessibility, so I left it in as an experimental patch 0002.
I know 0002 doesn't use "- " prefix like the other contributors stuff below it does, but I felt like this needs to be a list widget to be correct (and I don't know how to do that).
(0022589)
WubTheCaptain   
2022-12-31 01:54   
(edited on: 2022-12-31 01:55)
The attached screenshot (2022-12-31-015158_maim.png) was created after the unrelated fix for 0004069 was made available (master branch HEAD), in case there is any doubt why the "Contact information" text from the first screenshot is different; that text is not changed with this patch.
(0022590)
WubTheCaptain   
2022-12-31 02:16   
(edited on: 2022-12-31 02:18)
bleehhh, patch 0002 introduced an error to one email address (.com instead of .net). I'm not submitting a v2 patch with a correction, because I don't think it should be used like this without a list widget and it's an experiment (to be tried by developers).
(0022613)
WubTheCaptain   
2022-12-31 13:21   
Zalewa committed:
Quote
Remove the TextSelectableByKeyboard flag from the mailto hyperlinks (0004070)

'https://bitbucket.org/Doomseeker/doomseeker/commits/360e9a434a2b81d4f52d55072cd22a8fcc7ac46a [^]'