MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004034Zandronum[All Projects] Bugpublic2022-09-10 23:082022-12-01 12:58
ReporterBasinga 
Assigned ToKaminsky 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.1 
Target Version3.2Fixed in Version3.2 
Summary0004034: (Coop) Avoid losing keys & skulls when changing classes during gameplay
DescriptionCurrently, even with sv_sharekeys 1, if you change class you will lose the keys and skulls the team already picked up. You can still go and pick up the key/skulls again yourself to get em back your inventory at least.

My sugestion is to have a special case where you don't lose keys and skulls when changing classes mid level.

Steps To ReproduceI recommend doing this on the kinsie test map along with any multi class mod. I'll be sharing one along with this issue

1. Start a coop match with 2 players
2. Have any player grab atleast one key or skull
3. Have one player choose a different class in player setup then die
4. The respawning player will no longer have any keys or skulls
Additional InformationSeems like things are working as intended (inventory fully resets when respawning as a new class) but maybe an exception for keys would do nicely.
TagsNo tags attached.
Relationships
Attached Files? MultiClassCheck.pk3 (1,339) 2022-09-10 23:08
https://zandronum.com/tracker/file_download.php?file_id=2773&type=bug
Issue History
Date ModifiedUsernameFieldChange
2022-09-10 23:08BasingaNew Issue
2022-09-10 23:08BasingaFile Added: MultiClassCheck.pk3
2022-09-18 18:50KaminskyAssigned To => Kaminsky
2022-09-18 18:50KaminskyStatusnew => needs review
2022-09-18 18:50KaminskyCategorySuggestion => Bug
2022-09-18 18:50KaminskyTarget Version => 3.2
2022-09-18 19:13WubTheCaptainNote Added: 0022402
2022-09-18 21:14KaminskyNote Added: 0022404
2022-09-18 21:14KaminskyStatusneeds review => needs testing
2022-09-29 06:54WaTaKiDNote Added: 0022418
2022-09-29 07:57WaTaKiDNote Added: 0022421
2022-12-01 03:46WaTaKiDNote Added: 0022508
2022-12-01 12:58KaminskyNote Added: 0022511
2022-12-01 12:58KaminskyStatusneeds testing => resolved
2022-12-01 12:58KaminskyFixed in Version => 3.2
2022-12-01 12:58KaminskyResolutionopen => fixed

Notes
(0022402)
WubTheCaptain   
2022-09-18 19:13   
Quote
Status: needs review

There has been no commits to zandronum-stable default branch between 2022-09-11 and 2022-09-18. There is nothing to review in this ticket. No patch.
(0022404)
Kaminsky   
2022-09-18 21:14   
FYI, the commit that addresses this ticket is here:'https://osdn.net/projects/zandronum/scm/hg/zandronum-stable/commits/7604d56ff5d863344f4c898fc37c781585d60337 [^]' (this was reviewed separately during our private dev meeting, I apologize for the confusion).
(0022418)
WaTaKiD   
2022-09-29 06:54   
tested the provided example wad and doom2 map02 on local windows and tspg linux servers with sv_sharekeys 1

i connect 2 clients, both choose the "doomguy one" class
client 1 grabs the red key
client 2 changes class to "doomguy two" via the player setup menu
client 2 uses the "kill" cmd and respawns
client 2 does NOT have the red key anymore
(0022421)
WaTaKiD   
2022-09-29 07:57   
oops disregard my above note, 3.2-alpha-220904-2011 doesnt have the fix, sorry bout that
(0022508)
WaTaKiD   
2022-12-01 03:46   
using ZandroDev3.2-221030-0316windows-x86_64 and repeating the same tests as 0004034:0022418 seems to work fine now
(0022511)
Kaminsky   
2022-12-01 12:58   
Thanks for checking again, I marked the ticket as resolved.