|
Notes |
|
|
|
|
I don't want the configuration and its executable paths to be changed automatically unprompted without approval from the user. Consider unmounted filesystems / disks and such. |
|
|
|
|
|
But the copy of the relevant error text could be improved, and direct the user directly to that plugin's Configuration with a "Configure" button. As a more graceful and friendly alternative, it could go through a proposed new configuration wizard for that game to set its executable before connecting (to reduce the amount of steps required to connect), instead of representing an error and refusing to solve it for you. |
|
|
|
|
|
There's also an extra consideration for UNIX-like operating systems: I don't think the current system searches in $PATH environment, but instead looks for the paths hard-configured in PathFinder::genericPathFinder function (src/core/pathfinder/pathfinder.cpp), so the game client search function is not always be precise. Ideally it should utilize $PATH to be more helpful. |
|
|
|
|
Quote from WubTheCaptain
There's also an extra consideration for UNIX-like operating systems
Microsoft Windows too, but I expect hardly any user to deviate from the default Path environment value on that operating system, really. Except developers and server administrators, who may use command-line interface tools. |
|
|
|
(0022301)
|
|
auratoostronk
|
2022-07-31 20:35
(edited on: 2022-07-31 20:40) |
|
I agree with prompting the user before changing their path for their exe. Anything that makes it easier for players to join is fine in my book.
|
|
|
|
(0022527)
|
|
Zalewa
|
2022-12-17 20:39
(edited on: 2022-12-17 20:40) |
|
The fun thing is that Doomseeker was already opening the config box if you couldn't join the game due to it not being configured. However, due to a bug, the config page for the game wasn't selected properly. This should be fixed here.
Now, as far as the auto-config goes, I agree with Wub here that Doomseeker shouldn't meddle with the configuration like this or try to launch auto-guessed executables on its own. But, to help with the configuration issue, I decided to make the UI more explicit for the user.
So, the config box won't auto-open anymore, and instead a configure game button is displayed in the error message box. This should help with leading the user towards the proper solution of the "lack of game setup" problem.
I also made an attempt at making the error messages themselves sound more human, but I don't know if that was successful.
|
|
|
|
(0022645)
|
|
Zalewa
|
|
2023-01-05 12:15
|
|
|
|
|
(0022700)
|
|
Zalewa
|
|
2023-01-15 14:59
|
|
When the client executable is misconfigured and the user tries to join a server or obtain its command line, they will get one a message box with the "Configure game" button as shown on:
- ds-20230115-configure-game-when-joining.jpg
- ds-20230115-configure-game-when-showing-cmd.jpg |
|
|
|
(0022702)
|
|
Zalewa
|
|
2023-01-15 22:26
|
|
|
THERE IS A FIND BUTTON.png (32,700) 2022-07-30 11:08
ds-20230115-configure-game-when-joining.jpg (12,395) 2023-01-15 14:58