MantisBT - Doomseeker
View Issue Details
0004008DoomseekerUIpublic2022-05-30 02:002024-11-03 19:12
WubTheCaptain 
Zalewa 
nonefeaturealways
closedfixed 
1.3.3 
1.4.01.4.0 
0004008: Unable to filter password protected servers
There's options to show/hide full servers, empty servers, valid servers, and testing servers, but none for password protected servers.
  1. View → Server Filter (Ctrl + F)
  2. Notice an option to filter password protected servers is missing.
No tags attached.
related to 0004006closed  Doomseeker 1.33 filters 
png 2022-05-30-020018_235x214_scrot.png (10,333) 2022-05-30 02:00
https://zandronum.com/tracker/file_download.php?file_id=2746&type=bug
png
Issue History
2022-05-30 02:00WubTheCaptainNew Issue
2022-05-30 02:00WubTheCaptainFile Added: 2022-05-30-020018_235x214_scrot.png
2022-05-30 02:01WubTheCaptainRelationship addedrelated to 0004006
2022-05-30 02:06WubTheCaptainNote Added: 0022245
2022-05-30 02:31WubTheCaptainDescription Updatedbug_revision_view_page.php?rev_id=13631#r13631
2022-05-30 16:20ZalewaStatusnew => acknowledged
2022-05-30 21:38ZalewaNote Added: 0022252
2022-05-31 01:12WubTheCaptainNote Added: 0022255
2022-09-10 13:33ZalewaAssigned To => Zalewa
2022-09-10 13:33ZalewaStatusacknowledged => assigned
2022-09-10 14:06ZalewaNote Added: 0022382
2022-09-10 14:06ZalewaStatusassigned => needs review
2022-09-10 14:06ZalewaNote Edited: 0022382bug_revision_view_page.php?bugnote_id=22382#r13715
2022-09-10 14:29ZalewaTarget Version => 1.4.0
2023-01-05 12:06ZalewaNote Added: 0022637
2023-01-05 12:06ZalewaStatusneeds review => needs testing
2023-01-06 15:44KaminskyNote Added: 0022680
2023-01-06 20:08ZalewaNote Added: 0022683
2023-01-06 20:08ZalewaStatusneeds testing => resolved
2023-01-06 20:08ZalewaFixed in Version => 1.4.0
2023-01-06 20:08ZalewaResolutionopen => fixed
2024-11-03 19:12ZalewaStatusresolved => closed

Notes
(0022245)
WubTheCaptain   
2022-05-30 02:06   
I can't tell if it's a bug that the game engine icon column in the server browser main UI (always visible) also does not sort password protected servers on bottom or top. Password protected servers are mixed-in between.
(0022252)
Zalewa   
2022-05-30 21:38   
0004008:0022245 not a bug, just an omission. Didn't think it was important. Keep in mind that the icon can have the testing 'T', the padlock or both. I dunno if we should alter the sorting behavior here tho. And what would be the sorting criteria here? What gets precedence over what?
(0022255)
WubTheCaptain   
2022-05-31 01:12   
0004008:0022252: I don't think it's a concern, I'd leave it be.
(0022382)
Zalewa   
2022-09-10 14:06   
I simply added a tri-state checkbox filter for this, between the other "show" filters:'https://bitbucket.org/Doomseeker/doomseeker/commits/5f35a204aa66aa67f83aaf7bcf3c149beb92901b [^]'

(0022637)
Zalewa   
2023-01-05 12:06   
Beta package for Windows available at the beta auto-update channel and at:'https://devbuilds.drdteam.org/doomseeker/doomseeker-1.3.3~beta-230105-1140_windows.zip [^]'

Please test.

(0022680)
Kaminsky   
2023-01-06 15:44   
I tested using 230106-0013 on Windows and the Zandronum plugin, the tri-state checkbox for filtering password protected servers seems to work properly for me.

- When the checkbox is blank, all password protected servers are hidden from the list.
- When there's a check mark, only password protected servers appear in the list.
- When there's a solid square then any servers, password protected or not, are visible.
(0022683)
Zalewa   
2023-01-06 20:08   
Thanks for testing.