MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003962Doomseeker[All Projects] Cleanuppublic2021-12-28 13:132024-11-03 19:11
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.3.2 
Target Version1.4.0Fixed in Version1.4.0 
Summary0003962: Doomseeker builds an unmaintained SRB2 game plugin by default
DescriptionDiscussion in 0003958 points to the SRB2 game plugin being unmaintained (and seems to favor its discontinuation), but it is still being built as any other supported game plugin (not legacy).
Steps To Reproduce./src/plugins/CMakeLists.txt
Additional Information
TagsNo tags attached.
Relationships
child of 0003958closed Zalewa SRB2 plugin is unmaintained 
Attached Filespatch 0001-plugins-Move-the-SRB2-plugin-to-legacy-plugins.patch (1,671) 2021-12-28 13:49
https://zandronum.com/tracker/file_download.php?file_id=2704&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-12-28 13:13WubTheCaptainNew Issue
2021-12-28 13:13WubTheCaptainRelationship addedchild of 0003958
2021-12-28 13:18WubTheCaptainStatusnew => confirmed
2021-12-28 13:20WubTheCaptainNote Added: 0022039
2021-12-28 13:20WubTheCaptainNote Edited: 0022039bug_revision_view_page.php?bugnote_id=22039#r13528
2021-12-28 13:23WubTheCaptainNote Edited: 0022039bug_revision_view_page.php?bugnote_id=22039#r13529
2021-12-28 13:31WubTheCaptainAssigned To => WubTheCaptain
2021-12-28 13:31WubTheCaptainStatusconfirmed => assigned
2021-12-28 13:48WubTheCaptainFile Added: 0001-plugins-Move-the-SRB2-plugin-to-legacy-plugins.patch
2021-12-28 13:48WubTheCaptainFile Deleted: 0001-plugins-Move-the-SRB2-plugin-to-legacy-plugins.patch
2021-12-28 13:49WubTheCaptainFile Added: 0001-plugins-Move-the-SRB2-plugin-to-legacy-plugins.patch
2021-12-28 13:50WubTheCaptainNote Added: 0022040
2021-12-28 13:50WubTheCaptainAssigned ToWubTheCaptain =>
2021-12-28 13:50WubTheCaptainStatusassigned => confirmed
2022-09-10 14:39ZalewaNote Added: 0022383
2022-09-10 14:39ZalewaTarget Version => 1.4.0
2023-01-04 16:01ZalewaAssigned To => Zalewa
2023-01-04 16:01ZalewaStatusconfirmed => assigned
2023-01-04 16:55ZalewaNote Added: 0022630
2023-01-04 16:55ZalewaStatusassigned => needs review
2023-01-05 12:39ZalewaNote Added: 0022665
2023-01-05 12:39ZalewaStatusneeds review => needs testing
2023-01-05 12:40ZalewaNote Deleted: 0022665
2023-01-05 12:41ZalewaNote Added: 0022667
2023-01-05 12:41ZalewaNote Edited: 0022667bug_revision_view_page.php?bugnote_id=22667#r13881
2023-01-14 13:14ZalewaNote Added: 0022693
2023-01-14 13:14ZalewaStatusneeds testing => resolved
2023-01-14 13:14ZalewaFixed in Version => 1.4.0
2023-01-14 13:14ZalewaResolutionopen => fixed
2024-11-03 19:11ZalewaStatusresolved => closed

Notes
(0022039)
WubTheCaptain   
2021-12-28 13:20   
(edited on: 2021-12-28 13:23)
Target version for discontinuation (moving to legacy plugins) is undecided by Zalewa, so far.
(0022040)
WubTheCaptain   
2021-12-28 13:50   
Patch 1/? added to disable building it by default. Needs a mention of discontinuation (removal) in the changelog once the target version is clear. Not sure if this plugin needs to be "forbidden" too (but probably not).
(0022383)
Zalewa   
2022-09-10 14:39   
I will kill this plugin for 1.4.
(0022630)
Zalewa   
2023-01-04 16:55   
The killing blow:'https://bitbucket.org/Doomseeker/doomseeker/commits/368f0df909fbb7834ff8c78bfd735f529476ecce [^]'
(0022667)
Zalewa   
2023-01-05 12:41   
The testing here entails checking if the SRB2 plugin isn't being built from the source-code by default anymore. It can still be enabled by enabling the BUILD_LEGACY_PLUGINS option.
(0022693)
Zalewa   
2023-01-14 13:14   
I just checked that and the newly configured build only builds chocolatedoom, odamex, turok2ex, zandronum and zandronumq plugins. No srb2. Everything looks ok.