MantisBT - Doomseeker
View Issue Details
0003953DoomseekerUIpublic2021-12-21 13:432022-03-22 11:11
Zalewa 
Zalewa 
normaltweakN/A
closedfixed 
1.3.2 
1.3.31.3.3 
0003953: "Wadseeker - General" config page exists while "Wadseeker" is empty
The "File Paths" config node has both the "WAD Aliases" subnode and its own config page.

The "Wadseeker" config node only has 4 subnodes, one of them being "General". We could move the "General" page directly into the "Wadseeker" node and remove the "General" subnode.

Note that there is also the "Games" node which has subnodes for plugins and which doesn't have its own page because there's nothing to display on that page. Therefore if the "Wadseeker - General" page were to be moved, then "Games" would be the only node that behaves differently than the others.
This is trivial to do, but makes something disappear from the GUI which can be surprising to the end-user.
No tags attached.
jpg wadseeker-general-move.jpg (71,863) 2021-12-21 13:43
https://zandronum.com/tracker/file_download.php?file_id=2691&type=bug
jpg

patch 0001-CHANGELOG-Document-changes-to-config-nodes.patch (1,012) 2021-12-30 12:37
https://zandronum.com/tracker/file_download.php?file_id=2708&type=bug
Issue History
2021-12-21 13:43ZalewaNew Issue
2021-12-21 13:43ZalewaFile Added: wadseeker-general-move.jpg
2021-12-21 13:43ZalewaNote Added: 0021964
2021-12-21 16:20WaTaKiDNote Added: 0021966
2021-12-21 19:31ZalewaNote Added: 0021968
2021-12-22 04:22WubTheCaptainStatusnew => acknowledged
2021-12-27 22:58ZalewaTarget Version => 1.3.3
2021-12-27 23:54ZalewaNote Added: 0022022
2021-12-27 23:54ZalewaAssigned To => Zalewa
2021-12-27 23:54ZalewaStatusacknowledged => needs review
2021-12-30 12:23WubTheCaptainNote Added: 0022055
2021-12-30 12:23WubTheCaptainStatusneeds review => resolved
2021-12-30 12:23WubTheCaptainFixed in Version => 1.3.3
2021-12-30 12:23WubTheCaptainResolutionopen => fixed
2021-12-30 12:28WubTheCaptainAssigned ToZalewa => WubTheCaptain
2021-12-30 12:28WubTheCaptainStatusresolved => assigned
2021-12-30 12:28WubTheCaptainResolutionfixed => reopened
2021-12-30 12:37WubTheCaptainFile Added: 0001-CHANGELOG-Document-changes-to-config-nodes.patch
2021-12-30 12:37WubTheCaptainNote Added: 0022058
2021-12-30 12:37WubTheCaptainAssigned ToWubTheCaptain => Zalewa
2021-12-30 12:37WubTheCaptainStatusassigned => needs review
2021-12-30 12:38WubTheCaptainFixed in Version1.3.3 =>
2021-12-30 12:41WubTheCaptainNote Added: 0022059
2021-12-30 15:41ZalewaNote Added: 0022063
2021-12-30 15:41ZalewaStatusneeds review => resolved
2021-12-30 15:41ZalewaFixed in Version => 1.3.3
2021-12-30 15:41ZalewaResolutionreopened => fixed
2022-03-22 11:11WubTheCaptainStatusresolved => closed

Notes
(0021964)
Zalewa   
2021-12-21 13:43   
Yay or nay?
(0021966)
WaTaKiD   
2021-12-21 16:20   
for my personal use, im indifferent, but wut u say does make sense

as for the games node, im also indifferent, but ideas:
should it just be the games node and the window to the right have all plugins listed together, and scroll if needed?
would each game get a tab to switch to?
would there be a dropdown to select the game?
(0021968)
Zalewa   
2021-12-21 19:31   
Quote from WaTaKiD
as for the games node

The current subnodes hierarchy works well there and I wouldn't change it.

Quote from WaTaKiD
should it just be the games node and the window to the right have all plugins listed together, and scroll if needed?

No, that would be a mish-mash. Everything glued together. It's also best to avoid having a scrollbar if you can avoid it.

Quote from WaTaKiD

would each game get a tab to switch to?

This works only for a limited amount of games. When you have 6 and they have such long names, it stops working.

Quote from WaTaKiD
would there be a dropdown to select the game?

That could work, but it's a poorer substitute to what there is there now.

If I would use the general "Games" page for something, it would be to completely disable specific plugins. Right now it's possible to disable the querying of master servers for all the plugins, but all the interface for this plugin is still there. The user can only get rid of that by deleting the plugin's DLL altogether. However, "Games" is a separate matter for a different ticket.
(0022022)
Zalewa   
2021-12-27 23:54   
I just went ahead and did it:'https://bitbucket.org/Doomseeker/doomseeker/commits/7a19e49936a113a076727048c1d2f820ae98d5b1 [^]'

The problem with clicking on "Games" that was doing nothing was resolved so that clicking on "Games" hides the current page and displays an empty one.
(0022055)
WubTheCaptain   
2021-12-30 12:23   
I'm okay with this. Works for me. Seems like an improvement in my usability testing.
(0022058)
WubTheCaptain   
2021-12-30 12:37   
I added a changelog patch.
(0022059)
WubTheCaptain   
2021-12-30 12:41   
Would be kind of cool to checkout a new branch off from 7a19e49936a113a076727048c1d2f820ae98d5b1, apply this patch to it, then create a visible merge commit to master so it creates a reference in git log to the previous. My patch has been rebased to the origin/master HEAD, however.
(0022063)
Zalewa   
2021-12-30 15:41   
Changelog patch added:'https://bitbucket.org/Doomseeker/doomseeker/commits/76ad12dd1b246ffb692022911dce18253c3c5750 [^]'