MantisBT - Zandronum |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0003951 | Zandronum | [All Projects] Suggestion | public | 2021-12-19 23:36 | 2024-01-02 02:52 |
|
| Reporter | Trillster | |
| Assigned To | Kaminsky | |
| Priority | normal | Severity | feature | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | |
| Platform | Microsoft | OS | Windows 11 | OS Version | |
| Product Version | 3.1 | |
| Target Version | 3.2 | Fixed in Version | 3.2 | |
|
| Summary | 0003951: ACS function to change a team's score (frags, points, and wins) |
| Description | LMS currently has SetPlayerScore which can allow you to manipulate a player's wins in LMS, and we have PLAYERSEARNPOINTS and Team_GivePoints, which is enough to handle most other team modes which use points naturally, however,
TLMS does not properly support PLAYERSEARNPOINTS, failing to give points upon a round ending and not properly ending the match if points are given manually and the point limit is met, meaning Team_GivePoints is largely useless.
Teams in TLMS will properly gain wins on round win and I've never had issue with winlimit, however we don't have a function that allows manipulating of a team's win score, such as a potential Team_GiveWins. |
| Steps To Reproduce | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  MapActivatorScoreGive.pk3 (901) 2021-12-19 23:53
https://zandronum.com/tracker/file_download.php?file_id=2690&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2021-12-19 23:36 | Trillster | New Issue | |
| 2021-12-19 23:53 | Trillster | File Added: MapActivatorScoreGive.pk3 | |
| 2021-12-19 23:54 | Trillster | Note Added: 0021934 | |
| 2021-12-20 00:00 | Trillster | Note Edited: 0021934 | bug_revision_view_page.php?bugnote_id=21934#r13473 |
| 2022-04-24 21:32 | Kaminsky | Note Added: 0022197 | |
| 2022-04-24 21:32 | Kaminsky | Assigned To | => Kaminsky |
| 2022-04-24 21:32 | Kaminsky | Status | new => assigned |
| 2022-04-24 21:32 | Kaminsky | Product Version | 3.1-beta => 3.1 |
| 2022-04-24 21:32 | Kaminsky | Target Version | => 3.2 |
| 2022-04-24 21:32 | Kaminsky | Summary | Create Team_GiveWins or merge (T)LMS to use Points instead of Wins => ACS function to change a team's score (frags, points, and wins) |
| 2022-04-24 21:32 | Kaminsky | Status | assigned => needs testing |
| 2024-01-01 00:39 | Ru5tK1ng | Note Added: 0022944 | |
| 2024-01-02 00:30 | Kaminsky | Note Added: 0022955 | |
| 2024-01-02 02:51 | Ru5tK1ng | Note Added: 0022956 | |
| 2024-01-02 02:52 | Ru5tK1ng | Status | needs testing => resolved |
| 2024-01-02 02:52 | Ru5tK1ng | Resolution | open => fixed |
| 2024-01-02 02:52 | Ru5tK1ng | Fixed in Version | => 3.2 |
|
Notes |
|
|
(0021934)
|
|
Trillster
|
2021-12-19 23:54
(edited on: 2021-12-20 00:00) |
|
I've uploaded a file that showcases the issues with attempting to change TLMS into a point driven gamemode. The file has a GAMEMODE lump which removes PLAYERSEARNWINS and adds PLAYERSEARNPOINTS to TLMS and it implements an OPEN script that increments Team 0's points by 1 every second and a script, "PlayerActivatorScoreGive", that can be called via "pukename" in console.
Create a game of TLMS in Offline Skirmish with pointlimit 100.
Join the game alongside a bot, you'll notice that while Team 0's pointlimit is counting upwards, the scoreboard does not update to show how many points are remaining to get, instead just showing the cap of 100 still.
Additionally, if you call the "PlayerActivatorScoreGive" script once the game has started, it will interrupt the round declaring that Team 0 has won, but will then continue the match by starting another round.
|
|
|
|
|
3.2 now has "ChangeTeamScore" (int team, int type, int value, [bool announce]), which behaves similarly to "SetPlayerScore" and lets you change a team's frag, point, win, or death count. You'll also have the option to announce the score change.
The commit for this can be found here:'http://hg.osdn.net/view/zandronum/zandronum-stable/rev/428739fa5a92 [^]' |
|
|
|
|
Tested with 3.2a 231220-1743 and I was able to successfully change the score, wins, frags and deaths of teams in team gamemodes. Frags were tested in TDM, Points tested in TPossession and Wins tested in TLMS. Deaths were tracked with a script running GetTeamProperty. Announcer cues were working correctly with Points and Wins.
However, I'm unsure how to test the announcer with regards to Frags and Deaths. There is no key in ANCRINFO for either and EVENT scripts won't work because on the fly frag/death manipulation doesn't trigger them. |
|
|
|
|
Thanks for testing it out! It sounds like everything is working fine as promised.
To answer your question on the announcer: for frags (only when players earn frags in the current game mode), either the "teams are tied" announcement should play if all teams now have the same number of frags, or "{team} leads" if the team is now taking the lead in frags. Also, if the team now has three or less frags left to win, the announcer should play "three/two/one frags left", once for each.
Changing a team's death count doesn't trigger any announcements, so this parameter shouldn't do anything when SCORE_DEATHS is used. |
|
|
|
|
|
Thanks for clearing that up. I was able to trigger those messages and suppress the announcer as well. Since deaths are a non-factor in terms of announcement, I believe this ticket is now complete. |
|