MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003946DoomseekerUIpublic2021-12-18 09:222022-03-22 11:11
ReporterWubTheCaptain 
Assigned ToWubTheCaptain 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionduplicate 
PlatformOSOS Version
Product Version1.3.2 
Target Version1.3.3Fixed in Version1.3.3 
Summary0003946: No support for "Non-blocking lines can be pushed" compat_pushwindow flag in Zandronum 3 (3.1) plugin
Descriptioncompat_pushwindow was added to Zandronum 3.1, backporting old Zandronum 2.0 behaviour. Currently, the UI doesn't allow configuring this. The server browser also does not display "Non-blocking lines can be pushed" when viewing a Zandronum 3.1 server in the server browser with this compatibility flag enabled.
Dunno what the behaviour is with ZandronumQ.
Steps To Reproduce
$ grep -ir "PUSHWINDOW" src/plugins/zandronum | wc -l
0

  • src/plugins/zandronum/createserverdialogpages/flagsid.cpp
  • src/plugins/zandronum/createserverdialogpages/flagspagevaluecontroller3.cpp
  • src/plugins/zandronum/zandronum3dmflags.cpp
  • src/plugins/zandronum/zandronum3dmflags.h
  • src/plugins/zandronum/zandronumgamesettings.cpp
  • src/plugins/zandronum/zandronumgamesettings.h
  • src/plugins/zandronum/createserverdialogpages/flagspage.ui
Additional Information'https://hg.osdn.net/view/zandronum/zandronum-stable/rev/e834241f9d74 [^]'

compatflags 64 equals to compat_pushwindow ON with no other compatibility options.
Not to be confused with zacompatflags 64 (compat_explosionthrust ON), which Doomseeker has named (perhaps confusingly so) as "Old ZDoom horizontal thrust" at least in the English l10n. (Zandronum calls it "Explosion thrust like old ZDoom versions".)
TagsNo tags attached.
Relationships
duplicate of 0003938closed Zalewa Doomseeker Update Zandronum dmflags for Zandronum 3.1 
related to 0003115resolved Kaminsky Zandronum 3.0 breaks ladders on some maps 
Attached Filespng 2021-12-18-092618_maim.png (49,323) 2021-12-18 09:26
/tracker/file_download.php?file_id=2688&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-12-18 09:22WubTheCaptainNew Issue
2021-12-18 09:22WubTheCaptainSummaryNo support for "Non-blocking lines can be pushed" compatflag2 in Zandronum 3 (3.1) plugin => No support for "Non-blocking lines can be pushed" compat_pushwindow flag in Zandronum 3 (3.1) plugin
2021-12-18 09:22WubTheCaptainRelationship addedrelated to 0003115
2021-12-18 09:26WubTheCaptainFile Added: 2021-12-18-092618_maim.png
2021-12-18 09:27WubTheCaptainAssigned To => WubTheCaptain
2021-12-18 09:27WubTheCaptainStatusnew => assigned
2021-12-18 09:31WubTheCaptainNote Added: 0021921
2021-12-18 09:34WubTheCaptainNote Added: 0021922
2021-12-18 09:34WubTheCaptainRelationship addedduplicate of 0003938
2021-12-18 09:34WubTheCaptainStatusassigned => resolved
2021-12-18 09:34WubTheCaptainResolutionopen => duplicate
2021-12-18 09:50WubTheCaptainFixed in Version => 1.3.3
2021-12-18 09:50WubTheCaptainTarget Version => 1.3.3
2022-03-22 11:11WubTheCaptainStatusresolved => closed

Notes
(0021921)
WubTheCaptain   
2021-12-18 09:31   
There is, however, this:
$ grep -ir "PUSH_WINDOW" src/plugins/zandronum
src/plugins/zandronum/createserverdialogpages/flagsid.cpp:      f->cbCompatPushWindow->setProperty("flagname", 
COMPAT_PUSH_WINDOW);
src/plugins/zandronum/zandronum3dmflags.cpp:    section << DMFlag(COMPAT_PUSH_WINDOW, COMPATF2_PUSHWINDOW,

src/plugins/zandronum/zandronumgamesettings.cpp:const QString COMPAT_PUSH_WINDOW = "CompatPushWindow";;

src/plugins/zandronum/zandronumgamesettings.h:extern const QString COMPAT_PUSH_WINDOW;
(0021922)
WubTheCaptain   
2021-12-18 09:34   
Turns out my Git tree was out of date. 🤦