MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003939Doomseeker[All Projects] Suggestionpublic2021-12-12 22:432022-03-22 11:11
ReporterDrinkyBird 
Assigned ToZalewa 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version1.3.3Fixed in Version1.3.3 
Summary0003939: Add support for Zandronum's SQF2_COUNTRY
DescriptionZandronum 3.1 adds a new SQF2_COUNTRY query field, which allows servers to specify their own country without relying on IP geolocation.
Steps To Reproduce
Additional Information'https://wiki.zandronum.com/Launcher_protocol [^]'
'https://osdn.net/projects/zandronum/scm/hg/zandronum-stable/commits/248113fb1bb6 [^]'
TagsNo tags attached.
Relationships
related to 0003894resolved DrinkyBird Zandronum Allow servers to present their country to launchers 
Attached Filespng doomseekerCountryTooltip.png (7,222) 2021-12-21 17:23
https://zandronum.com/tracker/file_download.php?file_id=2692&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-12-12 22:43DrinkyBirdNew Issue
2021-12-12 22:44DrinkyBirdNote Added: 0021887
2021-12-12 23:02DrinkyBirdNote Edited: 0021887bug_revision_view_page.php?bugnote_id=21887#r13436
2021-12-12 23:05WaTaKiDRelationship addedrelated to 0003894
2021-12-12 23:06WaTaKiDNote Added: 0021889
2021-12-13 01:01Pol MStatusnew => confirmed
2021-12-13 07:37ZalewaNote Edited: 0021887bug_revision_view_page.php?bugnote_id=21887#r13439
2021-12-21 10:44ZalewaAssigned To => Zalewa
2021-12-21 10:44ZalewaStatusconfirmed => assigned
2021-12-21 13:45ZalewaNote Added: 0021965
2021-12-21 13:45ZalewaStatusassigned => needs review
2021-12-21 17:23DrinkyBirdNote Added: 0021967
2021-12-21 17:23DrinkyBirdFile Added: doomseekerCountryTooltip.png
2021-12-21 17:26DrinkyBirdNote Edited: 0021967bug_revision_view_page.php?bugnote_id=21967#r13490
2021-12-21 19:32ZalewaNote Added: 0021969
2021-12-21 19:32ZalewaStatusneeds review => assigned
2021-12-22 19:32ZalewaNote Added: 0021978
2021-12-22 19:32ZalewaStatusassigned => needs testing
2021-12-22 20:42WaTaKiDNote Added: 0021983
2021-12-22 22:10DrinkyBirdNote Added: 0021987
2021-12-23 00:31ZalewaStatusneeds testing => resolved
2021-12-23 00:31ZalewaFixed in Version => 1.3.3
2021-12-23 00:31ZalewaResolutionopen => fixed
2021-12-23 09:29ZalewaNote Added: 0021993
2021-12-23 09:30ZalewaNote Deleted: 0021993
2021-12-23 12:02WubTheCaptainNote Added: 0021996
2021-12-28 12:29WubTheCaptainTarget Version => 1.3.3
2022-03-22 11:11WubTheCaptainStatusresolved => closed

Notes
(0021887)
DrinkyBird   
2021-12-12 22:44   
(edited on: 2021-12-13 07:37)
Should mention this is related to 0003894 (which is closed so I can't edit it and add a relationship).
(0021889)
WaTaKiD   
2021-12-12 23:06   
added the relationship
(0021965)
Zalewa   
2021-12-21 13:45   
Commits:

1.'https://bitbucket.org/Doomseeker/doomseeker/commits/cfbf2f8e7ef43a65190b88573d482c95cc001251 [^]'
2.'https://bitbucket.org/Doomseeker/doomseeker/commits/3c999eb21a85d0e0e99e800102a9f39e216b1d58 [^]'

Doomseeker will honor the SQF2_COUNTRY field by default but the user is permitted to disable this option.
(0021967)
DrinkyBird   
2021-12-21 17:23   
(edited on: 2021-12-21 17:26)
I notice that the tooltip when you hover over a server with SQF2_COUNTRY set still shows the IP2C result, instead of the country the server specified. See attached PNG, the server has sv_country set to DEU (as an example), but the tooltip still says UK.
(0021969)
Zalewa   
2021-12-21 19:32   
Good catch. I'll fix that.
(0021978)
Zalewa   
2021-12-22 19:32   
This rather large commit should fix this. I couldn't help myself but refactor the IP2C code too a bit:'https://bitbucket.org/Doomseeker/doomseeker/commits/82634a1c5a87c665966c1d440cc400f70d4eb126 [^]'

The updated plugin was released on the beta channel.
(0021983)
WaTaKiD   
2021-12-22 20:42   
played around with the server country setting a bit and it seems to work correctly
(0021987)
DrinkyBird   
2021-12-22 22:10   
Yep, Doomseeker seems to use the country given by the server correctly. The option to always use IP2C works too.
(0021996)
WubTheCaptain   
2021-12-23 12:02   
Suggesting to update the copyright headers in files for significant rewrites like these.