MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003937Doomseeker[All Projects] Bugpublic2021-12-11 20:022024-11-03 19:16
ReporterZalewa 
Assigned ToZalewa 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.3.2 
Target VersionFixed in Version1.3.3 
Summary0003937: Most of the Odamex game modes are non-functional in the Create Game box
DescriptionThe Create Game box permits to select many game modes when creating an Odamex game. However, only "Coop", "DM", "Team DM" and "CTF" are actually functional.

Selecting other game modes functions as if no game mode was selected at all.
Steps To Reproduce1. In Create Game box select Odamex, then choose a game mode such as "Last Marine Standing".
2. Click the "Command Line" button at the bottom.
3. The generated command line will be void of any arguments that could establish the LMS game mode.
Additional InformationOdamex treats many of its game modes as derivatives of the the basic DM, Team DM or CTF (and also Horde in Odamex 10.0). As so it doesn't have a strict game mode for them. Instead these game modes are enabled by first choosing the primary game mode and then setting g_lives and g_sides variables to values greater than zero.

Quote from AlexMax
also here's the official gamemode stack for us
'https://github.com/odamex/odamex/blob/protobuf-baseline/common/g_gametype.cpp#L61 [^]'
g_gametypename is not (currently) intended to be interpreted by server browsers due to the naming issues
G_IsHordeMode is just something that checks for gametype 4 or an autodetection of horde maps in single-player.


TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-12-11 20:02ZalewaNew Issue
2021-12-11 20:12ZalewaNote Added: 0021884
2021-12-11 21:16WubTheCaptainStatusnew => confirmed
2021-12-11 21:46WubTheCaptainNote Added: 0021885
2021-12-13 17:32ZalewaAdditional Information Updatedbug_revision_view_page.php?rev_id=13441#r13441
2021-12-23 14:52AlexMaxNote Added: 0022003
2021-12-23 15:00AlexMaxNote Edited: 0022003bug_revision_view_page.php?bugnote_id=22003#r13505
2021-12-23 15:01AlexMaxNote Edited: 0022003bug_revision_view_page.php?bugnote_id=22003#r13506
2021-12-23 16:34ZalewaAssigned To => Zalewa
2021-12-23 16:34ZalewaStatusconfirmed => assigned
2021-12-23 19:46ZalewaNote Added: 0022004
2021-12-23 19:46ZalewaStatusassigned => needs testing
2021-12-23 19:46ZalewaNote Edited: 0022004bug_revision_view_page.php?bugnote_id=22004#r13508
2022-09-10 15:04ZalewaNote Added: 0022385
2022-09-10 15:04ZalewaStatusneeds testing => resolved
2022-09-10 15:04ZalewaFixed in Version => 1.3.3
2022-09-10 15:04ZalewaResolutionopen => fixed
2024-11-03 19:16ZalewaStatusresolved => closed

Notes
(0021884)
Zalewa   
2021-12-11 20:12   
We should discuss how to solve this.

The first wrong is that while both Doomseeker and Odamex support setting a number of lives for players, the relevant UI control never appears for any of the Odamex game modes (not even LMS or Survival). This should be fixed.

Then I propose to disallow setting this to values below 1, because if the user would chose a "Survival" game mode and then set the lives to 0 it would instruct Odamex to start a "Coop" game instead. Similarly for DM vs LMS, TDM vs TLMS, CTF vs LMS-CTF and Horde vs Survival Horde.

The outstanding Attack & Defend CTF can be simply handled by the plugin by enforcing the g_sides=1 variable when this mode is selected.

Finally, the Duel game mode is just DM with max players set to 2, so it should enforce the max players to 2.
(0021885)
WubTheCaptain   
2021-12-11 21:46   
Quote from Zalewa
Then I propose to disallow setting this to values below 1, because if the user would chose a "Survival" game mode and then set the lives to 0 it would instruct Odamex to start a "Coop" game instead.

Not related to Odamex, but at least Zandronum will treat a Survival gamemode with +sv_maxlives 0 as a 1 life Survival Coop game. (Negative values seem to be treated as 0, the same as prior.) Should make sure any changes are done only done to the Odamex plugin, of course.
Quote from Zalewa
Finally, the Duel game mode is just DM with max players set to 2, so it should enforce the max players to 2.

It's a bit of a narrow-minded approach taken by Odamex (unsimilar to Zandronum's which accepts more max players on a duel server), but currently that's what it does.
'https://github.com/odamex/odamex/blob/c00874bc26b40c1c8577512e3b40a77b8cd96775/common/g_gametype.cpp#L51-L88 [^]'
Note there is no minimum amount of players required for Duel (can also be a negative number?), and if lives are set then it's a Last Marine Standing game. Need to make sure there are no g_lives for Duel.
(0022003)
AlexMax   
2021-12-23 14:52   
(edited on: 2021-12-23 15:01)
> It's a bit of a narrow-minded approach taken by Odamex

Well, the idea behind it was that we wanted fewer, more customizable gamemodes. It's more like Halo than Unreal Tournament, where there's a "base gamemode" but then there's additional user customization on top of that, which can have its own name. The game mode names I pointed out in my OP are purely informational and merely a suggestion.

If you ask me, trying to translate game mode names to their cvar equivalents is trying to swim upstream, because that's the opposite of how Odamex works. I'd recommend sticking to the base gamemodes and then maybe having a button that sets the proper settings for Survival or Duel.
(0022004)
Zalewa   
2021-12-23 19:46   
I've already released the beta build for this so I'm putting this ticket directly into testing.

Commits:
1. Preparatory to improve the editors in Create Game / Rules:'https://bitbucket.org/Doomseeker/doomseeker/commits/0c1377e429a81f3465ebe40cf0a28ac6a1d46a95 [^]'
2. The matter at hand:'https://bitbucket.org/Doomseeker/doomseeker/commits/d4cc0425f9b39794078eb10febfdc26fea4b08df [^]'
(0022385)
Zalewa   
2022-09-10 15:04   
This was fixed in the 1.3.3 release.