MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003933Doomseeker[All Projects] Cleanuppublic2021-12-09 01:582022-03-22 11:11
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynormalSeverityminorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.3.2 
Target Version1.3.3Fixed in Version1.3.3 
Summary0003933: CMakeLists.txt legacy "else(expression)" is confusing and unnecessary
DescriptionBackground: 0003280:0020368 and 0003931. I'm aggravated to confuse myself with the same insanity 2½ years later: "elseif(expression)" being written as "else(expression)".
Please don't hurt me anymore. It's either "elseif(expression2)" or just "else()".
Steps To Reproduce
Additional Information'https://cmake.org/cmake/help/v3.13/command/if.html [^]'
'https://cmake.org/cmake/help/v3.14/command/if.html [^]'
TagsNo tags attached.
Relationships
Attached Filespatch 0001-CMakeLists-Replace-confusing-else-expression.patch (4,190) 2021-12-09 02:26
/tracker/file_download.php?file_id=2686&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-12-09 01:58WubTheCaptainNew Issue
2021-12-09 01:58WubTheCaptainStatusnew => assigned
2021-12-09 01:58WubTheCaptainAssigned To => WubTheCaptain
2021-12-09 02:26WubTheCaptainFile Added: 0001-CMakeLists-Replace-confusing-else-expression.patch
2021-12-09 02:26WubTheCaptainNote Added: 0021863
2021-12-09 02:26WubTheCaptainAssigned ToWubTheCaptain =>
2021-12-09 02:26WubTheCaptainStatusassigned => needs review
2021-12-09 02:30WubTheCaptainDescription Updatedbug_revision_view_page.php?rev_id=13411#r13411
2021-12-09 02:37WubTheCaptainNote Added: 0021864
2021-12-09 02:38WubTheCaptainNote Edited: 0021864bug_revision_view_page.php?bugnote_id=21864#r13413
2021-12-09 02:39WubTheCaptainNote Edited: 0021864bug_revision_view_page.php?bugnote_id=21864#r13414
2021-12-09 02:39WubTheCaptainNote Edited: 0021864bug_revision_view_page.php?bugnote_id=21864#r13415
2021-12-09 02:39WubTheCaptainNote Edited: 0021864bug_revision_view_page.php?bugnote_id=21864#r13416
2021-12-09 02:40WubTheCaptainNote Edited: 0021864bug_revision_view_page.php?bugnote_id=21864#r13417
2021-12-09 02:44WubTheCaptainDescription Updatedbug_revision_view_page.php?rev_id=13422#r13422
2021-12-15 19:01ZalewaNote Added: 0021898
2021-12-15 19:01ZalewaStatusneeds review => resolved
2021-12-15 19:01ZalewaFixed in Version => 1.3.3
2021-12-15 19:01ZalewaResolutionopen => fixed
2021-12-15 19:01ZalewaAssigned To => Zalewa
2022-03-22 11:11WubTheCaptainStatusresolved => closed

Notes
(0021863)
WubTheCaptain   
2021-12-09 02:26   
Is the patch good?
(0021864)
WubTheCaptain   
2021-12-09 02:37   
(edited on: 2021-12-09 02:40)
According to old documentation, I can interpret this drops support for CMake 2.6. But we declared in CMakeLists CMake 3.5 as the minimum supported version a long ago for some files, and have already used else() a lot. CMake 2.8 has also documented expression in else() being optional, so it seems to retain theoretical support.
(0021898)
Zalewa   
2021-12-15 19:01   
Merged it. Thanks.