0003908: zandronumbinaries.cpp does not make sure the downloaded Zandronum testing binaries are supported by the CPU architecture

MantisBT - Doomseeker

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0003908

Doomseeker

[All Projects] Bug

public

2021-09-24 17:29

2021-09-27 11:45

Reporter

WubTheCaptain

Assigned To

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

acknowledged

Resolution

open

Platform

OS Version

Product Version

1.3.2

Target Version

Fixed in Version

Summary

0003908: zandronumbinaries.cpp does not make sure the downloaded Zandronum testing binaries are supported by the CPU architecture

Description

A theoretical scenario: An user is running on GNU/Linux using an ARM processor (32-bit or 64-bit). They try to download Zandronum testing binaries. Instead of Doomseeker refusing to download anything or theoretically attempt to download a file appropriate for the architecture build (such as ARM), Doomseeker will always download the x86 (32-bit) binaries.

On Windows (if ever on non-x86), they would always get 32-bit x86 Windows binaries for Zandronum.

The issue is the program didn't check the build or CPU architecture.

Steps To Reproduce

Quote from src/plugins/zandronum/zandronumbinaries.cpp

#ifdef Q_OS_WIN32
#define TESTING_BINARY_URL TESTING_BINARY_URL_BASE "windows.zip"
#define ZANDRONUM_BINARY_NAME "zandronum.exe"
#define SCRIPT_FILE_EXTENSION ".bat"
#else

#ifndef __x86_64__
#define TESTING_BINARY_URL TESTING_BINARY_URL_BASE "linux-x86.tar.bz2"
#else
#define TESTING_BINARY_URL TESTING_BINARY_URL_BASE "linux-x86_64.tar.bz2"
#endif

#ifndef Q_OS_DARWIN
#define ZANDRONUM_BINARY_NAME "zandronum"
#else
#define ZANDRONUM_BINARY_NAME "Zandronum.app"
#define ZANDRONUM_APP_BUNDLE_BIN "/Contents/MacOS/zandronum"
#endif
#define SCRIPT_FILE_EXTENSION ".sh"
#endif

Additional Information

QSysInfo::buildCpuArchitecture()
QSysInfo::currentCpuArchitecture()