MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003875Zandronum[All Projects] Bugpublic2021-01-21 21:042024-07-28 00:21
ReporterGen420 
Assigned ToKaminsky 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0 
Target Version3.2Fixed in Version3.2 
Summary0003875: Co-op Spying + ACS ChangeCamera() Bug
DescriptionNot sure if this has been reported before, but it certainly hasn't been fixed, i didn't find a tracker issue about this so here goes:

Basically the ACS function for changing the camera changes the POV, but doesn't revert to your original hud if you were co-op spying someone before hand. I'd propose to make it so that if you were co-op spying before hand, and the camera change occurs, that when the is back in the local players eyes, that the HUD is that of the local player again, as it should be.
Steps To Reproduce1. Load a map which has the ACS ChangeCamera in it
2. Co-op spy your ally
3. Have the ACS ChangeCamera interject at this point by changing your camera to another POV
4.1 Co-op spy to revert back to your own vision
  OR
4.2 ACS ChangeCamera(0,x,x) to have the camera return to you.
RESULT: Your camera is back in your body, but the HUD, the info, the player colored mugshot, and the screen pain flash (i think) are that of the player you were spectating before the camera change.

Expected: Along with your camera reverting back, your HUD reverts back as well.
Additional InformationMost noticable in co-op with cutscene heavy wads, a la UACMN and the like.
Works both with online players, and with bots! Bonus points if you do that with a bot, then kick the bot!
TagsNo tags attached.
Relationships
Attached Files? changecamera_spy_01.wad (1,707) 2024-03-11 11:34
https://zandronum.com/tracker/file_download.php?file_id=2933&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-01-21 21:04Gen420New Issue
2021-01-21 21:48KaminskyNote Added: 0021593
2021-01-24 22:30KaminskyNote Edited: 0021593bug_revision_view_page.php?bugnote_id=21593#r13281
2021-03-25 16:23Gen420Note Added: 0021611
2021-07-23 21:06KaminskyAssigned To => Kaminsky
2021-07-23 21:06KaminskyStatusnew => needs testing
2024-03-11 11:34unknownnaFile Added: changecamera_spy_01.wad
2024-03-11 11:36unknownnaNote Added: 0023359
2024-03-11 11:36unknownnaStatusneeds testing => feedback
2024-07-27 13:30KaminskyNote Added: 0023825
2024-07-27 13:30KaminskyStatusfeedback => needs review
2024-07-27 13:30KaminskyTarget Version => 3.2
2024-07-28 00:21unknownnaNote Added: 0023839
2024-07-28 00:21unknownnaStatusneeds review => resolved
2024-07-28 00:21unknownnaFixed in Version => 3.2
2024-07-28 00:21unknownnaResolutionopen => fixed

Notes
(0021593)
Kaminsky   
2021-01-21 21:48   
(edited on: 2021-01-24 22:30)
I'll take a look at this.

EDIT: This got fixed in'https://osdn.net/projects/zandronum/scm/hg/zandronum-stable/commits/295287439af9f7220490e8cc0563385c65715fc5 [^]'
(0021611)
Gen420   
2021-03-25 16:23   
Ah, I hadn't noticed. Good work, Cheers!
(0023359)
unknownna   
2024-03-11 11:36   
Was this ever added to 3.1 or 3.2? I can still reproduce the issue with the example wad I made.

If I coop spy on another player before the camera changes with a switch, and then revert back to my own view with "spynext", the HUD still uses the coop spy player's numbers.
(0023825)
Kaminsky   
2024-07-27 13:30   
Quote from "unknownna"
Was this ever added to 3.1 or 3.2? I can still reproduce the issue with the example wad I made.


In 3.1, I fixed the HUD not updating to match the player being spied on, if ChangeCamera was used to change the player's view to another player. At the time, I thought this was the only issue with this function. However, I see that there's still more issues to address. This merge request:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/146 [^]' should fix the HUD not reverting the HUD back to the local player if they were already spying on another player and ChangeCamera changes their view to a non-player actor. Likewise, it fixes the HUD not reverting back to the local player if they were spying on another player and their view reverts back to them because they moved.
(0023839)
unknownna   
2024-07-28 00:21   
Tested the fix and it seems to work now. Great work, thanks.