MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003855Zandronum[All Projects] Suggestionpublic2020-08-10 19:052020-08-10 19:05
ReporterFilystea 
Assigned To 
PrioritynoneSeverityfeatureReproducibilityalways
StatusnewResolutionopen 
PlatformopenbdsmOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0003855: Somehow on Linux this was never poping out.
Description

Each time i compile I hit this.
upnpnat/xmlParser.c│;
pp:663:27: error:
      cast from pointer to smaller type 'char' loses
      information
        lpszNew[cbData] = (TCHAR)NULL

HERE:

// Duplicate a given string.
LPTSTR stringDup(LPCTSTR lpszData, int cbData)
{
    if (lpszData==NULL) return NULL;

    LPTSTR lpszNew;
    if (cbData==0) cbData=(int)_tcslen(lpszData);
    lpszNew = (LPTSTR)malloc((cbData+1) * sizeof(TCHAR));
    if (lpszNew)
    {
        memcpy(lpszNew, lpszData, (cbData) * sizeof(TCHAR));

// Here was NULL instead of '\0'
        lpszNew[cbData] = (TCHAR)'\0';


    }
    return lpszNew;
}



Feels like I hit some forgotten code.
Steps To ReproduceCumpile
Additional InformationGod forbid
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-08-10 19:05FilysteaNew Issue

There are no notes attached to this issue.