MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003851Doomseeker[All Projects] Bugpublic2020-07-28 22:022021-08-10 05:45
ReporterfrozenLake 
Assigned ToPol M 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.3 
Target Version1.3.2Fixed in Version1.3.2 
Summary0003851: Malformed serverinfo data from SRB2 versions > 2.2.6
DescriptionThis problem is similar to the issue seen with SRB2 Kart, except that, since it is now happening to the main version of the game, there are no servers that display correctly.

Most 2.2 servers will not display at all, and the ones that do fail to list any of the files that are loaded, along with the server's name, and... basically any useful information, other than player count and IP. It does not even display the files as corrupted data, like how SRB2 Kart would.
Steps To ReproduceJust open up doomseeker and look for SRB2 Servers.
Additional InformationThe cause of this is due to the format for serverinfo changing between versions. The current version of the serverinfo, structure wise, can be found here.'https://github.com/STJr/SRB2/blob/SRB2_release_2.2.6/src/d_clisrv.c#L1832 [^]'

The only way to prevent problems like this in the future would be to filter out all servers that do not have a matching version and or packet version, but that would just mean that all the servers would be invisible until the next update of the plugin.
TagsNo tags attached.
Relationships
related to 0003852closed Zalewa Doomseeker 1.3.2 release 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-07-28 22:02frozenLakeNew Issue
2020-07-30 22:42Pol MNote Added: 0021513
2020-07-30 22:42Pol MAssigned To => Pol M
2020-07-30 22:42Pol MStatusnew => acknowledged
2020-07-30 22:43Pol MPrioritynormal => urgent
2020-08-01 12:16Pol MNote Added: 0021514
2020-08-01 12:17Pol MStatusacknowledged => needs review
2020-08-01 16:28WubTheCaptainNote Added: 0021515
2020-08-01 16:29WubTheCaptainNote Added: 0021516
2020-08-01 16:47WubTheCaptainRelationship addedrelated to 0003852
2020-08-01 17:08WubTheCaptainSummaryMajor update to SRB2 has completely broken Doomseeker compatability. => Malformed serverinfo data from SRB2 versions > 2.2.6
2020-08-01 17:40Pol MNote Added: 0021519
2020-08-02 08:00ZalewaNote Added: 0021521
2020-08-02 12:19WubTheCaptainStatusneeds review => resolved
2020-08-02 12:19WubTheCaptainResolutionopen => fixed
2020-08-02 12:20WubTheCaptainStatusresolved => needs testing
2020-08-02 12:20WubTheCaptainResolutionfixed => open
2020-08-02 12:28WubTheCaptainTarget Version => 1.3.3
2020-08-02 18:29Pol MNote Added: 0021525
2020-08-02 18:30Pol MNote Edited: 0021525bug_revision_view_page.php?bugnote_id=21525#r13258
2020-08-02 18:30Pol MStatusneeds testing => resolved
2020-08-02 18:30Pol MResolutionopen => fixed
2020-08-09 08:59ZalewaNote Added: 0021527
2021-08-07 16:47Blzut3Fixed in Version => 1.3.2
2021-08-07 16:47Blzut3Target Version1.3.3 => 1.3.2
2021-08-10 05:45WubTheCaptainStatusresolved => closed

Notes
(0021513)
Pol M   
2020-07-30 22:42   
I'll take a look tomorrow, thank you for the report, and I'll try to fix this as soon as it is possible. For the meantime, I'm afraid you'll need to disable SRB2 as nothing good can come from malformed data. Have a good summer!
(0021514)
Pol M   
2020-08-01 12:16   
PR Done, I think that this asks for a minor release, I'll let Zalewa decide. On the mean time, you can always build doomseeker yourself and get going with SRB2!
(0021515)
WubTheCaptain   
2020-08-01 16:28   
One line in the commit description exceeds 72 characters, Pol.
(0021516)
WubTheCaptain   
2020-08-01 16:29   
Btw, you seem to be 4 commits behind master. But alright.
(0021519)
Pol M   
2020-08-01 17:40   
Fixed :)
(0021521)
Zalewa   
2020-08-02 08:00   
PR merged
(0021525)
Pol M   
2020-08-02 18:29   
(edited on: 2020-08-02 18:30)
Considering that it is no longer broken, I think this can be closed :)

It's a pretty trivial change after all :)
(0021527)
Zalewa   
2020-08-09 08:59   
I deployed the updated SRB2 plugin version 15 to the beta and stable auto update channels and also to the site as the Plugin Update 1.