MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003769Zandronum[All Projects] Bugpublic2020-03-18 23:482024-02-29 21:13
Reportersosleepy 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSUbuntu x86_64OS VersionEoan
Product Version3.0 
Target Version3.1Fixed in Version3.1 
Summary0003769: Bots tries to jump to reach item when sv_nojump is true
DescriptionWAD attached for easy reproduction of the issue. My guess is the issue can be easily solved by editing the ternary at line 464 in src/botpath.cpp to check the value of sv_nojump. I would appreciate if someone taught me how to have the current values of the server variables to try it myself.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files? testbot.wad (2,716) 2020-03-18 23:48
/tracker/file_download.php?file_id=2564&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-03-18 23:48sosleepyNew Issue
2020-03-18 23:48sosleepyFile Added: testbot.wad
2020-03-24 22:10sosleepyNote Added: 0021232
2020-03-25 01:12sosleepyNote Added: 0021234
2020-03-25 19:00sosleepyNote Added: 0021238
2020-03-29 19:17Torr SamahoNote Added: 0021244
2020-03-29 19:18Torr SamahoAssigned To => Torr Samaho
2020-03-29 19:18Torr SamahoStatusnew => needs testing
2020-03-29 19:19Torr SamahoAssigned ToTorr Samaho =>
2024-02-29 21:13Ru5tK1ngNote Added: 0023126
2024-02-29 21:13Ru5tK1ngStatusneeds testing => resolved
2024-02-29 21:13Ru5tK1ngResolutionopen => fixed
2024-02-29 21:13Ru5tK1ngStatusresolved => feedback
2024-02-29 21:13Ru5tK1ngResolutionfixed => reopened
2024-02-29 21:13Ru5tK1ngStatusfeedback => resolved
2024-02-29 21:13Ru5tK1ngResolutionreopened => fixed
2024-02-29 21:13Ru5tK1ngFixed in Version => 3.1
2024-02-29 21:13Ru5tK1ngTarget Version => 3.1

Notes
(0021232)
sosleepy   
2020-03-24 22:10   
Fixed, needs testing since this fix is fairly invasive.
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/225/player-and-bots-shouldnt-attempt-to-jump/diff [^]'
(0021234)
sosleepy   
2020-03-25 01:12   
Considering the locations this method is used, I would say it is a safe change.

$ grep -R CalcJumpHeight
src/botpath.cpp: fixed_t jumpheight = ( pActor->IsKindOf (RUNTIME_CLASS (APlayerPawn)) ) ? static_cast<APlayerPawn*>( pActor )->CalcJumpHeight( ) : 60;
src/d_player.h: fixed_t CalcJumpHeight( bool bAddStep = true );
src/p_user.cpp:fixed_t APlayerPawn::CalcJumpHeight( bool bAddStepZ )
(0021238)
sosleepy   
2020-03-25 19:00   
There might be a better way, from these notes:
'https://zandronum.com/tracker/view.php?id=3775#c21236 [^]'
'https://zandronum.com/tracker/view.php?id=3775#c21237 [^]'
The following values are relevant: BOTCMD_JUMP (59), BOTCMD_BEGINJUMPING (60), BOTCMD_STOPJUMPING (61).
(0021244)
Torr Samaho   
2020-03-29 19:17   
I added your patch.
(0023126)
Ru5tK1ng   
2024-02-29 21:13   
Assuming the patch worked considering no new comment in almost 4 years.