MantisBT - Doomseeker
View Issue Details
0003758Doomseeker[All Projects] Bugpublic2020-01-30 17:232021-08-16 19:09
WubTheCaptain 
Pol M 
normaltrivialalways
closedfixed 
1.3 
1.3.21.3.2 
0003758: Non-dominating UNIX newline in src/core/datapaths.h
0003740:0021168:
Quote from Zalewa
Newline consistency across the whole project is not needed. It's only needed to have newline consistency in a file. If there are inconsistent lines in some file then this file has problems and should be fixed.

There's tools/normalize_nl.py in the Doomseeker repo that can scour a whole subdirectory tree and alter all files within it to have the dominating newline style in each file be the consistent one in that single file.

Files that are 3rd party should not be modified even if they have inconsistent newlines.

0003740:0021170:
Quote from WubTheCaptain
Actually, one line is not consistent in src/core/datapaths.h.
git clone'https://bitbucket.org/Doomseeker/doomseeker/ [^]'
cd doomseeker
git checkout 1.3.1
python3 ./tools/src/ src/ .cpp,.c,.h,.hpp
# git diff --cached, or some other way such as git commit -av to view staged diffs
No tags attached.
related to 0003740closed WubTheCaptain Newlines in git show may show up as ^M 
patch 0001-Normalize-newlines-to-the-dominating-newline-style.patch (947) 2020-01-30 17:25
https://zandronum.com/tracker/file_download.php?file_id=2561&type=bug
Issue History
2020-01-30 17:23WubTheCaptainNew Issue
2020-01-30 17:23WubTheCaptainStatusnew => assigned
2020-01-30 17:23WubTheCaptainAssigned To => WubTheCaptain
2020-01-30 17:25WubTheCaptainFile Added: 0001-Normalize-newlines-to-the-dominating-newline-style.patch
2020-01-30 17:25WubTheCaptainStatusassigned => needs review
2020-01-30 17:26WubTheCaptainRelationship addedrelated to 0003740
2020-01-30 17:28WubTheCaptainNote Added: 0021172
2020-01-30 17:28WubTheCaptainNote Edited: 0021172bug_revision_view_page.php?bugnote_id=21172#r13014
2020-01-30 17:31WubTheCaptainAssigned ToWubTheCaptain => Pol M
2020-01-30 17:31WubTheCaptainStatusneeds review => assigned
2020-01-30 17:31WubTheCaptainStatusassigned => needs review
2020-01-30 17:42ZalewaNote Added: 0021174
2020-01-30 17:42WubTheCaptainNote Added: 0021175
2020-01-30 17:42WubTheCaptainStatusneeds review => resolved
2020-01-30 17:42WubTheCaptainFixed in Version => 1.3.3
2020-01-30 17:42WubTheCaptainResolutionopen => fixed
2020-01-30 17:49WubTheCaptainProduct Version1.3.1 => 1.3
2020-01-30 19:36Pol MNote Added: 0021176
2021-08-07 16:53Blzut3Statusresolved => closed
2021-08-16 19:09WubTheCaptainFixed in Version1.3.3 => 1.3.2
2021-08-16 19:09WubTheCaptainTarget Version1.3.3 => 1.3.2

Notes
(0021172)
WubTheCaptain   
2020-01-30 17:28   
As for why this happened: Commit 4fb646d23 by Pol M. Not sure if it's because of an automated tool? The diff for that commit has both DOS newlines and UNIX newlines in it.

(0021174)
Zalewa   
2020-01-30 17:42   
Applied
(0021175)
WubTheCaptain   
2020-01-30 17:42   
'https://bitbucket.org/Doomseeker/doomseeker/commits/41293c52803b07e4938b97c8e5294629f88fdb86 [^]'

🤷
(0021176)
Pol M   
2020-01-30 19:36   
I have absolutely no idea why this happened exclusively on this file 🤷🏻‍♂️