MantisBT - Doomseeker |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0003758 | Doomseeker | [All Projects] Bug | public | 2020-01-30 17:23 | 2021-08-16 19:09 |
|
Reporter | WubTheCaptain | |
Assigned To | Pol M | |
Priority | normal | Severity | trivial | Reproducibility | always |
Status | closed | Resolution | fixed | |
Platform | | OS | | OS Version | |
Product Version | 1.3 | |
Target Version | 1.3.2 | Fixed in Version | 1.3.2 | |
|
Summary | 0003758: Non-dominating UNIX newline in src/core/datapaths.h |
Description | 0003740:0021168:
Quote from Zalewa Newline consistency across the whole project is not needed. It's only needed to have newline consistency in a file. If there are inconsistent lines in some file then this file has problems and should be fixed.
There's tools/normalize_nl.py in the Doomseeker repo that can scour a whole subdirectory tree and alter all files within it to have the dominating newline style in each file be the consistent one in that single file.
Files that are 3rd party should not be modified even if they have inconsistent newlines.
0003740:0021170:
Quote from WubTheCaptain Actually, one line is not consistent in src/core/datapaths.h. |
Steps To Reproduce | git clone'https://bitbucket.org/Doomseeker/doomseeker/ [^]'
cd doomseeker
git checkout 1.3.1
python3 ./tools/src/ src/ .cpp,.c,.h,.hpp
# git diff --cached, or some other way such as git commit -av to view staged diffs |
Additional Information | |
Tags | No tags attached. |
Relationships | related to | 0003740 | closed | WubTheCaptain | Newlines in git show may show up as ^M |
|
Attached Files | 0001-Normalize-newlines-to-the-dominating-newline-style.patch (947) 2020-01-30 17:25 https://zandronum.com/tracker/file_download.php?file_id=2561&type=bug |
|
Issue History |
Date Modified | Username | Field | Change |
2020-01-30 17:23 | WubTheCaptain | New Issue | |
2020-01-30 17:23 | WubTheCaptain | Status | new => assigned |
2020-01-30 17:23 | WubTheCaptain | Assigned To | => WubTheCaptain |
2020-01-30 17:25 | WubTheCaptain | File Added: 0001-Normalize-newlines-to-the-dominating-newline-style.patch | |
2020-01-30 17:25 | WubTheCaptain | Status | assigned => needs review |
2020-01-30 17:26 | WubTheCaptain | Relationship added | related to 0003740 |
2020-01-30 17:28 | WubTheCaptain | Note Added: 0021172 | |
2020-01-30 17:28 | WubTheCaptain | Note Edited: 0021172 | bug_revision_view_page.php?bugnote_id=21172#r13014 |
2020-01-30 17:31 | WubTheCaptain | Assigned To | WubTheCaptain => Pol M |
2020-01-30 17:31 | WubTheCaptain | Status | needs review => assigned |
2020-01-30 17:31 | WubTheCaptain | Status | assigned => needs review |
2020-01-30 17:42 | Zalewa | Note Added: 0021174 | |
2020-01-30 17:42 | WubTheCaptain | Note Added: 0021175 | |
2020-01-30 17:42 | WubTheCaptain | Status | needs review => resolved |
2020-01-30 17:42 | WubTheCaptain | Fixed in Version | => 1.3.3 |
2020-01-30 17:42 | WubTheCaptain | Resolution | open => fixed |
2020-01-30 17:49 | WubTheCaptain | Product Version | 1.3.1 => 1.3 |
2020-01-30 19:36 | Pol M | Note Added: 0021176 | |
2021-08-07 16:53 | Blzut3 | Status | resolved => closed |
2021-08-16 19:09 | WubTheCaptain | Fixed in Version | 1.3.3 => 1.3.2 |
2021-08-16 19:09 | WubTheCaptain | Target Version | 1.3.3 => 1.3.2 |