MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003720Doomseeker[All Projects] Suggestionpublic2019-09-30 05:462019-10-06 06:39
ReporterZalewa 
Assigned To 
PrioritynoneSeveritytweakReproducibilityN/A
StatusconfirmedResolutionopen 
PlatformOSOS Version
Product Version1.3 
Target VersionFixed in Version 
Summary0003720: /app/bin/zandronum is now also a possible place where Zandronum can be installed on Linux
DescriptionThanks to Eonfge Zandronum + Doomseeker can now be installed through Flatpak:
'https://zandronum.com/forum/viewtopic.php?f=4&t=9750 [^]'

While this is the first time I hear of flatpak and the /app topdir is not in FHS I wonder if we should cater for this package manager and seek for binaries in /app with a priority at least when the doomseeker binary is there.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-09-30 05:46ZalewaNew Issue
2019-09-30 18:01WubTheCaptainNote Added: 0021049
2019-09-30 18:01WubTheCaptainStatusnew => confirmed
2019-09-30 18:05WubTheCaptainNote Added: 0021050
2019-09-30 18:05WubTheCaptainNote Edited: 0021050bug_revision_view_page.php?bugnote_id=21050#r12860
2019-09-30 18:11WubTheCaptainNote Added: 0021051
2019-09-30 18:13WubTheCaptainNote Edited: 0021051bug_revision_view_page.php?bugnote_id=21051#r12862
2019-09-30 18:22WubTheCaptainNote Added: 0021052
2019-09-30 18:27WubTheCaptainNote Edited: 0021052bug_revision_view_page.php?bugnote_id=21052#r12864
2019-09-30 18:27WubTheCaptainNote Edited: 0021052bug_revision_view_page.php?bugnote_id=21052#r12865
2019-09-30 18:28WubTheCaptainNote Edited: 0021052bug_revision_view_page.php?bugnote_id=21052#r12866
2019-09-30 18:33WubTheCaptainNote Added: 0021054
2019-09-30 18:34WubTheCaptainNote Edited: 0021054bug_revision_view_page.php?bugnote_id=21054#r12870
2019-09-30 18:35WubTheCaptainNote Edited: 0021054bug_revision_view_page.php?bugnote_id=21054#r12871
2019-09-30 18:35WubTheCaptainNote Edited: 0021054bug_revision_view_page.php?bugnote_id=21054#r12872
2019-09-30 18:37WubTheCaptainNote Edited: 0021054bug_revision_view_page.php?bugnote_id=21054#r12873
2019-09-30 18:39WubTheCaptainNote Edited: 0021052bug_revision_view_page.php?bugnote_id=21052#r12874
2019-10-06 06:39Blzut3Note Added: 0021055

Notes
(0021049)
WubTheCaptain   
2019-09-30 18:01   
I'm confirming this issue, because I ran across the /app directory just few days earlier. I can definitely see /app/bin/zandronum path being a thing, and I know better we don't support it by default in Doomseeker.
I've known Flatpak as a name since earlier this year for a while longer, but I don't see myself wanting to use it; it's too weird. Arguably OpenBSD's hier(7) doesn't comply with FHS either.
Flatpak itself is competing with other things like Snap (Snappy) in Ubuntu, and AppImage. None of the latter have received greater popularity, at least among sysadmins but maybe among newer users (or users coming from Microsoft Windows) from what I believe.
(I'm not assigning this issue to myself, because there's no priority and I don't feel like implementing this tweak based on my slight opposition.)
Few example opinions from the Internet:
  1. What's so good about flatpak? (reddit)
  2. Flatpak – a security nightmare (flatkill.org; via Hacker News)
  3. Flatpak: after some time of active usage

Quote
Remember that article is not that "Flatpak is bad". This article is about "Flatpak is great, but there is some things that should be noted".

I've never used Flatpak, but I'd opt to wait to see if there's wider adoption of it as a package manager by operating systems and distributions. Apparently it's all quite unorthodoxy to UNIX principles, but the same could be said about Doomseeker in places.
(0021050)
WubTheCaptain   
2019-09-30 18:05   
Just fyi, for the same security concerns (bundled static dependencies) I'm also against the Docker image we do, but that's an option we support. (This issue is not about Docker, though.)
(0021051)
WubTheCaptain   
2019-09-30 18:11   
(edited on: 2019-09-30 18:13)
Rather than making implementation specific tweaks like these and hardcoding a list of paths, I would suggest to search $PATH environment variable instead. Then it's up to the system operator (or operating system distribution) to tell where the game binary might be located.
(0021052)
WubTheCaptain   
2019-09-30 18:22   
(edited on: 2019-09-30 18:39)
Just an off-topic FYI to the Zandronum Flatpak package maintainer too, which also installs Doomseeker (wat):
Quote from com.zandronum.Zandronum.yaml
Doomseeker honours XDG standards

Doomseeker doesn't. There's pseudo-support for XDG standards by hardcoding some paths, but the full spec isn't supported with all environment variable changes.
The builds are also not deterministic, due to using $(date +%s) and $(date --iso-8601=seconds) in the build files.
This package is bent backwards. For the next release, they'll have to fix the package for what breakage we did with Git transition at 0003701.
(0021054)
WubTheCaptain   
2019-09-30 18:33   
(edited on: 2019-09-30 18:37)
Quote from WubTheCaptain
The builds are also not deterministic, due to using $(date +%s) and $(date --iso-8601=seconds) in the build files.
This package is bent backwards.


What I meant to say, because of changes we've done and discussed on the tracker like 0003256, I think it'd be better to support Flatpak only if an active developer was actively working on maintaining a Flatpak package collaboratively. I'm not personally very interested or up for that task, quite honestly.
(0021055)
Blzut3   
2019-10-06 06:39   
The sad reality is that distros are so dead set on packaging every library individually even if they're not ABI stable, that users are turning to Flatpak, Appimage, Snaps, whatever. Even though I prefer traditional packages, I do see these third party utilities increasing in popularity since they solve the problem that people actually care about. That is normal users don't care if it's technically insecure, they just want their binaries to run. If distros weren't so dead set on removing old ABIs from their repos we probably wouldn't see so much effort in solving what I think is a problem that didn't need to exist.

With that said I think the invalid part of this request is that the proper way to package Zandronum/Doomseeker is with separate packages. In that case I don't think /app/bin/zandronum would be visible from Doomseeker. I don't use flatpak so I'm not sure, but I think the correct thing to do would be to support running flatpaks from within Doomseeker. Unless of course flatpak installs a script somewhere that we can look for.

So at least for this combined model the best I'd do is add INSTALL_PREFIX/bin to the default search location so that building with /app as the CMAKE_INSTALL_PREFIX would produce the desired behavior.