MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003707DoomseekerUIpublic2019-09-05 15:192024-11-03 19:10
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynoneSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSDebian GNU/LinuxOS Versionbullseye/sid
Product Version1.3 
Target Version1.4.0Fixed in Version1.4.0 
Summary0003707: The progress bar of the WAD(s) currently being downloaded in Wadseeker overflows past the narrow column width and overlaps
DescriptionI don't recall exactly when this started happening, but possible either Doomseeker 1.2 or 1.3 release or in between.

See the attachment for the issue. That is the default width for the table column, and resizing it (e.g. double clicking) won't be saved to configuration so every launch of Wadseeker has this issue.

That table column can also be resized way past the intended minimum width (of the progress bar), further exaggerating the issue.
Steps To Reproduce
  1. (Have online connectivity.)
  2. Launch Doomseeker.
  3. Launch Wadseeker from File → Wadseeker (Ctrl + Alt + W).
  4. From Wadseeker, search for a file such as "freedoom".
  5. If you desire so (or attempted to connect to a server instead with missing WADs), abort the download after it has started (or lose focus to the Wadseeker window to stop it from closing the window and connecting to the server).
  6. Notice the progress bar may overflow.
  7. Attempt to resize the "Progress" column on the bottom, so that the progress bar no longer overflows, then exit Wadseeker.
  8. Repeat steps 3 to 5.
  9. Notice the progress bar may still overflow.
Additional InformationI'm attaching a screenshot from Doomseeker 1.3 release, libwadseeker2 2.0 package. Qt 5.11.
TagsNo tags attached.
Relationships
Attached Filespng 2019-09-05-151319_maim.png (57,617) 2019-09-05 15:19
https://zandronum.com/tracker/file_download.php?file_id=2502&type=bug
png

png 2019-09-05-151957_maim.png (56,676) 2019-09-05 15:20
https://zandronum.com/tracker/file_download.php?file_id=2503&type=bug
png

jpg wadseeker_progressbars_kde_3707.jpg (107,348) 2022-11-11 11:05
https://zandronum.com/tracker/file_download.php?file_id=2785&type=bug
jpg
Issue History
Date ModifiedUsernameFieldChange
2019-09-05 15:19WubTheCaptainNew Issue
2019-09-05 15:19WubTheCaptainFile Added: 2019-09-05-151319_maim.png
2019-09-05 15:20WubTheCaptainFile Added: 2019-09-05-151957_maim.png
2019-09-05 15:21WubTheCaptainNote Added: 0021017
2019-09-05 15:25WubTheCaptainNote Added: 0021018
2019-09-05 15:28WubTheCaptainSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12819#r12819
2019-09-05 15:28WubTheCaptainSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12820#r12820
2019-09-05 15:31WubTheCaptainSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12821#r12821
2019-09-05 15:35WubTheCaptainSummaryThe progress bar of the WAD(s) currently being downloaded in Wadseeker overflows past the narrow column width => The progress bar of the WAD(s) currently being downloaded in Wadseeker overflows past the narrow column width and overlaps
2022-09-10 14:56ZalewaTarget Version => 1.4.0
2022-11-11 11:05ZalewaFile Added: wadseeker_progressbars_kde_3707.jpg
2022-11-11 11:06ZalewaNote Added: 0022487
2022-11-11 11:06ZalewaAssigned To => Zalewa
2022-11-11 11:06ZalewaStatusnew => assigned
2022-11-11 23:47ZalewaNote Added: 0022496
2022-11-11 23:47ZalewaStatusassigned => needs review
2022-11-11 23:47ZalewaNote Edited: 0022496bug_revision_view_page.php?bugnote_id=22496#r13767
2023-01-05 12:11ZalewaNote Added: 0022642
2023-01-05 12:11ZalewaStatusneeds review => needs testing
2023-01-16 23:47ZalewaNote Added: 0022703
2023-01-16 23:47ZalewaStatusneeds testing => resolved
2023-01-16 23:47ZalewaFixed in Version => 1.4.0
2023-01-16 23:47ZalewaResolutionopen => fixed
2024-11-03 19:10ZalewaStatusresolved => closed

Notes
(0021017)
WubTheCaptain   
2019-09-05 15:21   
Further exaggerated the issue by hand in the attachment 2019-09-05-151957_maim.png, for demonstration. (It can get worse, though.)
(0021018)
WubTheCaptain   
2019-09-05 15:25   
So, if I could rephrase, the progress bar itself has a constant minimum width of 95 pixels (on my monitor) and does not resize to smaller width than that. There seems to be no limit to its maximum width, however.
(0022487)
Zalewa   
2022-11-11 11:06   
Can still reproduce this with KDE 5.68.0 / Plasma 5.18.8. Doesn't happen in MATE or Windows 10. I'll try to do something about this.
(0022496)
Zalewa   
2022-11-11 23:47   
Should be solved by fixing the size of the column and the progress bars within it:
'https://bitbucket.org/Doomseeker/doomseeker/commits/ef77f7880d94b39af1d713ce50c208dfac4d7137 [^]'

I also tried to do this through delegates, as it seemed to be a more proper solution, and the progress bars do indeed render with proper layouting, but they don't animate.
1.'https://forum.qt.io/topic/56299/how-to-draw-and-correctly-animate-progress-bar-in-qtableview/23 [^]'
2.'https://doc.qt.io/qt-5/qtnetwork-torrent-example.html [^]'
(0022642)
Zalewa   
2023-01-05 12:11   
Beta package for Windows available at the beta auto-update channel and at:'https://devbuilds.drdteam.org/doomseeker/doomseeker-1.3.3~beta-230105-1140_windows.zip [^]'

Please test. I can say that Win 10 and Win XP themes don't show any problems, but maybe some Linux distro will?
(0022703)
Zalewa   
2023-01-16 23:47   
I have checked in Windows XP, Windows 10, Kubuntu 22.04, Ubuntu MATE 18.04, Ubuntu MATE 22.04 and Ubuntu 20.04. In all cases the progress bars were staying within the confinement of their cells.