MantisBT - Doomseeker
View Issue Details
0003656Doomseeker[All Projects] Bugpublic2019-06-05 14:332019-07-30 10:15
Pol M 
Pol M 
lowminorsometimes
closedno change required 
LinuxArchx86-64
1.2 
1.3 
0003656: Srb2 player column is broken. They seem overflowed by players with empty names.
Zalewa once pointed that the srb2 servers were registering incorrect amounts of players, and today I checked that, indeed, they were brocken. The issue can be easily understood with a photo.

The server looks full and there are more players than the limit suggests. While hovering the mouse reveals the name of the connected players, the rest seem empty.
Open doomseeker, and enable srb2.
Notice that the srb2 player column has impossible amounts of players.
Not all servers are affected. Maybe there is a new release?
No tags attached.
child of 0003662confirmed  SRB2Kart engine is handled poorly by our SRB2 engine 
png Screenshot_20190605_163131.png (13,425) 2019-06-05 14:33
https://zandronum.com/tracker/file_download.php?file_id=2486&type=bug
png

png Screenshot_20190605_163514.png (4,854) 2019-06-05 14:35
https://zandronum.com/tracker/file_download.php?file_id=2487&type=bug
png
Issue History
2019-06-05 14:33Pol MNew Issue
2019-06-05 14:33Pol MFile Added: Screenshot_20190605_163131.png
2019-06-05 14:34Pol MDescription Updatedbug_revision_view_page.php?rev_id=12618#r12618
2019-06-05 14:35Pol MFile Added: Screenshot_20190605_163514.png
2019-06-05 14:38Pol MAdditional Information Updatedbug_revision_view_page.php?rev_id=12620#r12620
2019-06-05 14:38Pol MAssigned To => Pol M
2019-06-05 14:38Pol MStatusnew => acknowledged
2019-06-05 14:38Pol MAssigned ToPol M =>
2019-06-05 14:57Pol MAssigned To => Pol M
2019-06-05 14:57Pol MStatusacknowledged => assigned
2019-06-06 16:26Pol MNote Added: 0020732
2019-06-09 19:06ZalewaNote Added: 0020734
2019-06-09 20:57Pol MNote Added: 0020737
2019-06-12 00:52WubTheCaptainReproducibilityalways => sometimes
2019-06-13 15:04ZalewaNote Added: 0020759
2019-06-13 17:52Pol MNote Added: 0020763
2019-06-16 14:07Pol MNote Edited: 0020763bug_revision_view_page.php?bugnote_id=20763#r12637
2019-06-18 09:33Pol MNote Edited: 0020763bug_revision_view_page.php?bugnote_id=20763#r12638
2019-06-18 09:33Pol MStatusassigned => resolved
2019-06-18 09:33Pol MFixed in Version => 1.3
2019-06-18 09:33Pol MResolutionopen => fixed
2019-06-18 23:47WubTheCaptainNote Added: 0020768
2019-06-18 23:47WubTheCaptainResolutionfixed => no change required
2019-06-18 23:47WubTheCaptainFixed in Version1.3 =>
2019-06-18 23:53WubTheCaptainRelationship addedchild of 0003662
2019-06-20 00:19WubTheCaptainProduct Version1.3 => 1.2
2019-07-30 10:15WubTheCaptainStatusresolved => closed

Notes
(0020732)
Pol M   
2019-06-06 16:26   
Okay, the issue is caused by a new fork of srb2: SRB2Kart.
Now, about what should be done, I'm not that sure. The empty players can be ruled out without problems due to these having absolutely all values set to 0, but I'd say that first we should notify the developers that they are not marking the players as non-existent (for reference, src/plugins/srb2/srb2server.cpp:275, the check is failing due to the node not being 0xff). Also, this is a fork, not the main engine, and leaving as is does not feel right: it requires its own program, and based on the fact that this ticket exists clearly the internet communications may change. Hoping to hear from you on whether we should rule them out, create a new plugin, or else.
(0020734)
Zalewa   
2019-06-09 19:06   
If they don't follow packet compatbility and yet report to the same master server they basically screwed themselves over.

Is there something in the packet that would allow us to recognize that it is from a different game and interpret the packet differently?
(0020737)
Pol M   
2019-06-09 20:57   
Quote from Zalewa

Is there something in the packet that would allow us to recognize that it is from a different game and interpret the packet differently?

Appart from the fact that the players are pretty much empty (score is 0, name is "", seconds in server is 0, etc...) nothing rellevant, the player structure is the same. Maybe they have done a change somewhere that is backwards-compatible? I think that the best idea is to ask. If you're okay with it, I'll contact them.
(0020759)
Zalewa   
2019-06-13 15:04   
Sure, go ahead and contact them :)
(0020763)
Pol M   
2019-06-13 17:52   
(edited on: 2019-06-18 09:33)
I posted on their bug report thread: post
Issue fixed by Sryder in this PR
I'll also ask if there is an easy way to distinguish both engines, and I'll create a ticket to discuss what should be done with this new engine.

(0020768)
WubTheCaptain   
2019-06-18 23:47   
Since we didn't do anything in Doomseeker code (in this reported issue) to resolve the issue with non-compat packets from pre-PR servers, I'm changing this to "no change required".