MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003646DoomseekerUIpublic2019-05-02 19:262019-07-30 10:13
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritylowSeveritytweakReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.2 
Target Version1.3Fixed in Version1.3 
Summary0003646: Create Game's "Save" button has a distinguishable icon, but "Load" button does not
DescriptionThis issue's summary is pretty self-explanatory, but see the screenshots.
Steps To Reproduce
  1. Start Doomseeker.
  2. File → Create Game (Ctrl + S).
  3. Notice the icons at bottom left (Doomseeker 1.2), or behind the "Settings" dropdown menu (Doomseeker 1.3~beta with Zalewa's Create Game UI tweaks). There's an icon for "Save", but not for "Load".
Additional Information
TagsNo tags attached.
Relationships
related to 0003636closed Zalewa Create Game box - adjust UI elements to Host, Offline and Remote modes 
Attached Filespng 2019-05-02-192511_maim.png (2,346) 2019-05-02 19:26
https://zandronum.com/tracker/file_download.php?file_id=2473&type=bug
png

png 2019-05-02-192724_maim.png (10,175) 2019-05-02 19:27
https://zandronum.com/tracker/file_download.php?file_id=2474&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2019-05-02 19:26WubTheCaptainNew Issue
2019-05-02 19:26WubTheCaptainFile Added: 2019-05-02-192511_maim.png
2019-05-02 19:27WubTheCaptainFile Added: 2019-05-02-192724_maim.png
2019-05-02 19:28WubTheCaptainSeverityfeature => tweak
2019-05-02 19:29WubTheCaptainSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12561#r12561
2019-05-02 19:29WubTheCaptainRelationship addedrelated to 0003636
2019-05-03 08:39WubTheCaptainAssigned To => Zalewa
2019-05-03 08:39WubTheCaptainStatusnew => acknowledged
2019-05-03 13:07WubTheCaptainNote Added: 0020616
2019-05-03 13:07WubTheCaptainStatusacknowledged => needs review
2019-05-03 13:36WubTheCaptainNote Added: 0020621
2019-05-03 13:36WubTheCaptainStatusneeds review => feedback
2019-05-03 13:36WubTheCaptainNote Edited: 0020621bug_revision_view_page.php?bugnote_id=20621#r12567
2019-05-03 13:37WubTheCaptainStatusfeedback => assigned
2019-05-03 13:44ZalewaNote Added: 0020623
2019-05-03 13:47WubTheCaptainStatusassigned => needs review
2019-05-03 13:48WubTheCaptainNote Added: 0020624
2019-05-03 20:59ZalewaNote Added: 0020631
2019-05-04 13:13WubTheCaptainStatusneeds review => resolved
2019-05-04 13:13WubTheCaptainFixed in Version => 1.3
2019-05-04 13:13WubTheCaptainResolutionopen => fixed
2019-07-30 10:13WubTheCaptainStatusresolved => closed

Notes
(0020616)
WubTheCaptain   
2019-05-03 13:07   
Will be merged later to main repository:'https://bitbucket.org/zalewa/doomseeker/commits/c70bb645c8ead4e1c27f26690a877d6d11f14121 [^]'
(0020621)
WubTheCaptain   
2019-05-03 13:36   
Since the last change (changeset 2398:4896b01d6529):

[ 19%] Built target doomseeker_autogen
[ 20%] Building CXX object src/core/CMakeFiles/doomseeker.dir/gui/createserverdialog.cpp.o
/tmp/doomseeker-zalewa/src/core/gui/createserverdialog.cpp: In member function ‘void CreateServerDialog::setupMenu()’:

/tmp/doomseeker-zalewa/src/core/gui/createserverdialog.cpp:472:35: error: invalid use of incomplete type 
‘class QStyle’
  loadConfigAction->setIcon(style()->standardIcon(QStyle::SP_DirIcon));
                                   ^~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qdialog.h:44,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QDialog:1,
                 from /tmp/doomseeker-zalewa/src/core/gui/createserverdialog.h:29,
                 from /tmp/doomseeker-zalewa/src/core/gui/createserverdialog.cpp:23:
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qwidget.h:67:7: note: forward declaration of ‘class QStyle’
 
class QStyle;
       ^~~~~~
/tmp/doomseeker-zalewa/src/core/gui/createserverdialog.cpp:472:58: error: incomplete type ‘QStyle’ 
used in nested name specifier
  loadConfigAction->setIcon(style()->standardIcon(QStyle::SP_DirIcon));
                                                          ^~~~~~~~~~
make[2]: *** [src/core/CMakeFiles/doomseeker.dir/build.make:1204: src/core/CMakeFiles/doomseeker.dir/gui/createserverdialog.cpp.o] 
Error 1
make[1]: *** [CMakeFiles/Makefile2:330: src/core/CMakeFiles/doomseeker.dir/all] Error 2
make: *** [Makefile:152: all] Error 2
(0020623)
Zalewa   
2019-05-03 13:44   
I added the missing #include to the PR.
(0020624)
WubTheCaptain   
2019-05-03 13:48   
Quote from Zalewa
I added the missing #include to the PR.

Commit 77ee7e7e314433e64776b3bad9e82e4396a06ae1
(0020631)
Zalewa   
2019-05-03 20:59   
Icons and kbd shortcuts merged as'https://bitbucket.org/Doomseeker/doomseeker/commits/0a26cf1fd3c2e465ca6eb56b485294c9a8c17aeb [^]'