MantisBT - Doomseeker
View Issue Details
0003581Doomseeker[All Projects] Bugpublic2018-12-17 04:152019-07-30 10:13
WubTheCaptain 
Pol M 
normaltweakalways
closedfixed 
1.2 
1.31.3 
0003581: Version::operatingSystem() knows only about three operating systems (Windows, Linux & Mac)
Version::operatingSystem() only has definitions for Windows, Linux and Mac. Every other operating system is reported as an "Unknown OS for Version::operatingSystem()".

Qt 5 would provide additional global definitions for at least the following additional operating systems, which could be implemented:

  1. AIX
  2. Android
  3. Any BSD 4.4 system
  4. Cygwin
  5. Darwin (macOS, iOS, watchOS, tvOS)
  6. FreeBSD
  7. HP-UX
  8. GNU Hurd
  9. iOS (see also Darwin)
  10. LynxOS
  11. macOS (see also Darwin)
  12. NetBSD
  13. OpenBSD
  14. PNX Neutrino
  15. Sun Solaris
  16. tvOS (see also Darwin)
  17. Any UNIX BSD/SYSV system
  18. watchOS (see also Darwin)
  19. Windows (64-bit or RT variants)
src/core/version.cpp
https://doc.qt.io/qt-5/qtglobal.html [^]
No tags attached.
related to 0003514closed Zalewa Drop support for compiling with Qt4 (in favor of Qt5+) 
child of 0003499assigned Pol M Port Doomseeker to OpenBSD 
Issue History
2018-12-17 04:15WubTheCaptainNew Issue
2018-12-17 04:16WubTheCaptainRelationship addedchild of 0003499
2018-12-17 04:16WubTheCaptainNote Added: 0020258
2018-12-17 04:16WubTheCaptainAssigned To => WubTheCaptain
2018-12-17 04:16WubTheCaptainStatusnew => feedback
2018-12-17 04:18WubTheCaptainDescription Updatedbug_revision_view_page.php?rev_id=12305#r12305
2018-12-17 04:18WubTheCaptainSeverityminor => tweak
2018-12-17 04:32WubTheCaptainDescription Updatedbug_revision_view_page.php?rev_id=12306#r12306
2018-12-17 04:34WubTheCaptainNote Added: 0020261
2018-12-17 04:34WubTheCaptainStatusfeedback => assigned
2018-12-17 04:35WubTheCaptainNote Edited: 0020261bug_revision_view_page.php?bugnote_id=20261#r12308
2018-12-17 04:35WubTheCaptainNote Edited: 0020261bug_revision_view_page.php?bugnote_id=20261#r12309
2018-12-17 04:35WubTheCaptainStatusassigned => feedback
2018-12-17 04:36WubTheCaptainStatusfeedback => new
2018-12-17 04:39WubTheCaptainRelationship addedrelated to 0003514
2019-05-20 15:38Pol MAssigned ToWubTheCaptain => Pol M
2019-05-20 15:38Pol MStatusnew => assigned
2019-05-26 14:36Pol MNote Added: 0020694
2019-05-26 14:42Pol MNote Edited: 0020694bug_revision_view_page.php?bugnote_id=20694#r12597
2019-05-28 16:27Pol MNote Added: 0020701
2019-05-28 16:27Pol MStatusassigned => needs testing
2019-05-30 06:12WubTheCaptainTarget Version => 1.3
2019-06-30 10:43ZalewaNote Added: 0020852
2019-06-30 10:43ZalewaStatusneeds testing => resolved
2019-06-30 10:43ZalewaFixed in Version => 1.3
2019-06-30 10:43ZalewaResolutionopen => fixed
2019-06-30 11:31WubTheCaptainNote Added: 0020855
2019-06-30 11:31WubTheCaptainStatusresolved => needs review
2019-06-30 11:31WubTheCaptainResolutionfixed => reopened
2019-06-30 11:32WubTheCaptainNote Edited: 0020855bug_revision_view_page.php?bugnote_id=20855#r12708
2019-06-30 11:38ZalewaNote Added: 0020856
2019-06-30 11:38ZalewaStatusneeds review => resolved
2019-06-30 11:38ZalewaResolutionreopened => fixed
2019-07-30 10:13WubTheCaptainStatusresolved => closed

Notes
(0020258)
WubTheCaptain   
2018-12-17 04:16   
Which ones are useful to us?
(0020261)
WubTheCaptain   
2018-12-17 04:34   
(edited on: 2018-12-17 04:35)
If we can drop support for Qt 4, we could also use QSysInfo functions such as QSysInfo::prettyProductName() instead of these definitions. Those were added in Qt 5.4.

https://doc.qt.io/qt-5/qsysinfo.html [^]

(0020694)
Pol M   
2019-05-26 14:36   
(edited on: 2019-05-26 14:42)
It would be OK to use QSysInfo::prettyProductName() as a fallback option for version.
The usage of operatingSystem is quite small, but I'd still leave the current implementation to not change its output on future versions. Using QSysInfo would give a more descriptive output on openBSD and other small OS.

(0020701)
Pol M   
2019-05-28 16:27   
Commit
There's not much to test, it simply works on OpenBSD and so. If you want to take the time to look at it, you'll find it on IRC by selecting the "CTCP Version" option on the right-click menu (select your own nick)

:)
(0020852)
Zalewa   
2019-06-30 10:43   
As you said Pol, there's not much to test. Resolving as done.
(0020855)
WubTheCaptain   
2019-06-30 11:31   
(edited on: 2019-06-30 11:32)
Doesn't this need #include <QSysInfo>?

(0020856)
Zalewa   
2019-06-30 11:38   
Apparently not, but I added it regardless.
https://bitbucket.org/Doomseeker/doomseeker/commits/d7dfe48e5b26de8509708f4ec535eeee9c7251d7 [^]