MantisBT - Doomseeker |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0003581 | Doomseeker | [All Projects] Bug | public | 2018-12-17 04:15 | 2019-07-30 10:13 |
|
Reporter | WubTheCaptain | |
Assigned To | Pol M | |
Priority | normal | Severity | tweak | Reproducibility | always |
Status | closed | Resolution | fixed | |
Platform | | OS | | OS Version | |
Product Version | 1.2 | |
Target Version | 1.3 | Fixed in Version | 1.3 | |
|
Summary | 0003581: Version::operatingSystem() knows only about three operating systems (Windows, Linux & Mac) |
Description | Version::operatingSystem() only has definitions for Windows, Linux and Mac. Every other operating system is reported as an "Unknown OS for Version::operatingSystem()".
Qt 5 would provide additional global definitions for at least the following additional operating systems, which could be implemented:
- AIX
- Android
- Any BSD 4.4 system
- Cygwin
- Darwin (macOS, iOS, watchOS, tvOS)
- FreeBSD
- HP-UX
- GNU Hurd
- iOS (see also Darwin)
- LynxOS
- macOS (see also Darwin)
- NetBSD
- OpenBSD
- PNX Neutrino
- Sun Solaris
- tvOS (see also Darwin)
- Any UNIX BSD/SYSV system
- watchOS (see also Darwin)
- Windows (64-bit or RT variants)
|
Steps To Reproduce | src/core/version.cpp |
Additional Information | 'https://doc.qt.io/qt-5/qtglobal.html [^]' |
Tags | No tags attached. |
Relationships | related to | 0003514 | closed | Zalewa | Drop support for compiling with Qt4 (in favor of Qt5+) | child of | 0003499 | assigned | Pol M | Port Doomseeker to OpenBSD |
|
Attached Files | |
|
Issue History |
Date Modified | Username | Field | Change |
2018-12-17 04:15 | WubTheCaptain | New Issue | |
2018-12-17 04:16 | WubTheCaptain | Relationship added | child of 0003499 |
2018-12-17 04:16 | WubTheCaptain | Note Added: 0020258 | |
2018-12-17 04:16 | WubTheCaptain | Assigned To | => WubTheCaptain |
2018-12-17 04:16 | WubTheCaptain | Status | new => feedback |
2018-12-17 04:18 | WubTheCaptain | Description Updated | bug_revision_view_page.php?rev_id=12305#r12305 |
2018-12-17 04:18 | WubTheCaptain | Severity | minor => tweak |
2018-12-17 04:32 | WubTheCaptain | Description Updated | bug_revision_view_page.php?rev_id=12306#r12306 |
2018-12-17 04:34 | WubTheCaptain | Note Added: 0020261 | |
2018-12-17 04:34 | WubTheCaptain | Status | feedback => assigned |
2018-12-17 04:35 | WubTheCaptain | Note Edited: 0020261 | bug_revision_view_page.php?bugnote_id=20261#r12308 |
2018-12-17 04:35 | WubTheCaptain | Note Edited: 0020261 | bug_revision_view_page.php?bugnote_id=20261#r12309 |
2018-12-17 04:35 | WubTheCaptain | Status | assigned => feedback |
2018-12-17 04:36 | WubTheCaptain | Status | feedback => new |
2018-12-17 04:39 | WubTheCaptain | Relationship added | related to 0003514 |
2019-05-20 15:38 | Pol M | Assigned To | WubTheCaptain => Pol M |
2019-05-20 15:38 | Pol M | Status | new => assigned |
2019-05-26 14:36 | Pol M | Note Added: 0020694 | |
2019-05-26 14:42 | Pol M | Note Edited: 0020694 | bug_revision_view_page.php?bugnote_id=20694#r12597 |
2019-05-28 16:27 | Pol M | Note Added: 0020701 | |
2019-05-28 16:27 | Pol M | Status | assigned => needs testing |
2019-05-30 06:12 | WubTheCaptain | Target Version | => 1.3 |
2019-06-30 10:43 | Zalewa | Note Added: 0020852 | |
2019-06-30 10:43 | Zalewa | Status | needs testing => resolved |
2019-06-30 10:43 | Zalewa | Fixed in Version | => 1.3 |
2019-06-30 10:43 | Zalewa | Resolution | open => fixed |
2019-06-30 11:31 | WubTheCaptain | Note Added: 0020855 | |
2019-06-30 11:31 | WubTheCaptain | Status | resolved => needs review |
2019-06-30 11:31 | WubTheCaptain | Resolution | fixed => reopened |
2019-06-30 11:32 | WubTheCaptain | Note Edited: 0020855 | bug_revision_view_page.php?bugnote_id=20855#r12708 |
2019-06-30 11:38 | Zalewa | Note Added: 0020856 | |
2019-06-30 11:38 | Zalewa | Status | needs review => resolved |
2019-06-30 11:38 | Zalewa | Resolution | reopened => fixed |
2019-07-30 10:13 | WubTheCaptain | Status | resolved => closed |
Notes |
|
|
Which ones are useful to us? |
|
|
(0020261)
|
WubTheCaptain
|
2018-12-17 04:34
(edited on: 2018-12-17 04:35) |
|
If we can drop support for Qt 4, we could also use QSysInfo functions such as QSysInfo::prettyProductName() instead of these definitions. Those were added in Qt 5.4.
'https://doc.qt.io/qt-5/qsysinfo.html [^]'
|
|
|
(0020694)
|
Pol M
|
2019-05-26 14:36
(edited on: 2019-05-26 14:42) |
|
It would be OK to use QSysInfo::prettyProductName() as a fallback option for version.
The usage of operatingSystem is quite small, but I'd still leave the current implementation to not change its output on future versions. Using QSysInfo would give a more descriptive output on openBSD and other small OS.
|
|
|
(0020701)
|
Pol M
|
2019-05-28 16:27
|
|
Commit
There's not much to test, it simply works on OpenBSD and so. If you want to take the time to look at it, you'll find it on IRC by selecting the "CTCP Version" option on the right-click menu (select your own nick)
:) |
|
|
(0020852)
|
Zalewa
|
2019-06-30 10:43
|
|
As you said Pol, there's not much to test. Resolving as done. |
|
|
(0020855)
|
WubTheCaptain
|
2019-06-30 11:31
(edited on: 2019-06-30 11:32) |
|
Doesn't this need #include <QSysInfo>?
|
|
|
(0020856)
|
Zalewa
|
2019-06-30 11:38
|
|
|