MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003580Doomseeker[All Projects] Cleanuppublic2018-12-17 04:072019-07-30 10:13
ReporterWubTheCaptain 
Assigned ToWubTheCaptain 
PrioritynormalSeveritytweakReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.2 
Target Version1.3Fixed in Version1.3 
Summary0003580: Deprecated use of global Qt declaration Q_OS_MAC
DescriptionAll declarations of Q_OS_MAC and Q_OS_OSX are deprecated in Qt 5 (at least since Qt 5.6). There's few of them in Doomseeker and Zandronum plugin.

We should probably use Q_OS_DARWIN instead.
Steps To ReproduceIn 1.2 source root directory:

$ grep -r "Q_OS_MAC" .
./src/plugins/zandronum/zandronumbinaries.cpp:#ifndef Q_OS_MAC
./src/plugins/zandronum/zandronumbinaries.cpp:#ifdef Q_OS_MAC
./src/plugins/zandronum/zandronumbinaries.cpp:  #ifdef Q_OS_MAC
./src/plugins/zandronum/zandronumengineplugin.cpp:#if defined(Q_OS_WIN32) || defined(Q_OS_MAC)
./src/core/gui/widgets/serversstatuswidget.cpp:#ifndef Q_OS_MAC
./src/core/apprunner.h:#ifdef Q_OS_MAC
./src/core/version.cpp: #elif defined(Q_OS_MAC)
./src/core/apprunner.cpp:#ifdef Q_OS_MAC
./src/core/apprunner.cpp:       #ifdef Q_OS_MAC
./src/core/commandline.cpp:#ifdef Q_OS_MAC
./src/core/datapaths.cpp:#ifdef Q_OS_MAC
./src/core/datapaths.cpp:#if !defined(Q_OS_MAC)
./src/core/datapaths.cpp:#ifdef Q_OS_MAC
./src/core/datapaths.cpp:#if !defined(Q_OS_MAC) && !defined(Q_OS_WIN32)
./src/core/main.cpp:#ifdef Q_OS_MAC
./src/core/updater/updatechannel.cpp:#elif defined(Q_OS_MAC)
./src/core/updater/updateinstaller.cpp:#ifdef Q_OS_MAC
./src/core/updater/updatepackagefilter.cpp:#if !defined(Q_OS_MAC) || defined(__x86_64__)
$ grep -r "Q_OS_OSX" src/ | wc -l
0
Additional Information'https://doc.qt.io/qt-5/qtglobal.html#Q_OS_MAC [^]'
TagsNo tags attached.
Relationships
Attached Filespatch 0001-Replace-deprecated-Q_OS_MAC-definitions-from-Qt.patch (8,172) 2018-12-17 04:28
https://zandronum.com/tracker/file_download.php?file_id=2447&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-12-17 04:07WubTheCaptainNew Issue
2018-12-17 04:07WubTheCaptainAssigned To => WubTheCaptain
2018-12-17 04:07WubTheCaptainStatusnew => assigned
2018-12-17 04:28WubTheCaptainFile Added: 0001-Replace-deprecated-Q_OS_MAC-definitions-from-Qt.patch
2018-12-17 04:28WubTheCaptainNote Added: 0020259
2018-12-17 04:28WubTheCaptainStatusassigned => needs review
2018-12-17 04:28WubTheCaptainTarget Version => 1.3
2018-12-17 04:29WubTheCaptainNote Added: 0020260
2018-12-17 04:36WubTheCaptainDescription Updatedbug_revision_view_page.php?rev_id=12311#r12311
2018-12-17 04:57WubTheCaptainSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12313#r12313
2018-12-17 04:58WubTheCaptainSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12314#r12314
2019-06-22 11:15ZalewaNote Added: 0020805
2019-06-22 11:25WubTheCaptainStatusneeds review => resolved
2019-06-22 11:25WubTheCaptainFixed in Version => 1.3
2019-06-22 11:25WubTheCaptainResolutionopen => fixed
2019-07-30 10:13WubTheCaptainStatusresolved => closed

Notes
(0020259)
WubTheCaptain   
2018-12-17 04:28   
Patch by me, attached.

I've not tested with Darwin-based operating systems, especially against Qt 4.
(0020260)
WubTheCaptain   
2018-12-17 04:29   
find src/ -type f -print0 | xargs -0 sed -i 's/Q_OS_MAC/Q_OS_DARWIN/g'
(0020805)
Zalewa   
2019-06-22 11:15   
Pushed here:'https://bitbucket.org/Doomseeker/doomseeker/commits/92fbba08cbf4257d1bc8195fdba0321ee8aeca0f [^]'