MantisBT - Doomseeker
View Issue Details
0003547Doomseeker[All Projects] Bugpublic2018-10-08 11:332018-10-27 22:53
WubTheCaptain 
Pol M 
normaltrivialalways
closedfixed 
1.1 
1.21.2 
0003547: updateinstaller: URL with HTTP scheme in src/AppInfo.cpp
doomseeker.drdteam.org supports HTTPS these days.

Commit 6e4d1b8a6b7339a353619b3f740e972f57187068u (0003267) changed most URLs to HTTPS, but didn't with this one.
tools/updateinstaller/src/AppInfo.cpp

The error message with HTTP scheme will be also displayed if the update fails to install for whatever the reason.
No tags attached.
Issue History
2018-10-08 11:33WubTheCaptainNew Issue
2018-10-08 11:45WubTheCaptainNote Added: 0020016
2018-10-08 11:50WubTheCaptainNote Edited: 0020016bug_revision_view_page.php?bugnote_id=20016#r12191
2018-10-08 19:41Pol MNote Added: 0020017
2018-10-08 19:41Pol MAssigned To => Pol M
2018-10-08 19:41Pol MStatusnew => assigned
2018-10-08 19:58Pol MNote Edited: 0020017bug_revision_view_page.php?bugnote_id=20017#r12195
2018-10-08 20:02WubTheCaptainStatusassigned => needs review
2018-10-08 20:02WubTheCaptainTarget Version => 1.2
2018-10-08 20:27Pol MNote Added: 0020019
2018-10-08 20:27Pol MStatusneeds review => needs testing
2018-10-08 20:33ZalewaNote Added: 0020021
2018-10-08 20:33ZalewaStatusneeds testing => resolved
2018-10-08 20:33ZalewaFixed in Version => 1.2
2018-10-08 20:33ZalewaResolutionopen => fixed
2018-10-27 22:53WubTheCaptainStatusresolved => closed

Notes
(0020016)
WubTheCaptain   
2018-10-08 11:45   
(edited on: 2018-10-08 11:50)
Out of spite or my hatred toward Mendeley Updater, this will not get a patch from me personally. ๐Ÿ™…โ€โ™€๏ธ

(0020017)
Pol M   
2018-10-08 19:41   
(edited on: 2018-10-08 19:58)
Simply replace http for https? ๐Ÿคจ
if that's it, this should do:'https://bitbucket.org/Doomseeker/doomseeker/pull-requests/35/updateinstaller-replace-http-with-https-in/diff [^]'

(0020019)
Pol M   
2018-10-08 20:27   
Commit
I'm leaving as "needs tesing" since I can't test it myself. It's just a 1 character change, so it really could be simply set as resolved ๐Ÿ˜Š
(0020021)
Zalewa   
2018-10-08 20:33   
PR merged.