MantisBT - Doomseeker
View Issue Details
0003513Doomseeker[All Projects] Bugpublic2018-09-22 23:322018-10-27 22:53
WubTheCaptain 
Zalewa 
highblockalways
closedfixed 
1.1 
1.21.2 
0003513: Missing a required URI or copy of CPOL license in third-party dependencies of updateinstaller tool (?)
Upstream dependencies in updateinstaller tool have done a terrible bad job at following the license terms of CPOL (a non-free software license).

My recommendation: Add a copy of it to tools/updaterevision/ or root of the Doomseeker distribution.
In Doomseeker's source root directory:

$ grep -ir "This License governs Your use of the Work." . | wc -l
0
$ grep -ir "codeproject.com" .
./tools/updateinstaller/external/verpatch/src/verpatch-ReadMe.txt:http://www.codeproject.com/info/licenses.aspx

./tools/updateinstaller/external/verpatch/src/ReadMe.txt:http://www.codeproject.com/info/licenses.aspx

./tools/updateinstaller/external/verpatch/verpatch-ReadMe.txt:http://www.codeproject.com/info/licenses.aspx

./tools/updateinstaller/external/win32cpp/3rd Party Software/ADO Class/About.TXT:http://www.codeproject.com/KB/database/caaadoxclass.aspx

./tools/updateinstaller/external/win32cpp/3rd Party Software/GridControl/About.TXT:http://www.codeproject.com/KB/miscctrl/DataGridControl.aspx


Notice none of those actually link to the license text directly.
0003237

Article 5(e):https://www.codeproject.com/info/cpol10.aspx [^]

Code Project Open License on Wikipedia

An additional issue comes with article 9 license termination; Any distribution by the Doomseeker core developers (whom have been involved with distributing the source code) may be an infringing rights of those who licensed their software under CPOL, without negotiating with the appropriate copyright holders to reinstate rights to the license.
No tags attached.
child of 0003237closed WubTheCaptain Non-free files and copyright issues in source archive 
Issue History
2018-09-22 23:32WubTheCaptainNew Issue
2018-09-22 23:32WubTheCaptainRelationship addedchild of 0003237
2018-09-24 01:18Blzut3Target Version => 1.2
2018-09-27 02:32WubTheCaptainAssigned To => WubTheCaptain
2018-09-27 02:32WubTheCaptainStatusnew => acknowledged
2018-09-27 02:32WubTheCaptainAssigned ToWubTheCaptain =>
2018-10-08 11:20WubTheCaptainAssigned To => WubTheCaptain
2018-10-08 11:20WubTheCaptainStatusacknowledged => assigned
2018-10-08 11:24WubTheCaptainAssigned ToWubTheCaptain =>
2018-10-08 11:26WubTheCaptainNote Added: 0020015
2018-10-08 11:26WubTheCaptainStatusassigned => acknowledged
2018-10-08 12:01WubTheCaptainNote Edited: 0020015bug_revision_view_page.php?bugnote_id=20015#r12193
2018-10-12 18:16ZalewaAssigned To => Zalewa
2018-10-12 18:16ZalewaStatusacknowledged => assigned
2018-10-13 14:04ZalewaNote Added: 0020093
2018-10-13 14:04ZalewaStatusassigned => needs review
2018-10-13 16:16WubTheCaptainStatusneeds review => needs testing
2018-10-13 17:41WubTheCaptainNote Added: 0020104
2018-10-13 17:41WubTheCaptainStatusneeds testing => resolved
2018-10-13 17:41WubTheCaptainFixed in Version => 1.2
2018-10-13 17:41WubTheCaptainResolutionopen => fixed
2018-10-27 22:53WubTheCaptainStatusresolved => closed

Notes
(0020015)
WubTheCaptain   
2018-10-08 11:26   
(edited on: 2018-10-08 12:01)
I won't be filing upstream bugs about this, and I don't have a GitHub account.

As much as I reject this being in the source distribution anyway, I thought it would've been as simple as adding the CPOL license (which they only provide in HTML format, yuck) or URL to the source distribution. But then I forgot, "I need to do this for executables too" and I have no way of testing that.

(0020093)
Zalewa   
2018-10-13 14:04   
Problem gone?
https://bitbucket.org/Doomseeker/doomseeker/commits/a8d2c65dfd6ea5f48c1bf93e74bda57c964e78f8 [^]
(0020104)
WubTheCaptain   
2018-10-13 17:41   
verpatch tool and "win32cpp/3rd Party Software" removed by Zalewa's commit. No more CPOL licensed files should exist.

I also did a string search with grep, and found no references to these removed files to be useful.