MantisBT - Doomseeker
View Issue Details
0003463DoomseekerUIpublic2018-08-24 03:082019-07-30 10:13
WubTheCaptain 
Pol M 
lowtrivialalways
closedfixed 
1.1 
1.31.3 
0003463: Engine icons have too much right margin in server view list
Engine icons are rendered something like 15x15 or 21x21 for me, but the total size of the engine column is 26x21 with the empty 5 px wide bounding box on the right side of it. See attachment.
Load Doomseeker with any engine plugin. Receive any server from an active master server for that engine.
This may need another bug about the way those icons are handled (a probable hack, like 0003461).
No tags attached.
png 3463.png (6,722) 2018-08-24 03:08
https://zandronum.com/tracker/file_download.php?file_id=2359&type=bug
png

png 2018-08-24-032832_402x133_scrot.png (8,690) 2018-08-24 03:28
https://zandronum.com/tracker/file_download.php?file_id=2360&type=bug
png

? doomseeker.ini (6,378) 2018-08-24 03:33
https://zandronum.com/tracker/file_download.php?file_id=2361&type=bug
Issue History
2018-08-24 03:08WubTheCaptainNew Issue
2018-08-24 03:08WubTheCaptainFile Added: 3463.png
2018-08-24 03:27WubTheCaptainNote Added: 0019395
2018-08-24 03:28WubTheCaptainFile Added: 2018-08-24-032832_402x133_scrot.png
2018-08-24 03:30WubTheCaptainRelationship addedrelated to 0003411
2018-08-24 03:33WubTheCaptainFile Added: doomseeker.ini
2018-08-24 03:34WubTheCaptainNote Edited: 0019395bug_revision_view_page.php?bugnote_id=19395#r11676
2018-08-24 03:35WubTheCaptainNote Edited: 0019395bug_revision_view_page.php?bugnote_id=19395#r11677
2018-09-27 03:23WubTheCaptainRelationship deletedrelated to 0003411
2018-10-05 06:36WubTheCaptainPrioritynormal => low
2018-12-04 00:38WubTheCaptainCategoryBug => UI
2019-04-19 18:31WubTheCaptainNote Added: 0020510
2019-04-19 18:52FilysteaNote Added: 0020513
2019-04-20 12:25Pol MNote Added: 0020519
2019-04-20 12:25Pol MAssigned To => Pol M
2019-04-20 12:25Pol MStatusnew => confirmed
2019-04-20 12:25Pol MAssigned ToPol M =>
2019-06-05 14:14Pol MAssigned To => Pol M
2019-06-05 14:14Pol MStatusconfirmed => assigned
2019-06-05 14:56Pol MNote Added: 0020724
2019-06-05 14:57Pol MStatusassigned => needs review
2019-06-20 10:51ZalewaNote Added: 0020782
2019-06-20 11:36ZalewaStatusneeds review => needs testing
2019-06-20 21:36Pol MNote Added: 0020786
2019-06-21 14:47ZalewaNote Added: 0020788
2019-06-21 20:56WubTheCaptainTarget Version => 1.3
2019-06-23 09:41ZalewaStatusneeds testing => assigned
2019-06-25 21:41ZalewaNote Added: 0020839
2019-06-25 21:41ZalewaStatusassigned => needs testing
2019-07-20 06:30ZalewaNote Added: 0020897
2019-07-22 08:55WubTheCaptainAssigned ToPol M => WubTheCaptain
2019-07-22 09:09WubTheCaptainNote Added: 0020903
2019-07-22 09:09WubTheCaptainAssigned ToWubTheCaptain => Pol M
2019-07-22 09:09WubTheCaptainStatusneeds testing => needs review
2019-07-22 11:45Pol MNote Added: 0020907
2019-07-22 11:46Pol MNote Edited: 0020907bug_revision_view_page.php?bugnote_id=20907#r12734
2019-07-22 19:01Pol MNote Added: 0020910
2019-07-22 19:02Pol MStatusneeds review => resolved
2019-07-22 19:02Pol MFixed in Version => 1.3
2019-07-22 19:02Pol MResolutionopen => fixed
2019-07-30 10:13WubTheCaptainStatusresolved => closed

Notes
(0019395)
WubTheCaptain   
2018-08-24 03:27   
(edited on: 2018-08-24 03:35)
This can be even worse with a broken state (0003411), and the engine column is not resizable by default. Attaching another screenshot.

Attached doomseeker.ini config (with corrupted state) should replicate the issue (second screenshot) at least on 1.2. NB: I've not created the bug conditions consciously, it happened a long time ago.

(0020510)
WubTheCaptain   
2019-04-19 18:31   
This issue has not seen activity in a while; can anyone confirm or acknowledge this issue?
(0020513)
Filystea   
2019-04-19 18:52   
\I fail to understand problem here.

Picture with some paint/gimp red ring where the problem is.
(0020519)
Pol M   
2019-04-20 12:25   
The extra size on the right side of the icons seems to be slightly theme dependant, but it's present.
(0020724)
Pol M   
2019-06-05 14:56   
PR
(0020782)
Zalewa   
2019-06-20 10:51   
I merged the PR. The PR fixes the issues with fixed column sizes becoming invalid, but it doesn't fix the problem with extra space.

We actually set a 24x24 icon onto the cell, but it appears that the table widget itself is then free to shrink it to fit the row with correct aspect ratio. On Windows the icon is reduced to about 20x20 and I also have those several pixels of extra space. I'm not sure if it's possible for the icon to become upscaled by the widget to more than 24x24. If yes then our current "fixed width" mode for the icon column will result in the icon being cropped.
(0020786)
Pol M   
2019-06-20 21:36   
Ok, I'll look into it, maybe a QHeaderView::ResizeToContents (in serverlistview.cpp:190) will do the trick. I'll also take a look at those 20x20 icons on windows.
(0020788)
Zalewa   
2019-06-21 14:47   
Just to be explicit here: minimal icon shrinking that is happening here is actually desirable as other factors that decide on the row height (such as text size, or OS style preferences) are more important. The icon should adjust to the row height, not the other way around.
(0020839)
Zalewa   
2019-06-25 21:41   
The PR that changes the column to fit to contents is merged here.

Even with this PR, the focus rectangle was still showing (albeit it was like 3 pixels in size). I have removed it with yet another CustomItemDelegate hack. It's also removed from the players column which fixes 0003461.
(0020897)
Zalewa   
2019-07-20 06:30   
WubTheCaptain can you have the final say on the current state of this? I was not affected by this issue (or rather, I didn't notice anything that would bother me).
(0020903)
WubTheCaptain   
2019-07-22 09:09   
The focus rectangle is gone, so that part doesn't bother me anymore. The underlying problem in OP might still be an issue; consider a sub-issue of this resolved for the time being (create a new issue for this, if you'd like).

Pol M (having taken responsibility) should decide if this issue is resolved.
(0020907)
Pol M   
2019-07-22 11:45   
(edited on: 2019-07-22 11:46)
I've decided to re-add the code that setted the minimumSectionSize of the table because while testing I found that with some themes it liked to get big sizes.
PR

The underlying problem with this is gone. If this gets approved, I'll set this to resolved.

(0020910)
Pol M   
2019-07-22 19:01   
Approved by Zalewa, setting as resolved