|
Notes |
|
|
(0019395)
|
|
WubTheCaptain
|
2018-08-24 03:27
(edited on: 2018-08-24 03:35) |
|
This can be even worse with a broken state (0003411), and the engine column is not resizable by default. Attaching another screenshot.
Attached doomseeker.ini config (with corrupted state) should replicate the issue (second screenshot) at least on 1.2. NB: I've not created the bug conditions consciously, it happened a long time ago.
|
|
|
|
|
|
This issue has not seen activity in a while; can anyone confirm or acknowledge this issue? |
|
|
|
|
\I fail to understand problem here.
Picture with some paint/gimp red ring where the problem is. |
|
|
|
(0020519)
|
|
Pol M
|
|
2019-04-20 12:25
|
|
|
The extra size on the right side of the icons seems to be slightly theme dependant, but it's present. |
|
|
|
(0020724)
|
|
Pol M
|
|
2019-06-05 14:56
|
|
|
|
|
(0020782)
|
|
Zalewa
|
|
2019-06-20 10:51
|
|
I merged the PR. The PR fixes the issues with fixed column sizes becoming invalid, but it doesn't fix the problem with extra space.
We actually set a 24x24 icon onto the cell, but it appears that the table widget itself is then free to shrink it to fit the row with correct aspect ratio. On Windows the icon is reduced to about 20x20 and I also have those several pixels of extra space. I'm not sure if it's possible for the icon to become upscaled by the widget to more than 24x24. If yes then our current "fixed width" mode for the icon column will result in the icon being cropped. |
|
|
|
(0020786)
|
|
Pol M
|
|
2019-06-20 21:36
|
|
|
Ok, I'll look into it, maybe a QHeaderView::ResizeToContents (in serverlistview.cpp:190) will do the trick. I'll also take a look at those 20x20 icons on windows. |
|
|
|
(0020788)
|
|
Zalewa
|
|
2019-06-21 14:47
|
|
|
Just to be explicit here: minimal icon shrinking that is happening here is actually desirable as other factors that decide on the row height (such as text size, or OS style preferences) are more important. The icon should adjust to the row height, not the other way around. |
|
|
|
(0020839)
|
|
Zalewa
|
|
2019-06-25 21:41
|
|
|
|
|
(0020897)
|
|
Zalewa
|
|
2019-07-20 06:30
|
|
|
WubTheCaptain can you have the final say on the current state of this? I was not affected by this issue (or rather, I didn't notice anything that would bother me). |
|
|
|
|
The focus rectangle is gone, so that part doesn't bother me anymore. The underlying problem in OP might still be an issue; consider a sub-issue of this resolved for the time being (create a new issue for this, if you'd like).
Pol M (having taken responsibility) should decide if this issue is resolved. |
|
|
|
(0020907)
|
|
Pol M
|
2019-07-22 11:45
(edited on: 2019-07-22 11:46) |
|
I've decided to re-add the code that setted the minimumSectionSize of the table because while testing I found that with some themes it liked to get big sizes.
PR
The underlying problem with this is gone. If this gets approved, I'll set this to resolved.
|
|
|
|
(0020910)
|
|
Pol M
|
|
2019-07-22 19:01
|
|
|
Approved by Zalewa, setting as resolved |
|
3463.png (6,722) 2018-08-24 03:08
doomseeker.ini (6,378) 2018-08-24 03:33