MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003438Zandronum[All Projects] Bugpublic2018-06-30 23:342020-11-30 01:04
ReporterRepo Man 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Statusneeds testingResolutionopen 
PlatformOSOS Version
Product Version3.0 
Target VersionFixed in Version 
Summary0003438: Desaturated translations created with CreateTranslation via ACS don't work online
DescriptionWhen trying to use scripts to create translations, I've noticed that desaturated translations created/stored via ACS don't work online. They work fine offline and also function when applied directly to an actor's properties using 'Translation,' but don't show up at all online when they're made with 'CreateTranslation' via ACS.
Steps To ReproduceUsing desaturatedbug.wad go to an offline game then summon 3 custom Imps with the following names:

doomimp1 - This is a CreateTranslation done with palette remapping to appear 100% black and is applied in the spawn state 'Thing_SetTranslation.'
doomimp2 - This is a CreateTranslation done with a desaturated translation value and is applied in the spawn state with 'Thing_SetTranslation.'
doomimp3 - This is a desaturated translation applied directly to the actor's properties.

Then repeat the process online and it should show doomimp2 as brown instead of blue.
Additional Information
TagsNo tags attached.
Relationships
Attached Files? desaturatedbug.wad (705) 2018-06-30 23:34
https://zandronum.com/tracker/file_download.php?file_id=2333&type=bug
png online.png (195,707) 2018-06-30 23:35
https://zandronum.com/tracker/file_download.php?file_id=2334&type=bug
png

png offline.png (160,420) 2018-06-30 23:35
https://zandronum.com/tracker/file_download.php?file_id=2335&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2018-06-30 23:34Repo ManNew Issue
2018-06-30 23:34Repo ManFile Added: desaturatedbug.wad
2018-06-30 23:35Repo ManFile Added: online.png
2018-06-30 23:35Repo ManFile Added: offline.png
2018-06-30 23:36Repo ManNote Added: 0019288
2020-10-31 23:34IvanNote Added: 0021557
2020-11-01 06:17KaminskyNote Added: 0021558
2020-11-01 06:19KaminskyNote Edited: 0021558bug_revision_view_page.php?bugnote_id=21558#r13264
2020-11-01 06:19KaminskyNote Edited: 0021558bug_revision_view_page.php?bugnote_id=21558#r13265
2020-11-22 20:12Torr SamahoNote Added: 0021565
2020-11-22 20:12Torr SamahoStatusnew => needs testing
2020-11-26 18:57IvanNote Added: 0021568
2020-11-26 22:33KaminskyNote Added: 0021569
2020-11-30 01:04KaminskyNote Edited: 0021569bug_revision_view_page.php?bugnote_id=21569#r13269

Notes
(0019288)
Repo Man   
2018-06-30 23:36   
I also attached screenshots showing the results of spawning the Imps online and offline.
(0021557)
Ivan   
2020-10-31 23:34   
Any progress on this?
(0021558)
Kaminsky   
2020-11-01 06:17   
(edited on: 2020-11-01 06:19)
I went ahead and made a patch that fixes desaturated translations not syncing with the clients in online games if they're created with CreateTranslation(). I uploaded it as a PR in Zandronum's repository page on OSDN:
https://osdn.net/projects/zandronum/ticket/40871 [^]
(0021565)
Torr Samaho   
2020-11-22 20:12   
I added your patch.
(0021568)
Ivan   
2020-11-26 18:57   
Is there a beta release where we can start using this change? I know we can provide testing for this immediately.
(0021569)
Kaminsky   
2020-11-26 22:33   
(edited on: 2020-11-30 01:04)
I can provide you a compiled Zandronum binary that contains this fix later.

EDIT:http://www.mediafire.com/file/00uug20trwdtp0s/Zandronum_3.1-alpha-r201129-2147.zip/file [^]