MantisBT - Zandronum
View Issue Details
0003433Zandronum[All Projects] Bugpublic2018-06-02 22:522020-04-29 01:20
StrikerMan780 
Torr Samaho 
normalminoralways
assignedopen 
MicrosoftWindowsXP/Vista/7
3.0 
 
0003433: Backport of GZDoom's model interpolation fixes. (Patch supplied)
In GZDoom, dpJudas committed some fixes to the horribly broken interpolation code it inherited from Zandronum. (The interpolation was incredibly jittery and only operated at 35fps)

I backported those fixes, adjusted them to work with Zan's older code, and made a patch. It'll be attached to this report.
No tags attached.
patch InterpolationFix.patch (6,386) 2018-06-02 22:52
https://zandronum.com/tracker/file_download.php?file_id=2329&type=bug
patch InterpolationFix_v2.patch (6,929) 2019-10-15 05:11
https://zandronum.com/tracker/file_download.php?file_id=2508&type=bug
patch InterpolationFix_v3.patch (1,324) 2019-11-05 21:14
https://zandronum.com/tracker/file_download.php?file_id=2511&type=bug
patch InterpolationFix_v3_commented.patch (1,399) 2020-04-19 22:39
https://zandronum.com/tracker/file_download.php?file_id=2575&type=bug
Issue History
2018-06-02 22:52StrikerMan780New Issue
2018-06-02 22:52StrikerMan780File Added: InterpolationFix.patch
2018-06-02 23:40StrikerMan780Note Added: 0019263
2018-06-03 10:11StrikerMan780Note Edited: 0019263bug_revision_view_page.php?bugnote_id=19263#r11564
2018-06-03 23:03StrikerMan780Note Edited: 0019263bug_revision_view_page.php?bugnote_id=19263#r11568
2018-06-24 13:39Torr SamahoNote Added: 0019281
2018-06-24 13:39Torr SamahoAssigned To => Torr Samaho
2018-06-24 13:39Torr SamahoStatusnew => feedback
2018-07-14 03:08StrikerMan780Note Added: 0019289
2018-07-14 03:08StrikerMan780Statusfeedback => assigned
2018-07-22 19:05Torr SamahoNote Added: 0019291
2018-08-05 20:40StrikerMan780Note Added: 0019311
2018-08-05 20:42StrikerMan780Note Edited: 0019311bug_revision_view_page.php?bugnote_id=19311#r11600
2018-10-02 22:15StrikerMan780Note Edited: 0019311bug_revision_view_page.php?bugnote_id=19311#r12089
2018-10-19 21:52StrikerMan780Note Added: 0020138
2019-10-15 05:11StrikerMan780File Added: InterpolationFix_v2.patch
2019-10-15 05:11StrikerMan780Note Added: 0021074
2019-11-05 21:14StrikerMan780Note Added: 0021075
2019-11-05 21:14StrikerMan780File Added: InterpolationFix_v3.patch
2019-12-14 19:32StrikerMan780Note Edited: 0021075bug_revision_view_page.php?bugnote_id=21075#r12887
2019-12-14 19:34StrikerMan780Note Edited: 0021075bug_revision_view_page.php?bugnote_id=21075#r12888
2020-04-19 19:33StrikerMan780Note Added: 0021268
2020-04-19 20:38Torr SamahoNote Added: 0021270
2020-04-19 22:39StrikerMan780File Added: InterpolationFix_v3_commented.patch
2020-04-19 22:39StrikerMan780Note Added: 0021272
2020-04-25 16:18Torr SamahoNote Added: 0021281
2020-04-27 04:51StrikerMan780Note Added: 0021283
2020-04-27 04:55StrikerMan780Note Edited: 0021283bug_revision_view_page.php?bugnote_id=21283#r13067
2020-04-27 17:42Torr SamahoNote Added: 0021286
2020-04-29 01:20StrikerMan780Note Added: 0021291

Notes
(0019263)
StrikerMan780   
2018-06-02 23:40   
(edited on: 2018-06-03 23:03)
Argh, forgot to remove GetTimeFloat in gl_models.cpp. It's not needed anymore.

Aside from that, the patch worked as I intended, the models will interpolate at the full uncapped framerate.

Also, in the patch, I listed all gzdoom commits I pulled changes from.

(0019281)
Torr Samaho   
2018-06-24 13:39   
Thanks for the patch. One quick question: There is an existing call to I_GetTimeFrac in gl_scene.cpp that doesn't seem to be adjusted by your patch. Is this intentional?
(0019289)
StrikerMan780   
2018-07-14 03:08   
Not sure. Where at? Got a line number?
(0019291)
Torr Samaho   
2018-07-22 19:05   
It's line 1029 in gl_scene.cpp.
(0019311)
StrikerMan780   
2018-08-05 20:40   
(edited on: 2018-10-02 22:15)
The only thing I can find is this commit:https://github.com/coelckers/gzdoom/commit/cf44d2e37a85fa1f4687be135256680e6e055e5e [^]

I haven't seen any ill behavior from not having this (I wasn't aware of it, thus why it was missing in the patch), but it might be a good idea to have it as well, just in case.

If you'd like, I can try to bring in this change, and test it, and if it's good, add it to my patch. Shall I do this?

(0020138)
StrikerMan780   
2018-10-19 21:52   
Awaiting a response. (Not to be impatient, just want to know what I should be doing.)
(0021074)
StrikerMan780   
2019-10-15 05:11   
Uploaded a V2 of the patch. Hope it does what is needed.
(0021075)
StrikerMan780   
2019-11-05 21:14   
(edited on: 2019-12-14 19:34)
Attached a V3 of the patch. Should be a lot less invasive, as it only modifies gl_models.cpp, but is lacking some of the extra precision brought about from the timer changes. (Which is basically a non-issue)

(0021268)
StrikerMan780   
2020-04-19 19:33   
Since you guys are ramping to a 3.1 release, could you look into the latest patch I submitted?
(0021270)
Torr Samaho   
2020-04-19 20:38   
Sorry for the insane delay. V3 looks non-invasive and easy to include, good job! Would you mind adding your initials with a short comment to the changed lines? Then, I'll add it for the upcoming 3.1 beta.
(0021272)
StrikerMan780   
2020-04-19 22:39   
Attached a version with comments. Hopefully it's what you're meaning.
(0021281)
Torr Samaho   
2020-04-25 16:18   
Yes, that's exactly what I meant. Thanks! Can you also give me a line for "zandronum-history.txt"? Then, I'll add your patch. You don't need to make a new patch file, putting the history line here as note is sufficient.
(0021283)
StrikerMan780   
2020-04-27 04:51   
(edited on: 2020-04-27 04:55)
+ Fixed jittery model interpolation, partly based on dpJudas's fix for GZDoom. [StrikerMan780]

(0021286)
Torr Samaho   
2020-04-27 17:42   
Thanks! I pushed this tohttps://bitbucket.org/zandronum/zandronum-sandbox-stable [^] so you can have a quick test. I plan to push it to the stable repo in the next days, before we release the new 3.1 beta.
(0021291)
StrikerMan780   
2020-04-29 01:20   
Looks good.