MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003433Zandronum[All Projects] Bugpublic2018-06-02 22:522019-10-15 05:11
ReporterStrikerMan780 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusassignedResolutionopen 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0 
Target VersionFixed in Version 
Summary0003433: Backport of GZDoom's model interpolation fixes. (Patch supplied)
DescriptionIn GZDoom, dpJudas committed some fixes to the horribly broken interpolation code it inherited from Zandronum. (The interpolation was incredibly jittery and only operated at 35fps)

I backported those fixes, adjusted them to work with Zan's older code, and made a patch. It'll be attached to this report.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch InterpolationFix.patch (6,386) 2018-06-02 22:52
https://zandronum.com/tracker/file_download.php?file_id=2329&type=bug
patch InterpolationFix_v2.patch (6,929) 2019-10-15 05:11
https://zandronum.com/tracker/file_download.php?file_id=2508&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-06-02 22:52StrikerMan780New Issue
2018-06-02 22:52StrikerMan780File Added: InterpolationFix.patch
2018-06-02 23:40StrikerMan780Note Added: 0019263
2018-06-03 10:11StrikerMan780Note Edited: 0019263bug_revision_view_page.php?bugnote_id=19263#r11564
2018-06-03 23:03StrikerMan780Note Edited: 0019263bug_revision_view_page.php?bugnote_id=19263#r11568
2018-06-24 13:39Torr SamahoNote Added: 0019281
2018-06-24 13:39Torr SamahoAssigned To => Torr Samaho
2018-06-24 13:39Torr SamahoStatusnew => feedback
2018-07-14 03:08StrikerMan780Note Added: 0019289
2018-07-14 03:08StrikerMan780Statusfeedback => assigned
2018-07-22 19:05Torr SamahoNote Added: 0019291
2018-08-05 20:40StrikerMan780Note Added: 0019311
2018-08-05 20:42StrikerMan780Note Edited: 0019311bug_revision_view_page.php?bugnote_id=19311#r11600
2018-10-02 22:15StrikerMan780Note Edited: 0019311bug_revision_view_page.php?bugnote_id=19311#r12089
2018-10-19 21:52StrikerMan780Note Added: 0020138
2019-10-15 05:11StrikerMan780File Added: InterpolationFix_v2.patch
2019-10-15 05:11StrikerMan780Note Added: 0021074

Notes
(0019263)
StrikerMan780   
2018-06-02 23:40   
(edited on: 2018-06-03 23:03)
Argh, forgot to remove GetTimeFloat in gl_models.cpp. It's not needed anymore.

Aside from that, the patch worked as I intended, the models will interpolate at the full uncapped framerate.

Also, in the patch, I listed all gzdoom commits I pulled changes from.
(0019281)
Torr Samaho   
2018-06-24 13:39   
Thanks for the patch. One quick question: There is an existing call to I_GetTimeFrac in gl_scene.cpp that doesn't seem to be adjusted by your patch. Is this intentional?
(0019289)
StrikerMan780   
2018-07-14 03:08   
Not sure. Where at? Got a line number?
(0019291)
Torr Samaho   
2018-07-22 19:05   
It's line 1029 in gl_scene.cpp.
(0019311)
StrikerMan780   
2018-08-05 20:40   
(edited on: 2018-10-02 22:15)
The only thing I can find is this commit:https://github.com/coelckers/gzdoom/commit/cf44d2e37a85fa1f4687be135256680e6e055e5e [^]

I haven't seen any ill behavior from not having this (I wasn't aware of it, thus why it was missing in the patch), but it might be a good idea to have it as well, just in case.

If you'd like, I can try to bring in this change, and test it, and if it's good, add it to my patch. Shall I do this?
(0020138)
StrikerMan780   
2018-10-19 21:52   
Awaiting a response. (Not to be impatient, just want to know what I should be doing.)
(0021074)
StrikerMan780   
2019-10-15 05:11   
Uploaded a V2 of the patch. Hope it does what is needed.