Notes |
|
(0019263)
|
StrikerMan780
|
2018-06-02 23:40
(edited on: 2018-06-03 23:03) |
|
Argh, forgot to remove GetTimeFloat in gl_models.cpp. It's not needed anymore.
Aside from that, the patch worked as I intended, the models will interpolate at the full uncapped framerate.
Also, in the patch, I listed all gzdoom commits I pulled changes from.
|
|
|
|
Thanks for the patch. One quick question: There is an existing call to I_GetTimeFrac in gl_scene.cpp that doesn't seem to be adjusted by your patch. Is this intentional? |
|
|
|
Not sure. Where at? Got a line number? |
|
|
|
It's line 1029 in gl_scene.cpp. |
|
|
(0019311)
|
StrikerMan780
|
2018-08-05 20:40
(edited on: 2018-10-02 22:15) |
|
The only thing I can find is this commit:https://github.com/coelckers/gzdoom/commit/cf44d2e37a85fa1f4687be135256680e6e055e5e [^]
I haven't seen any ill behavior from not having this (I wasn't aware of it, thus why it was missing in the patch), but it might be a good idea to have it as well, just in case.
If you'd like, I can try to bring in this change, and test it, and if it's good, add it to my patch. Shall I do this?
|
|
|
|
Awaiting a response. (Not to be impatient, just want to know what I should be doing.) |
|
|
|
Uploaded a V2 of the patch. Hope it does what is needed. |
|
|
(0021075)
|
StrikerMan780
|
2019-11-05 21:14
(edited on: 2019-12-14 19:34) |
|
Attached a V3 of the patch. Should be a lot less invasive, as it only modifies gl_models.cpp, but is lacking some of the extra precision brought about from the timer changes. (Which is basically a non-issue)
|
|
|
|
Since you guys are ramping to a 3.1 release, could you look into the latest patch I submitted? |
|
|
|
Sorry for the insane delay. V3 looks non-invasive and easy to include, good job! Would you mind adding your initials with a short comment to the changed lines? Then, I'll add it for the upcoming 3.1 beta. |
|
|
|
Attached a version with comments. Hopefully it's what you're meaning. |
|
|
|
Yes, that's exactly what I meant. Thanks! Can you also give me a line for "zandronum-history.txt"? Then, I'll add your patch. You don't need to make a new patch file, putting the history line here as note is sufficient. |
|
|
(0021283)
|
StrikerMan780
|
2020-04-27 04:51
(edited on: 2020-04-27 04:55) |
|
+ Fixed jittery model interpolation, partly based on dpJudas's fix for GZDoom. [StrikerMan780]
|
|
|
|
|
|
|
|