MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003398Doomseeker[All Projects] Bugpublic2018-03-04 11:572018-10-27 22:53
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritylowSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
Platformx86_64OSDebian GNU/LinuxOS Versionbuster/sid
Product Version1.1 
Target Version1.2Fixed in Version1.2 
Summary0003398: Buddies: Square brackets in "Add Buddy" are accepted by basic pattern type but not matching and the pattern is removed on launch
DescriptionIf my ingame name on Zandronum is []Wub then it's impossible to match []Wub with basic pattern type in Doomseeker, yet it's temporarily accepted as a valid pattern but also removed on next launch of Doomseeker.
Steps To Reproduce
  1. (Optional) "name []Wub" on a Zandronum server. (This should be displayed as "[]Wub" in server details of Doomseeker and ingame, without quotes.)
  2. (Optional) Find said server in Doomseeker through Zandronum master server or Custom Servers. (For LAN servers, note seperate issue 0003397.)
  3. Launch Doomseeker.
  4. Open "Buddies" if it's not open already: View → Buddies (Ctrl+B)
  5. Click "Manage" in the Buddies window.
  6. Remove any existing pattern types, if applicable.
  7. Press "Add" and add a new basic pattern type: []Wub
  8. (Optional) If you did steps 1 & 2, notice how []Wub doesn't match. (It would match with advanced pattern type \[\]Wub, however.)
  9. Pay attention how []Wub should now be in the Buddies list of "Manage" tab. Quit Doomseeker (File → Quit (Ctrl+Q)).
  10. Start Doomseeker again.
  11. Notice how this time []Wub is missing from the Buddies list of "Manage" tab.
Additional InformationDitto in current 1.2~beta-1 (latest source as of time of writing).
TagsNo tags attached.
Relationships
parent of 0003399closed Zalewa Buddies: Deleting an invalid basic pattern type will remove the next pattern in list index 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-04 11:57WubTheCaptainNew Issue
2018-03-04 11:57WubTheCaptainAdditional Information Updatedbug_revision_view_page.php?rev_id=11474#r11474
2018-03-04 12:05WubTheCaptainSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11476#r11476
2018-03-04 12:05WubTheCaptainSummaryBuddies: Brackets in "Add Buddy" are accepted by basic pattern type, but not matching and removed on next launch => Buddies: Square brackets in "Add Buddy" are accepted by basic pattern type, but not matching and removed on next launch
2018-03-04 12:09WubTheCaptainSummaryBuddies: Square brackets in "Add Buddy" are accepted by basic pattern type, but not matching and removed on next launch => Buddies: Square brackets in "Add Buddy" are accepted by basic pattern type but not matching and the pattern is removed on launch
2018-03-04 12:21WubTheCaptainRelationship addedchild of 0003399
2018-10-05 07:22WubTheCaptainPrioritynormal => low
2018-10-13 14:47ZalewaAssigned To => Zalewa
2018-10-13 14:47ZalewaStatusnew => assigned
2018-10-13 16:47ZalewaNote Added: 0020102
2018-10-13 16:47ZalewaStatusassigned => needs testing
2018-10-13 17:00WubTheCaptainTarget Version => 1.2
2018-10-13 17:48WubTheCaptainRelationship replacedparent of 0003399
2018-10-13 17:54WubTheCaptainNote Added: 0020106
2018-10-13 17:54WubTheCaptainStatusneeds testing => needs review
2018-10-13 17:56WubTheCaptainNote Edited: 0020106bug_revision_view_page.php?bugnote_id=20106#r12259
2018-10-13 17:56ZalewaNote Added: 0020108
2018-10-13 17:57WubTheCaptainNote Added: 0020109
2018-10-13 17:57WubTheCaptainStatusneeds review => resolved
2018-10-13 17:57WubTheCaptainFixed in Version => 1.2
2018-10-13 17:57WubTheCaptainResolutionopen => fixed
2018-10-27 22:53WubTheCaptainStatusresolved => closed

Notes
(0020102)
Zalewa   
2018-10-13 16:47   
'https://bitbucket.org/Doomseeker/doomseeker/commits/4f87a2e3482f8da1ddca32aad6c2fd6ef4b7913d [^]'

The "Add Buddy" dialog box should now reject the invalid patterns outright, no matter if they're basic or advanced.

Also, I changed the way in which the patterns are serialized. Qt now deals with serialization of QRegExp objects that constitute the buddy patterns. The value stored in the .ini file is no longer user friendly, but at least we don't need to worry about our homebrewed parser not reading something correctly.
(0020106)
WubTheCaptain   
2018-10-13 17:54   
(edited on: 2018-10-13 17:56)
Buddies added in 1.2 won't be written to config in a backwards compatible way to deprecated pre-1.2 BuddiesList. I suppose this is acceptable.
(0020108)
Zalewa   
2018-10-13 17:56   
Quote from WubTheCaptain
Buddies added in 1.2 won't be written to config to be backwards compatible to deprecated pre-1.2 BuddiesList. I suppose this is acceptable.

Indeed.
(0020109)
WubTheCaptain   
2018-10-13 17:57   
Besides my previous note on backwards compatibility (downgrading software version), I believe this is resolved if Zalewa finds my notion acceptable too.