MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003388Doomseeker[All Projects] Suggestionpublic2018-03-01 19:422018-10-27 22:54
ReporterZalewa 
Assigned ToZalewa 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.1 
Target Version1.2Fixed in Version1.2 
Summary0003388: Mark servers as favorite
DescriptionRequest made by oddbenk: "what i would like to recommend (if i may) for the next release of the doomseeker is that you can add servers to your favourites."
Steps To Reproduce
Additional InformationRequest:'https://zandronum.com/forum/viewtopic.php?p=111261#p111261 [^]'
TagsNo tags attached.
Relationships
related to 0003506closed  Pinned Servers configuration is missing a table heading for enabled/disabled state checkbox 
related to 0003477acknowledged  ServerPtr and multiple "sources of truth" 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-01 19:42ZalewaNew Issue
2018-03-02 16:54WubTheCaptainNote Added: 0019100
2018-03-02 16:54WubTheCaptainStatusnew => feedback
2018-03-02 16:56WubTheCaptainNote Edited: 0019100bug_revision_view_page.php?bugnote_id=19100#r11438
2018-03-03 09:44Blzut3Note Added: 0019103
2018-08-26 10:21ZalewaAssigned To => Zalewa
2018-08-26 10:21ZalewaStatusfeedback => assigned
2018-08-26 10:21ZalewaNote Added: 0019407
2018-08-30 09:59ZalewaRelationship addedrelated to 0003477
2018-08-30 11:02ZalewaNote Added: 0019455
2018-08-30 11:02ZalewaStatusassigned => needs testing
2018-08-30 11:02ZalewaNote Edited: 0019455bug_revision_view_page.php?bugnote_id=19455#r11747
2018-08-30 11:03ZalewaNote Edited: 0019455bug_revision_view_page.php?bugnote_id=19455#r11748
2018-09-29 15:16WubTheCaptainProduct Version => 1.1
2018-09-29 15:16WubTheCaptainTarget Version => 1.2
2018-09-29 16:05WubTheCaptainNote Added: 0019829
2018-09-29 16:06WubTheCaptainRelationship addedrelated to 0003506
2018-09-29 20:51ZalewaNote Added: 0019832
2018-09-29 20:51ZalewaStatusneeds testing => resolved
2018-09-29 20:51ZalewaFixed in Version => 1.2
2018-09-29 20:51ZalewaResolutionopen => fixed
2018-10-27 22:54WubTheCaptainStatusresolved => closed

Notes
(0019100)
WubTheCaptain   
2018-03-02 16:54   
(edited on: 2018-03-02 16:56)
How should this implementation be designed? Design wise if this is implemented, we could possibly seperate servers into tabs. E.g.:

  • All
  • Internet
  • Favorites
  • LAN
  • Custom Servers


Alternative design is to stick to what we currently have for Custom Servers:


  • Use different background colors.
  • Add a star icon for favorite servers, replacing the country flag.


I'm concerned the old design may quickly become too cluttered or visually noisy and difficult to read. It's just enough to be "okay" for Custom Servers, but adding any more things like Favorites may not be ideal.
(0019103)
Blzut3   
2018-03-03 09:44   
Another background color might not even be necessary. I've actually used the custom servers feature as a way to pin a specific server to the top of the list even though it's advertised on the master myself. Might even be possible to just rename the custom servers feature to "favorites" or "pinned servers" and add some context menu options to add/remove. ("Custom servers" isn't really a great name for the existing feature when you really think about it.)
(0019407)
Zalewa   
2018-08-26 10:21   
"Pinned servers" it is then. I'll get onto it.
(0019455)
Zalewa   
2018-08-30 11:02   
(edited on: 2018-08-30 11:03)
Implementation of this was harder than I originally thought, thanks to the problem described in issue 0003477. However, the "pinned servers" feature should be ready through following commits:

Feature:
1.'https://bitbucket.org/Doomseeker/doomseeker/commits/6d131529348261c5dd68a15c705d798b6365475a [^]' - "Custom Servers" renamed to "Pinned Servers"

Bugs:
1. Custom servers would throw off the server counters (visible in bottom-right corner of the main window). This problem also affected previous versions of Doomseeker.
2. Ownership issues and "muting" Server objects as explained in 0003477.

Extras:
1. Allow to disable custom servers without deconfiguring them, allowing for easy re-enable
2. Follow-up to the custom servers "enable/disable" feature, providing backward-compatibility with previous versions of Doomseeker.
(0019829)
WubTheCaptain   
2018-09-29 16:05   
Quote from Zalewa
https://bitbucket.org/Doomseeker/doomseeker/commits/6d131529348261c5dd68a15c705d798b6365475a - "Custom Servers" renamed to "Pinned Servers"


Ok.

Quote from Zalewa
Custom servers would throw off the server counters (visible in bottom-right corner of the main window). This problem also affected previous versions of Doomseeker.

Ownership issues and "muting" Server objects as explained in 0003477.


Didn't test (both difficult).

Quote from Zalewa
Allow to disable custom servers without deconfiguring them, allowing for easy re-enable


0003506, but ok.

Quote from Zalewa
Follow-up to the custom servers "enable/disable" feature, providing backward-compatibility with previous versions of Doomseeker.


Didn't test.
(0019832)
Zalewa   
2018-09-29 20:51   
Some testing is better than no testing. Thank you. Marking this as resolved for the time being.