MantisBT - Doomseeker
View Issue Details
0003374Doomseeker[All Projects] Bugpublic2018-02-16 08:232018-02-17 19:19
WubTheCaptain 
WubTheCaptain 
lowtexthave not tried
closedinvalid 
1.2 
1.2 
0003374: Bad English grammar in canAnyEngineRcon error string
In src/core/main.cpp, the QString for canAnyEngineRecon check says:

Quote
None of the currently loaded game plugins supports RCon.


"plugins" is plural as intended, but "supports" is singular.

Should this be a plural verb, like so?

Quote
None of the currently loaded game plugins support RCon.

  1. Verify the Doomseeker version is at least 1.2~beta-180215-1343 (9d5ae04a4689, revision 1518702210)

  2. Remove all engines (e.g. the engines directory from Doomseeker path)

  3. doomseeker --rcon

commit 9d5ae04a46896125d78b08795ab6bf5a3f8ca1b1

I'm not a native English speaker, by the way.
No tags attached.
related to 0003324closed Zalewa RCon client process stays alive after RCon fails and init is finished, doesn't exit normally after error 
patch 0001-RCon-Fix-canAnyEngineRcon-grammar.patch (893) 2018-02-16 08:38
/tracker/file_download.php?file_id=2304&type=bug
Issue History
2018-02-16 08:23WubTheCaptainNew Issue
2018-02-16 08:25WubTheCaptainRelationship addedrelated to 0003324
2018-02-16 08:26WubTheCaptainSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11404#r11404
2018-02-16 08:30WubTheCaptainAssigned To => WubTheCaptain
2018-02-16 08:30WubTheCaptainStatusnew => assigned
2018-02-16 08:38WubTheCaptainFile Added: 0001-RCon-Fix-canAnyEngineRcon-grammar.patch
2018-02-16 08:38WubTheCaptainStatusassigned => needs review
2018-02-16 08:38WubTheCaptainTarget Version => 1.2
2018-02-16 08:38WubTheCaptainNote Added: 0019058
2018-02-16 08:47WubTheCaptainNote Edited: 0019058bug_revision_view_page.php?bugnote_id=19058#r11406
2018-02-16 09:19ZalewaNote Added: 0019059
2018-02-17 18:01KorshunNote Added: 0019064
2018-02-17 19:19WubTheCaptainStatusneeds review => closed
2018-02-17 19:19WubTheCaptainResolutionopen => invalid

Notes
(0019058)
WubTheCaptain   
2018-02-16 08:38   
(edited on: 2018-02-16 08:47)
Patch by me and attached.

(0019059)
Zalewa   
2018-02-16 09:19   
Online sources say that both forms are correct.
(0019064)
Korshun   
2018-02-17 18:01   
I am not a native speaker either, but I am very sure that both forms are correct.