MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003365DoomseekerIP2Cpublic2018-02-02 10:352018-12-17 03:34
ReporterDrinkyBird 
Assigned ToWubTheCaptain 
PrioritylowSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.1 
Target Version1.2Fixed in Version1.2 
Summary0003365: Doomseeker's GB flag is incorrect
DescriptionSo here's the nitpickiest ticket you've read in a while:

Doomseeker's GB flag is not a standard Union Flag as it does not have the red diagonal lines representing the Saint Patrick's Saltire.
Steps To ReproduceCompare:
'https://bytebucket.org/Doomseeker/doomseeker/raw/8998d075e79f6d9edccab40373977a7ebed73927/media/flags/GBR.png [^]'
against any conformant Union Flag, e.g.:
'https://upload.wikimedia.org/wikipedia/en/a/ae/Flag_of_the_United_Kingdom.svg [^]'

Note how Doomseeker's lacks the red diagonal lines.
Additional InformationI am aware that the Saint Patrick's Saltire represents Ireland which has not been a part of the UK for a loong time. However, its use in the Union Flag is generally now used to represent Northern Ireland, which is part of the UK and is under the GBR country code.
TagsNo tags attached.
Relationships
child of 0003540closed WubTheCaptain Country flag changes are not mentioned in Doomseeker 1.2 changelog 
Attached Files? Flag_of_the_United_Kingdom.svg (521) 2018-02-03 14:47
/tracker/file_download.php?file_id=2294&type=bug
png GBR.png (1,143) 2018-02-03 14:47
/tracker/file_download.php?file_id=2295&type=bug
png

? flag_template.GBR.xcf (3,314) 2018-02-03 14:47
/tracker/file_download.php?file_id=2296&type=bug
patch flags-Update-GBR-to-year-1801-version-of-the-flag.patch (949) 2018-02-03 15:21
/tracker/file_download.php?file_id=2297&type=bug
patch flags-Update-GBR-to-year-1801-version-of-the-flag.git.patch (2,514) 2018-02-03 15:21
/tracker/file_download.php?file_id=2298&type=bug
png GBR-kings-colors-1601.png (1,059) 2018-02-03 15:34
/tracker/file_download.php?file_id=2299&type=bug
png

? Flag_of_Great_Britain_(1707-1800).svg (396) 2018-02-03 15:35
/tracker/file_download.php?file_id=2300&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-02-02 10:35DrinkyBirdNew Issue
2018-02-03 14:42WubTheCaptainAssigned To => WubTheCaptain
2018-02-03 14:42WubTheCaptainStatusnew => assigned
2018-02-03 14:47WubTheCaptainFile Added: Flag_of_the_United_Kingdom.svg
2018-02-03 14:47WubTheCaptainFile Added: GBR.png
2018-02-03 14:47WubTheCaptainFile Added: flag_template.GBR.xcf
2018-02-03 14:52WubTheCaptainTarget Version => 1.2
2018-02-03 15:21WubTheCaptainFile Added: flags-Update-GBR-to-year-1801-version-of-the-flag.patch
2018-02-03 15:21WubTheCaptainFile Added: flags-Update-GBR-to-year-1801-version-of-the-flag.git.patch
2018-02-03 15:21WubTheCaptainStatusassigned => needs review
2018-02-03 15:31WubTheCaptainNote Added: 0019016
2018-02-03 15:32WubTheCaptainNote Edited: 0019016bug_revision_view_page.php?bugnote_id=19016#r11384
2018-02-03 15:32WubTheCaptainNote Edited: 0019016bug_revision_view_page.php?bugnote_id=19016#r11385
2018-02-03 15:34WubTheCaptainFile Added: GBR-kings-colors-1601.png
2018-02-03 15:35WubTheCaptainFile Added: Flag_of_Great_Britain_(1707-1800).svg
2018-02-03 15:35WubTheCaptainNote Added: 0019017
2018-02-03 15:45WubTheCaptainNote Added: 0019018
2018-02-03 15:48WubTheCaptainNote Edited: 0019016bug_revision_view_page.php?bugnote_id=19016#r11386
2018-02-04 09:24ZalewaNote Added: 0019019
2018-02-04 09:24ZalewaStatusneeds review => resolved
2018-02-04 09:24ZalewaFixed in Version => 1.2
2018-02-04 09:24ZalewaResolutionopen => fixed
2018-10-06 14:02WubTheCaptainRelationship addedchild of 0003540
2018-10-27 22:54WubTheCaptainStatusresolved => closed
2018-12-17 03:34WubTheCaptainCategoryBug => IP2C

Notes
(0019016)
WubTheCaptain   
2018-02-03 15:31   
(edited on: 2018-02-03 15:48)
Thanks for the bug report. Patches and files attached.


  1. The country flags are in the public domain, uploaded SVG is from Wikimedia Commons (File:Flag of the United Kingdom.svg).

  2. GBR.png was downscaled and stretched from Flag_of_the_United_Kingdom.svg.

  3. flag_template.GBR.xcf adopted from media/flags/flag_template.xcf in Doomseeker source.

  4. Patches by me (detailed historical explanation for this change in the commit description).



Note: GBR.png not optipng'd, I forgot.
(0019017)
WubTheCaptain   
2018-02-03 15:35   
Old flag attached for comparison. (File:Flag of Great Britain (1707-1800).svg)
(0019018)
WubTheCaptain   
2018-02-03 15:45   
GBR is also indeed the ISO 3166-1 alpha-3 code for United Kingdom:'https://en.wikipedia.org/wiki/ISO_3166-1_alpha-3#Current_codes [^]'
(0019019)
Zalewa   
2018-02-04 09:24   
Done:'https://bitbucket.org/Doomseeker/doomseeker/commits/2624ac77d98716f63439c2bba34e26b33cf44ae4 [^]'