MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003322Doomseeker[All Projects] Suggestionpublic2017-10-30 06:172018-10-06 18:19
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynormalSeverityblockReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.2 
Target Version1.2Fixed in Version1.2 
Summary0003322: Clarify copyright status of distributed LGPL binaries (Nokia's LGPLv2.1-only code)
DescriptionThe about dialog now says Doomseeker and Wadseeker to be LGPLv2.1+:'https://bitbucket.org/Doomseeker/doomseeker/commits/0dba2ec82ddda80b1252c8523d0a3c9148cea9d6 [^]'

But there's actually LGPLv2.1-only code in Wadseeker from Nokia / Qt, which Doomseeker links to.

What do?
Steps To ReproduceThese files are LGPLv2.1 only (not "any later version") with a special exception (LGPL_EXCEPTION.txt):


  • src/wadseeker/protocols/fixedftpreply.h

  • src/wadseeker/protocols/fixedftpreply.cpp

  • src/wadseeker/protocols/fixednetworkaccessmanager.h

  • src/wadseeker/protocols/fixednetworkaccessmanager.cpp

Additional Information
TagsNo tags attached.
Relationships
related to 0003309closed Zalewa FixedFtpReply and FixedNetworkAccessManager have missing license files 
child of 0003237closed WubTheCaptain Non-free files and copyright issues in source archive 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-10-30 06:17WubTheCaptainNew Issue
2017-10-30 06:17WubTheCaptainRelationship addedchild of 0003237
2017-10-30 06:18WubTheCaptainSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11233#r11233
2017-10-30 06:18WubTheCaptainRelationship addedrelated to 0003309
2017-10-30 06:18WubTheCaptainRelationship deletedrelated to 0003309
2017-10-30 06:24WubTheCaptainDescription Updatedbug_revision_view_page.php?rev_id=11235#r11235
2017-10-30 06:25WubTheCaptainSeveritytext => block
2017-10-30 06:26WubTheCaptainNote Added: 0018684
2017-10-30 06:29WubTheCaptainSummaryClarify copyright status of distributed LGPL binaries => Clarify copyright status of distributed LGPL binaries (Nokia's LGPLv2.1-only code)
2017-10-30 06:30WubTheCaptainRelationship addedrelated to 0003309
2017-10-30 06:31WubTheCaptainNote Added: 0018685
2017-10-30 06:32WubTheCaptainNote Edited: 0018685bug_revision_view_page.php?bugnote_id=18685#r11237
2017-11-01 10:46ZalewaAssigned To => Zalewa
2017-11-01 10:46ZalewaStatusnew => assigned
2017-11-01 11:37ZalewaNote Added: 0018707
2017-11-01 12:30ZalewaNote Added: 0018709
2017-11-01 12:30ZalewaStatusassigned => needs review
2017-11-01 12:56WubTheCaptainNote Added: 0018711
2017-11-01 12:56WubTheCaptainStatusneeds review => needs testing
2017-11-03 10:17WubTheCaptainFixed in Version => 1.2
2018-08-27 02:46WubTheCaptainNote Added: 0019421
2018-08-27 02:46WubTheCaptainStatusneeds testing => resolved
2018-08-27 02:46WubTheCaptainResolutionopen => fixed
2018-10-06 18:19WubTheCaptainStatusresolved => closed

Notes
(0018684)
WubTheCaptain   
2017-10-30 06:26   
Blocker because binaries should not be legal to distribute at the moment, and would cause automatic termination of license.
(0018685)
WubTheCaptain   
2017-10-30 06:31   
(edited on: 2017-10-30 06:32)
Doomseeker 1.1 binaries seem to be unaffected?
(0018707)
Zalewa   
2017-11-01 11:37   
These classes were first introduced to work around an FTP communication blunder in Qt implementation which caused all communication to die on SIZE command.

This problem seems to be fixed in Qt 4.8 as I wrote a small tool for testing purposes and this tool communicates just fine with idgames archives FTPs, even when compiled against Qt 4.8.7.

At the current moment, I think we can just remove those classes from the code.
(0018709)
Zalewa   
2017-11-01 12:30   
Problem solved:'https://bitbucket.org/Doomseeker/doomseeker/commits/3ba35a884c8f33a30583f20352d54d72cedf9559 [^]'
(0018711)
WubTheCaptain   
2017-11-01 12:56   
Looks fine to me, and it builds & works on my machine (with Qt5).

I'll leave this up for testing until 1.2 release, in case of complaints.
(0019421)
WubTheCaptain   
2018-08-27 02:46   
Re-open or create a new ticket if you find issues.