MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003285Doomseeker[All Projects] Suggestionpublic2017-10-03 18:292018-10-27 22:55
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynormalSeveritytweakReproducibilityN/A
StatusclosedResolutionfixed 
Platformx86_64OSDebian GNU/LinuxOS Versionbuster/sid
Product Version1.1 
Target Version1.2Fixed in Version1.2 
Summary0003285: IRC: Add a button to remove defined IRC networks from connect dialog
DescriptionDoomseeker includes a small IRC client. Currently, it only allows to add new IRC network definitions and edit them.

Please add a way to delete defined IRC networks without editing doomseeker-irc.ini configuration manually in a text editor.
Steps To Reproduce

  1. If IRC is not already visible, to view it press Ctrl + I or access it via top crates (View → IRC) or the button (IRC).

  2. On the left side of IRC panel, click the "Connect button".

  3. Notice how there's buttons for adding and editing defined networks, but not for deleting them.

Additional Information
TagsNo tags attached.
Relationships
related to 0003284closed Zalewa IRC: Defining an empty IRC network address results in that defined IRC network becoming uneditable from connect dialog 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-10-03 18:29WubTheCaptainNew Issue
2017-10-03 18:30WubTheCaptainSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11031#r11031
2017-10-03 19:56WubTheCaptainNote Added: 0018421
2017-10-03 20:00WubTheCaptainSummaryIRC: Add a button to remove defined IRC networks => IRC: Add a button to remove defined IRC networks from connect dialog
2017-11-03 12:54WubTheCaptainSeverityfeature => tweak
2017-11-03 14:42ZalewaAssigned To => Zalewa
2017-11-03 14:42ZalewaStatusnew => acknowledged
2017-11-03 16:31ZalewaStatusacknowledged => assigned
2017-11-03 18:08ZalewaNote Added: 0018743
2017-11-03 18:08ZalewaStatusassigned => needs review
2017-11-03 18:08ZalewaTarget Version => 1.2
2017-11-03 23:11WubTheCaptainRelationship addedrelated to 0003284
2017-11-04 00:03WubTheCaptainNote Added: 0018752
2017-11-04 00:03WubTheCaptainStatusneeds review => assigned
2017-11-04 00:03WubTheCaptainNote Edited: 0018752bug_revision_view_page.php?bugnote_id=18752#r11271
2017-11-04 09:03ZalewaNote Added: 0018758
2017-11-04 14:46WubTheCaptainNote Added: 0018764
2017-11-04 14:46WubTheCaptainStatusassigned => needs review
2017-11-04 14:47WubTheCaptainNote Edited: 0018764bug_revision_view_page.php?bugnote_id=18764#r11279
2017-11-04 14:48WubTheCaptainNote Edited: 0018764bug_revision_view_page.php?bugnote_id=18764#r11280
2017-11-04 14:49WubTheCaptainNote Edited: 0018764bug_revision_view_page.php?bugnote_id=18764#r11281
2017-11-04 14:49WubTheCaptainNote Edited: 0018764bug_revision_view_page.php?bugnote_id=18764#r11282
2017-11-04 16:59ZalewaNote Added: 0018773
2017-11-05 00:58WubTheCaptainStatusneeds review => assigned
2017-11-05 13:44ZalewaNote Added: 0018794
2017-11-05 13:44ZalewaStatusassigned => resolved
2017-11-05 13:44ZalewaFixed in Version => 1.2
2017-11-05 13:44ZalewaResolutionopen => fixed
2018-10-27 22:55WubTheCaptainStatusresolved => closed

Notes
(0018421)
WubTheCaptain   
2017-10-03 19:56   
I found out there's an option to remove them from "IRC Options → Networks", but no such option in the connect dialog.
(0018743)
Zalewa   
2017-11-03 18:08   
'https://bitbucket.org/Doomseeker/doomseeker/commits/19a22b7503158b4cafaef6d708a628a2189c534a [^]'
(0018752)
WubTheCaptain   
2017-11-04 00:03   
I can confirm the pencil.png icon was available under a Creative Commons Attribution 3.0 Unported license on said date at external URL, as an alternative to CC BY-2.5 licensing. Seems fine.

There's a bit of inconsistency now, because one of the dialog titles was changed from "remove network" to "remove IRC network". Polish translations are missing for this new dialog (but hey, they are also missing in a lot more places, i.e. tooltips all around Doomseeker).

Quote
Are you use you wish to remove network X?


"Are you use you...?" → "Are you sure you...?"

This also changed src/core/irc/entities/ircnetworkentity.cpp without mentioning it, which in turn resolved 0003284 (unknowingly).
(0018758)
Zalewa   
2017-11-04 09:03   
The translation gets the same treatment as changelog.md. I prefer to update it in bulk. Rest assured that I will update the translation eventually.

As for the wording:'https://bitbucket.org/Doomseeker/doomseeker/commits/4e8594225adcd7e4b1db19f1c88a5e13d8afe6ab [^]'
(0018764)
WubTheCaptain   
2017-11-04 14:46   
(edited on: 2017-11-04 14:49) 
$ grep -ir "remove network" src/ | wc -l
3
$ grep -ir "remove IRC network" src/ | wc -l
2
$ grep -ir "connect to network" src/ | wc -l
1
$ grep -ir "define IRC network" src/ | wc -l
2
$ grep -ir "add network" src/ | wc -l
1


If this new inconsistency is fine, consider it resolved.
(0018773)
Zalewa   
2017-11-04 16:59   
Quote from "WubTheCaptain"
If this new inconsistency is fine, consider it resolved.

I'll normalize this.
(0018794)
Zalewa   
2017-11-05 13:44   
Actually, the cases you pointed out are okay within their contexts. I have normalized something else, though.