MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003283Doomseeker[All Projects] Bugpublic2017-10-03 18:152018-10-27 22:55
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynormalSeveritytextReproducibilityrandom
StatusclosedResolutionfixed 
Platformx86_64OSDebian GNU/LinuxOS Versionbuster/sid
Product Version1.1 
Target Version1.2Fixed in Version1.2 
Summary0003283: IRC: Connect dialog shows incorrect port number in port field when not default
DescriptionDoomseeker includes a small IRC client. Its connect dialog displays an incorrect port number for the selected server (for anything not the default port "6667" configured).
Steps To Reproduce

  1. If IRC is not already visible, to view it press Ctrl + I or access it via top crates (View → IRC) or the button (IRC).

  2. On the left side of IRC panel, click the "Connect button".

  3. Add a new or edit any current server. Make sure it has any unique description.

  4. Change the port to anything else than default 6667. (e.g. 6665)

  5. Press "OK".

  6. Make sure your server with a non-default port is selected in the dropdown menu in IRC dialog.

  7. Notice the port to be correct in the dropdown menu, but incorrect in the server details below it (above the password).

Additional Information
TagsNo tags attached.
Relationships
Attached Files? doomseeker-irc.broken.ini (1,572) 2017-11-03 23:26
https://zandronum.com/tracker/file_download.php?file_id=2246&type=bug
? doomseeker-irc.working.ini (1,515) 2017-11-03 23:28
https://zandronum.com/tracker/file_download.php?file_id=2247&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-10-03 18:15WubTheCaptainNew Issue
2017-11-03 22:52WubTheCaptainNote Added: 0018745
2017-11-03 22:56WubTheCaptainNote Added: 0018746
2017-11-03 22:56WubTheCaptainReproducibilityalways => sometimes
2017-11-03 22:59WubTheCaptainNote Added: 0018747
2017-11-03 23:17WubTheCaptainNote Added: 0018749
2017-11-03 23:22WubTheCaptainNote Added: 0018750
2017-11-03 23:22WubTheCaptainReproducibilitysometimes => random
2017-11-03 23:26WubTheCaptainFile Added: doomseeker-irc.broken.ini
2017-11-03 23:28WubTheCaptainFile Added: doomseeker-irc.working.ini
2017-11-03 23:29WubTheCaptainNote Edited: 0018750bug_revision_view_page.php?bugnote_id=18750#r11267
2017-11-03 23:35WubTheCaptainNote Added: 0018751
2017-11-03 23:36WubTheCaptainNote Edited: 0018751bug_revision_view_page.php?bugnote_id=18751#r11269
2017-11-04 09:09ZalewaAssigned To => Zalewa
2017-11-04 09:09ZalewaStatusnew => confirmed
2017-11-04 09:15ZalewaNote Added: 0018760
2017-11-04 09:15ZalewaStatusconfirmed => needs review
2017-11-04 14:34WubTheCaptainStatusneeds review => needs testing
2017-11-04 14:53WubTheCaptainNote Added: 0018765
2017-11-04 14:53WubTheCaptainStatusneeds testing => resolved
2017-11-04 14:53WubTheCaptainFixed in Version => 1.2
2017-11-04 14:53WubTheCaptainResolutionopen => fixed
2017-11-04 14:54WubTheCaptainTarget Version => 1.2
2018-10-27 22:55WubTheCaptainStatusresolved => closed

Notes
(0018745)
WubTheCaptain   
2017-11-03 22:52   
Zalewa: This issue still happens when the server address is not empty. If the server address is empty, the correct port is displayed.
(0018746)
WubTheCaptain   
2017-11-03 22:56   
Now I'm also confused why this happens with random servers and differently with both 1.1 and 1.2.

I have added a server with pure IPv6-only address (2600:3c00::f03c:91ff:fe24:cdcc), and the port below it shows up incorrectly in both 1.1 and 1.2.

I can no longer reproduce in 1.1 nor 1.2 for regular hostnames like irc.zandronum.com.
(0018747)
WubTheCaptain   
2017-11-03 22:59   
Setting the address to

[2600:3c00::f03c:91ff:fe24:cdcc]


will instead fix the port display in the connect dialog for this one, but then Doomseeker thinks it's a hostname on connect and fails to DNS lookup. (I admit I have no IPv6 connectivity right at this moment, though.)
(0018749)
WubTheCaptain   
2017-11-03 23:17   
Happens with IPv4-addresses too, such as "127.0.0.1".
(0018750)
WubTheCaptain   
2017-11-03 23:22   
(edited on: 2017-11-03 23:29)
I tested with a new configuration and this changed again.


  1. Created new 1.1 config.

  2. Added an empty server in 1.1.

  3. Tested changing port numbers.

  4. Ran Doomseeker 1.2.

  5. Tested changing port numbers. Broken for hostnames and IPs.

  6. Went back to my long-lasting 1.2 config.

  7. Tested changing port numbers. It works there for hostnames, IPs and whatnot.



I don't even know anymore.

1.2~beta-171103-1810, 8aee070cd126, revision 1509732653.
(0018751)
WubTheCaptain   
2017-11-03 23:35   
(edited on: 2017-11-03 23:36)
Wtf? I see what might be happening.

Both doomseeker-irc.ini config files display the correct port above 6667 (e.g. 6668), but not for below it (e.g. 6666). This happens with both 1.1 and 1.2.
(0018760)
Zalewa   
2017-11-04 09:15   
Fixed:'https://bitbucket.org/Doomseeker/doomseeker/commits/a8ea2a12c2238f6d147412e4f7c105b33fa6fda5 [^]'
(0018765)
WubTheCaptain   
2017-11-04 14:53   
Works for me, thank you for the contribution.