MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003189Zandronum[All Projects] Bugpublic2017-07-16 20:002017-08-11 21:44
ReporterFrits 
Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusfeedbackResolutionopen 
PlatformOSOS Version
Product Version3.0-beta 
Target VersionFixed in Version 
Summary0003189: Skin sounds not working anymore
DescriptionFrom this post:

"I noticed in 3.0 that you can't use skin (sounds) anymore in complex doom, while you could in 2.0? Skins work perfectly in unmodded doom though. Did something change to alter this behavior or is this a bug?"

"They won't work in gzdoom either but I suspect that's because all zandroskins use skininfo and not S_SKIN lumps. I'm not sure about this though but I can't get my skins to work in 1.8.6 and the latest GZD build anyway."
Steps To ReproduceStart Zandronum with mincomplextest.pk3
Type skin "Quake 2 guy" and taunt
Additional Information
TagsNo tags attached.
Relationships
Attached Files? GZDTestGuy.wad (124,370) 2017-07-17 14:34
https://zandronum.com/tracker/file_download.php?file_id=2148&type=bug
? ZANTestGuy.wad (124,374) 2017-07-17 14:34
https://zandronum.com/tracker/file_download.php?file_id=2149&type=bug
? mincomplextest.pk3 (4,009,980) 2017-07-25 16:38
https://zandronum.com/tracker/file_download.php?file_id=2153&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-07-16 20:00Edward-sanNew Issue
2017-07-16 20:01Edward-sanReporterEdward-san => Frits
2017-07-16 20:03Edward-sanNote Added: 0018051
2017-07-16 20:03Edward-sanStatusnew => feedback
2017-07-17 14:34FritsFile Added: GZDTestGuy.wad
2017-07-17 14:34FritsFile Added: ZANTestGuy.wad
2017-07-17 14:36FritsNote Added: 0018055
2017-07-17 14:36FritsStatusfeedback => new
2017-07-17 14:38FritsNote Edited: 0018055bug_revision_view_page.php?bugnote_id=18055#r10785
2017-07-23 16:17Torr SamahoNote Added: 0018088
2017-07-25 16:38FritsNote Added: 0018097
2017-07-25 16:38FritsFile Added: mincomplextest.pk3
2017-07-25 16:40FritsNote Edited: 0018097bug_revision_view_page.php?bugnote_id=18097#r10824
2017-07-30 19:52DuskSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=10839#r10839
2017-07-30 20:33Edward-sanNote Added: 0018125
2017-07-30 20:33Edward-sanStatusnew => feedback
2017-07-30 20:51Edward-sanNote Deleted: 0018125
2017-07-30 20:52Edward-sanStatusfeedback => new
2017-07-30 21:59Edward-sanNote Added: 0018127
2017-07-30 21:59Edward-sanStatusnew => feedback
2017-07-30 22:01Edward-sanNote Edited: 0018127bug_revision_view_page.php?bugnote_id=18127#r10841
2017-08-06 20:35eagleNote Added: 0018147
2017-08-10 08:14DuskNote Added: 0018154
2017-08-11 17:18eagleNote Added: 0018160
2017-08-11 21:44LeonardNote Added: 0018161

Notes
(0018051)
Edward-san   
2017-07-16 20:03   
It would be nice to have both an example wad containing SKININFO and an example wad containing S_SKIN for GZdoom.
(0018055)
Frits   
2017-07-17 14:36   
(edited on: 2017-07-17 14:38)
Test skins(StrafeGuy) uploaded. ZANGUY with SKININFO and GZDGUY with S_SKIN.

I noticed with trial and error that you can't make a sound only skin for GZDOOM, it just won't recognize the skin unless you add new sprites.
(0018088)
Torr Samaho   
2017-07-23 16:17   
Thanks for the example wads! Can you elaborate what is wrong? I just briefly tested ZANTestGuy.wad and the new jump sound seemed fine both in 2.1.2 and 3.0.
(0018097)
Frits   
2017-07-25 16:38   
(edited on: 2017-07-25 16:40)
I stripped complex doom down to its bare minimum needed for the example wad.

In 2.1.2 choosing a custom skin works and plays the sounds in 3.0 it doesn't.

Steps:
Start Zandronum with mincomplextest.pk3
Type skin "Quake 2 guy" and taunt
(0018127)
Edward-san   
2017-07-30 21:59   
(edited on: 2017-07-30 22:01)
That mincomplextest.pk3 file contains a replacement class for the player which has also the +NOSKIN flag enabled.

After a bit of debugging I think the problem happens since this commit, which added a MF4_NOSKIN check in APlayerPawn::GetSoundClass. That prevents the skinned sound from playing.

Frits, why is the +NOSKIN flag present, by the way? Can you still reproduce the problem if you remove it?
(0018147)
eagle   
2017-08-06 20:35   
-NOSKIN - skins have earned.
(0018154)
Dusk   
2017-08-10 08:14   
This looks like a mod error to me. If you set +NOSKIN then why do you expect anything skin related to be enabled for that player class?
(0018160)
eagle   
2017-08-11 17:18   
In complex doom and all his mods NOSKIN is established +. For what daedalus put this flag only he knows. But he began to work with the new zandronum version as well as is conceived, probably. When it is noticed by other modders...
(0018161)
Leonard   
2017-08-11 21:44   
It might have to do with the fact that complex uses the Weapon.PreferredSkin feature