MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003165Zandronum[All Projects] Bugpublic2017-06-22 21:592018-09-30 21:43
ReporterKorshun 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0003165: Spectating while frozen doesn't unfreeze the spectator
DescriptionIf a player is frozen using PROP_FROZEN or PROP_TOTALLYFROZEN and spectates, the spectator is not unfrozen.

This bug does not happen in 2.1.2.
Steps To Reproduce1. run the attached trivial test wad (it tests PROP_TOTALLYFROZEN)
2. spectate
Additional InformationCredits to Kaminsky and FusedQyou for discovering this bug.

This bug happens in WDI.
TagsNo tags attached.
Relationships
Attached Files? totallyfrozen.wad (313) 2017-06-22 21:59
/tracker/file_download.php?file_id=2130&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-06-22 21:59KorshunNew Issue
2017-06-22 21:59KorshunFile Added: totallyfrozen.wad
2017-06-23 17:42Ru5tK1ngNote Added: 0017891
2017-06-24 23:38Ru5tK1ngNote Added: 0017901
2017-06-24 23:38Ru5tK1ngStatusnew => needs review
2017-06-24 23:38Ru5tK1ngTarget Version => 3.1
2017-07-02 22:30Ru5tK1ngNote Added: 0017972
2017-07-09 20:00Torr SamahoTarget Version3.1 => 3.0
2017-07-09 20:03Torr SamahoNote Added: 0017994
2017-07-09 20:03Torr SamahoStatusneeds review => needs testing
2017-07-09 23:51Ru5tK1ngNote Added: 0017998
2017-07-09 23:51Ru5tK1ngStatusneeds testing => resolved
2017-07-09 23:51Ru5tK1ngResolutionopen => fixed
2017-07-09 23:51Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:43Blzut3Statusresolved => closed

Notes
(0017891)
Ru5tK1ng   
2017-06-23 17:42   
This issue follows the same time frame that I mentioned here: 'http://www.zandronum.com/tracker/view.php?id=3164#c17888 [^]'

I have to say that the following commit might be the cause considering the changes Leonard made to P_User


'https://bitbucket.org/Torr_Samaho/zandronum/commits/381f296c9c7c043959b95d032881dae71a64114c#Lsrc/p_user.cppF2773T2773 [^]'
(0017901)
Ru5tK1ng   
2017-06-24 23:38   
The following fixed the issue for me when a player spectated or died in survival:

'https://bitbucket.org/Ru5tK1ng/zandoom/commits/a7d2c0455f5891af232bd6e0e959b2dddf2e5b36 [^]'

Since this isn't a game crashing bug and since it's been unknown for almost 2 years, I'll mark this for 3.1
(0017972)
Ru5tK1ng   
2017-07-02 22:30   
Updated to a much better way.

'https://bitbucket.org/Ru5tK1ng/zandoom/branch/frozenspec#diff [^]'
(0017994)
Torr Samaho   
2017-07-09 20:03   
Thanks! I added the updated patch.
(0017998)
Ru5tK1ng   
2017-07-09 23:51   
<Kaminsky> Whenever I would spectate while PROP_FROZEN or PROP_TOTALLYFROZEN was on, it was disabled and I could move around freely.