MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003151Zandronum[All Projects] Bugpublic2017-06-03 17:502018-05-09 09:49
Reporterthrowaway 
Assigned ToLeonard 
PrioritylowSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version3.1Fixed in Version3.1 
Summary0003151: Secret items boost total secret count every map reset
DescriptionEvery time you reset the map, the secret count for the map goes up by however many items marked secret were present.
Steps To Reproduce1. Set the game mode to survival.
2. Enter the map; the total secret count is currently 1.
3. Wait for the countdown to end; the total secret count will go to 2 upon the map resetting.
Additional InformationBoth items with +COUNTSECRET and UDMF secret things exhibit this bug.
TagsNo tags attached.
Relationships
Attached Files? secretbug.wad (2,774) 2017-06-03 17:50
https://zandronum.com/tracker/file_download.php?file_id=2114&type=bug
? secretbug2.wad (12,362) 2017-06-12 21:58
https://zandronum.com/tracker/file_download.php?file_id=2122&type=bug
? secretbug.lmp (2,386) 2017-10-11 23:58
https://zandronum.com/tracker/file_download.php?file_id=2217&type=bug
? secretbug2.webm (1,995,517) 2017-10-11 23:58
https://zandronum.com/tracker/file_download.php?file_id=2218&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-06-03 17:50throwawayNew Issue
2017-06-03 17:50throwawayFile Added: secretbug.wad
2017-06-05 02:12Ru5tK1ngNote Added: 0017801
2017-06-05 02:12Ru5tK1ngStatusnew => feedback
2017-06-06 22:56throwawayNote Added: 0017806
2017-06-06 22:56throwawayStatusfeedback => new
2017-06-07 00:18Ru5tK1ngNote Added: 0017807
2017-06-07 00:18Ru5tK1ngStatusnew => feedback
2017-06-12 21:58throwawayFile Added: secretbug2.wad
2017-06-12 22:00throwawayNote Added: 0017822
2017-06-12 22:00throwawayStatusfeedback => new
2017-10-09 16:03LeonardNote Added: 0018504
2017-10-09 16:03LeonardStatusnew => feedback
2017-10-11 23:58throwawayFile Added: secretbug.lmp
2017-10-11 23:58throwawayFile Added: secretbug2.webm
2017-10-12 00:00throwawayNote Added: 0018537
2017-10-12 00:00throwawayStatusfeedback => new
2017-10-12 00:01throwawayNote Edited: 0018537bug_revision_view_page.php?bugnote_id=18537#r11128
2017-10-12 19:58LeonardNote Added: 0018547
2017-10-12 19:58LeonardAssigned To => Leonard
2017-10-12 19:58LeonardStatusnew => needs review
2017-10-12 19:58LeonardTarget Version => 3.1
2017-10-14 16:26Torr SamahoNote Added: 0018557
2017-10-14 16:26Torr SamahoStatusneeds review => needs testing
2018-05-08 20:12StrikerMan780Note Added: 0019226
2018-05-09 09:49LeonardStatusneeds testing => resolved
2018-05-09 09:49LeonardResolutionopen => fixed
2018-05-09 09:49LeonardFixed in Version => 3.1

Notes
(0017801)
Ru5tK1ng   
2017-06-05 02:12   
I can't recreate the issue with r170521-1941. Perhaps you are using an older build that lacks the secret overhaul by Zelewa?
(0017806)
throwaway   
2017-06-06 22:56   
I'm using 170416-0710, the latest build on the downloads page.
(0017807)
Ru5tK1ng   
2017-06-07 00:18   
Can you try this build:'https://www.sendspace.com/file/igc4kw [^]'

It has all the changes regarding secrets in it and it's more up to date than the 4/16 build.
(0017822)
throwaway   
2017-06-12 22:00   
The issue is still occurring, but now it's inconsistent.

I uploaded a version of the map with six secret soulspheres. On map reset, the secret counter will go up by any number between 0 and 6. For me, it most often increased the secret counter by 4.
(0018504)
Leonard   
2017-10-09 16:03   
I can't reproduce this either even with your second example wad.
Assuming you can still reproduce this yourself on 3.0, could you record a demo of it?
(0018537)
throwaway   
2017-10-12 00:00   
(edited on: 2017-10-12 00:01)
I've attached both a demo of the bug (for secretbug2.wad, recorded with 170901-1140), and a webm if the demo still doesn't demonstrate the bug. Look at the secret counter on the althud; it goes up by 6 every map reset.

Incidentally, it's become consistent again, even on the build I was using originally.
(0018547)
Leonard   
2017-10-12 19:58   
Thanks!
Turns out this happens online too but you have to connect a new client to notice the issue as the server doesn't inform clients of the count change.

Link to PR.
(0018557)
Torr Samaho   
2017-10-14 16:26   
Looks good! I added your patch.
(0019226)
StrikerMan780   
2018-05-08 20:12   
I started secretbug.wad in a server with survival. Added a bot, joined, waited for the countdown, reconnected, and the secret count didn't increase.