MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003149Zandronum[All Projects] Bugpublic2017-05-30 23:092020-10-25 21:14
ReporterCatastrophe 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Statusneeds testingResolutionopen 
PlatformOSOS Version
Product Version2.1 
Target Version3.1Fixed in Version 
Summary0003149: EVENT script for return and capture don't work on Skulltag
DescriptionThis happens in both 2.1.2 and 3.0-beta.

Basically returning the skull and capturing in Skulltag doesn't seem to run the appropriate EVENT script. It works fine in CTF though.

Happens in both Singleplayer and Multiplayer.

I don't know if this is the right place to put this, but once this is fixed, could we also have arg2 of the capture EVENT to return the number of points obtained as well? Skulltag features certain scoring areas that give more than one point.

Steps To ReproduceLoad thishttp://allfearthesentinel.net/download?file=fnf-stats-r3-test4.pk3 [^]
Load any skulltag mappack; here's one for the lazy:http://allfearthesentinel.net/download?file=stcomp_b2.pk3 [^] (start at map stcomp01)

Add a bot and go ahead and grab their skull and capture it, you'll see that fnf-stats will print a debug message in the console if you pick up the enemy skull but not if you capture it.

The same can be done in CTF to see that everything works fine in that gamemode.
Additional Information
TagsNo tags attached.
Relationships
related to 0003126needs testing  GAMEEVENT_CAPTURES does not trigger when One Flag CTF flags are captured 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-05-30 23:09CatastropheNew Issue
2017-06-04 08:58Torr SamahoProduct Version3.0-beta => 2.1
2017-06-19 03:42Ru5tK1ngNote Added: 0017841
2017-06-19 03:42Ru5tK1ngStatusnew => needs review
2017-06-19 03:42Ru5tK1ngTarget Version => 3.1
2017-06-19 13:30CutmanNote Added: 0017847
2017-06-19 13:35CutmanNote Edited: 0017847bug_revision_view_page.php?bugnote_id=17847#r10699
2017-06-19 19:03Ru5tK1ngRelationship addedrelated to 0003126
2020-10-25 21:14Torr SamahoNote Added: 0021552
2020-10-25 21:14Torr SamahoStatusneeds review => needs testing

Notes
(0017841)
Ru5tK1ng   
2017-06-19 03:42   
Looking through the code it seems water didn't notice that Skulltag mode handles returns and captures in different spots than in CTF. Since 3.0 is coming out soon, I'll mark this for 3.1 and leave my fix for review for a later PR.

https://bitbucket.org/Ru5tK1ng/zandoom/commits/8cd52f40824879da9a2d94281521be8e4020a588 [^]
(0017847)
Cutman   
2017-06-19 13:30   
(edited on: 2017-06-19 13:35)
If this is a priority please do the same for the White Flag too, I believe it is also missing compatibility (issue 0003126 and maybe 0003078 )
(0021552)
Torr Samaho   
2020-10-25 21:14   
I added Kaminsky's patch for this.