MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003089Zandronum[All Projects] Suggestionpublic2017-04-24 18:122018-09-30 21:45
ReporterStrikerMan780 
Assigned ToTorr Samaho 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0003089: Backport KILL Script type (My last backport request, I swear!)
DescriptionThis is a very simple and straightforward addition, and the last piece of the puzzle I need for my mod, thus the last backport request I'll ever make for 3.0.

'https://github.com/coelckers/gzdoom/commit/c0eb8f3b9604612240956b75f3fcd9c5c38f5f13 [^]'

Kill scripts, a feature I developed myself last year, in hopes that it could make it here. I'll be using it for dynamic and universal calculation for gaining exp points from enemies. (Bases EXP gained on a combination of their health, aggression, painchance, and other factors.)
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
duplicate of 0002828closed  Backporting KILL Script Type 
Attached Files? KillScriptTest.pk3 (1,050) 2017-05-01 19:41
/tracker/file_download.php?file_id=2096&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-04-24 18:12StrikerMan780New Issue
2017-04-25 19:40Torr SamahoNote Added: 0017324
2017-04-25 19:44StrikerMan780Note Added: 0017325
2017-04-26 05:55Torr SamahoRelationship addedduplicate of 0002828
2017-04-26 05:58Torr SamahoAssigned To => Torr Samaho
2017-04-26 05:58Torr SamahoStatusnew => needs testing
2017-04-26 05:59Torr SamahoNote Added: 0017334
2017-04-26 16:46StrikerMan780Note Added: 0017345
2017-04-26 16:47StrikerMan780Note Edited: 0017345bug_revision_view_page.php?bugnote_id=17345#r10414
2017-04-26 16:47StrikerMan780Note Edited: 0017345bug_revision_view_page.php?bugnote_id=17345#r10415
2017-05-01 18:57StrikerMan780Note Added: 0017496
2017-05-01 18:59Torr SamahoNote Added: 0017498
2017-05-01 19:41StrikerMan780File Added: KillScriptTest.pk3
2017-05-01 19:42StrikerMan780Note Added: 0017501
2017-05-01 19:42StrikerMan780Note Edited: 0017501bug_revision_view_page.php?bugnote_id=17501#r10519
2017-05-07 13:05Torr SamahoNote Added: 0017576
2017-05-15 03:09Ru5tK1ngNote Added: 0017697
2017-05-15 03:09Ru5tK1ngStatusneeds testing => resolved
2017-05-15 03:09Ru5tK1ngResolutionopen => fixed
2017-05-15 03:09Ru5tK1ngFixed in Version => 3.0
2017-05-15 03:09Ru5tK1ngTarget Version => 3.0
2018-09-30 21:45Blzut3Statusresolved => closed

Notes
(0017324)
Torr Samaho   
2017-04-25 19:40   
Quote from StrikerMan780
My last backport request, I swear!

I'll take you at your word ;).

'https://bitbucket.org/Torr_Samaho/zandronum/commits/2045c167ee6615c2f8e5d095ef30ae05ed79b655 [^]'
(0017325)
StrikerMan780   
2017-04-25 19:44   
Excellent, now I can start really cleaning up a 7-year-old mess of hacky, difficult to maintain code and move forward with my project. Thank you.
(0017334)
Torr Samaho   
2017-04-26 05:59   
You're welcome! The feature sounds very useful, in particular, considering that the implementation is very non-invasive.
(0017345)
StrikerMan780   
2017-04-26 16:46   
(edited on: 2017-04-26 16:47)
Yeah, after the first iteration, which was a bit of a mess and overdesigned, I did my best to make something both simple and extremely powerful the second time around.

It seems everything works offline, I haven't started on online testing however... will report back on that.
(0017496)
StrikerMan780   
2017-05-01 18:57   
OK, tested it online extensively... and found something interesting. Online, on the first kill after a map starts, the script will execute twice. Subsequent times only executes the script once per actor as it should.
(0017498)
Torr Samaho   
2017-05-01 18:59   
Can you make a minimal example wad?
(0017501)
StrikerMan780   
2017-05-01 19:42   
PK3 attached. Found out that it's actually executing the script on both the client and server at the same time, even if it isn't a CLIENTSIDE script.
(0017576)
Torr Samaho   
2017-05-07 13:05   
Thanks! This should be fixed now.
(0017697)
Ru5tK1ng   
2017-05-15 03:09   
I tested the example wad with the fix and the script seemed to function normally.