MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003033Zandronum[All Projects] Bugpublic2017-03-10 06:112018-09-30 21:44
Reporterjdagenet 
Assigned ToTorr Samaho 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS Version10
Product Version2.1 
Target Version3.0Fixed in Version3.0 
Summary0003033: Looping clientside script loses track of activator when the actor is morphed online
DescriptionA looping clientside script will either lose track of the activator or terminate altogether (we haven't been able to verify which) if the player is morphed in an online server, not offline.
Steps To ReproduceDownload this:'https://www.sendspace.com/file/n6y233 [^]'

Host an online server with the mod.

Purchase a class through the Purchase Terminal and buy a mech at the War Factory. Note that the menu used to buy the mech will remain on the screen.

The two main files to keep in mind are a_mechs.acs and a_menu.acs.
Open a_mechs.acs and comment out lines 122-124 (these lines handle the actual mech morphing).

Right-click on aow2scrp.acs and recompile the ACS source and save the PK3. Rehost the server with the mod and retry the steps above. The menu should not remain on the screen now.
Additional InformationIt has been tested that the script SC_MENU inside the a_menu.acs file works up until the while loop under traditional circumstances. Everything after the while loop is a mystery because that is when the player is morphed.

It has been predicted that online actor morphing underwent an overhaul from 161030 to 170205 because this issue did not happen for me or Catastrophe when we were testing with 161030.

This doesn't seem to be an issue for offline play since the problem persists only when then game is online.
TagsNo tags attached.
Relationships
Attached Files? morphbug.pk3 (2,453) 2017-03-15 20:03
/tracker/file_download.php?file_id=2044&type=bug
? morphbug-minimal.wad (1,642) 2017-05-15 11:17
/tracker/file_download.php?file_id=2111&type=bug
? morphbug-minimal-fixed.wad (1,620) 2017-05-15 11:20
/tracker/file_download.php?file_id=2112&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-03-10 06:11jdagenetNew Issue
2017-03-11 19:00Torr SamahoNote Added: 0016967
2017-03-11 19:01Torr SamahoStatusnew => feedback
2017-03-15 20:03Ru5tK1ngFile Added: morphbug.pk3
2017-03-15 20:07Ru5tK1ngNote Added: 0016993
2017-04-26 17:13StrikerMan780Note Added: 0017346
2017-04-29 14:33Torr SamahoNote Added: 0017400
2017-05-15 11:16KorshunNote Added: 0017699
2017-05-15 11:17KorshunFile Added: morphbug-minimal.wad
2017-05-15 11:20KorshunFile Added: morphbug-minimal-fixed.wad
2017-05-15 11:21KorshunNote Edited: 0017699bug_revision_view_page.php?bugnote_id=17699#r10632
2017-05-15 11:25KorshunNote Edited: 0017699bug_revision_view_page.php?bugnote_id=17699#r10633
2017-05-20 11:18Torr SamahoProduct Version => 2.1
2017-05-20 13:49Torr SamahoNote Added: 0017722
2017-05-20 14:14Torr SamahoAssigned To => Torr Samaho
2017-05-20 14:14Torr SamahoStatusfeedback => needs testing
2017-05-23 01:05Ru5tK1ngNote Added: 0017738
2017-05-23 01:05Ru5tK1ngStatusneeds testing => resolved
2017-05-23 01:05Ru5tK1ngResolutionopen => fixed
2017-05-23 01:05Ru5tK1ngFixed in Version => 3.0
2017-05-23 01:05Ru5tK1ngTarget Version => 3.0
2018-09-30 21:44Blzut3Statusresolved => closed

Notes
(0016967)
Torr Samaho   
2017-03-11 19:00   
Please post a minimal example wad.
(0016993)
Ru5tK1ng   
2017-03-15 20:07   
I posted morphbug.pk3 which I think highlights what the ticket author is trying to convey.

Host a server with cheats on with morphbug.pk3.
Type Chase in console.
Fire at the button to activate the script.
When the menu pops up, type Morphme ZombiePlayer in console.

Notice how the menu disappears even though it's still active (you can't move).

When you do this offline, the menu doesn't disappear when you morph into ZombiePlayer.
(0017346)
StrikerMan780   
2017-04-26 17:13   
I can confirm, this bug plagues the special attack of one of SMMP's classes.
(0017400)
Torr Samaho   
2017-04-29 14:33   
Do 2.1.2 and 3.0 behave the same in this regard?
(0017699)
Korshun   
2017-05-15 11:16   
(edited on: 2017-05-15 11:25)
The provided example wad is not minimal enough. I made an example wad to specifically test this bug.

No scripts are stopped when the player morphs. Clientside scripts lose track of the activator if the activator player is morphed or unmorphed, but only in online games.

The bug is the same in 2.1.2 and 3.0.

EDIT: I fixed a slight display bug in the example wad, making it usable in singleplayer too.
(0017722)
Torr Samaho   
2017-05-20 13:49   
Thanks for the example wad! Should be fixed now.
(0017738)
Ru5tK1ng   
2017-05-23 01:05   
I tested the fix online and it seems all the issues from all the posted wads are now fixed.