MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002943Zandronum[All Projects] Bugpublic2016-12-03 13:002018-09-30 21:44
ReporterLance 
Assigned ToZalewa 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002943: Secrets attainable through coop spy
DescriptionIf you're to coop spy someone while in or about to enter a secret sector, it will count the secret found on your client, even if you've not actually been there
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
duplicate of 0002425closed Zalewa Automap's secrets counter gets incremented even when someone else discovers the secret in multiplayer game. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-03 13:00LanceNew Issue
2016-12-03 14:20ZalewaRelationship addedduplicate of 0002425
2016-12-18 14:53ZalewaAssigned To => Zalewa
2016-12-18 14:53ZalewaStatusnew => assigned
2016-12-18 16:15ZalewaNote Added: 0016526
2016-12-18 16:15ZalewaStatusassigned => needs review
2017-05-17 16:58ZalewaNote Added: 0017704
2017-05-17 16:58ZalewaNote Edited: 0017704bug_revision_view_page.php?bugnote_id=17704#r10635
2017-05-17 16:58ZalewaNote Edited: 0017704bug_revision_view_page.php?bugnote_id=17704#r10636
2017-05-20 11:15Torr SamahoStatusneeds review => needs testing
2017-05-23 02:13Ru5tK1ngNote Added: 0017745
2017-05-23 02:13Ru5tK1ngStatusneeds testing => resolved
2017-05-23 02:13Ru5tK1ngResolutionopen => fixed
2017-05-23 02:13Ru5tK1ngProduct Version => 3.0-beta
2017-05-23 02:13Ru5tK1ngFixed in Version => 3.0
2017-05-23 02:13Ru5tK1ngTarget Version => 3.0
2018-09-30 21:44Blzut3Statusresolved => closed

Notes
(0016526)
Zalewa   
2016-12-18 16:15   
Indirectly fixed by this pull request:
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/178/fixed-problems-with-secrets-clientside/ [^]' [^]

In multiplayer, players will be informed through the chat area about the secret being discovered by a player, and also the global discovered secrets counter seems to be the correct behavior.
(0017704)
Zalewa   
2017-05-17 16:58   
Eventually, we fixed this differently. As Torr suggested, I altered the code to match ZDoom behavior. Now if another player discovers the secret, it will be discovered for you no matter if you are spectating this other player or not. You will of course be only directly notified if you spectate, and the message in the chat area was removed in the end. Moreover, and strangely, ZDoom also marks secrets as discovered if enemy in deathmatch discovers it, so Zandronum will do this as well.
(0017745)
Ru5tK1ng   
2017-05-23 02:13   
Seems to update properly when coopspying as a player in game or as a spectator. Everything seems to update for new clients as well.