MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002931Zandronum[All Projects] Bugpublic2016-11-23 10:382018-09-30 21:43
ReporterDusk 
Assigned ToTorr Samaho 
PrioritynormalSeveritytweakReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002931: SERVER_Tick ticks all clients packet buffers, whether valid or not
DescriptionI was playing with my client iterator stuff again and encountered this in SERVER_Tick:


        // [BB] Send out sheduled packets, respecting sv_maxpacketspertick.
        for ( ulIdx = 0; ulIdx < MAXPLAYERS; ulIdx++ )
            SERVER_GetClient ( ulIdx )->SavedPackets.Tick ( );


This code ticks all SavedPackets buffers, even of non-connected clients. Is this intended?
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0001469needs testing Torr Samaho Problem connecting to slaughtermaps 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-11-23 10:38DuskNew Issue
2016-11-27 16:00Torr SamahoNote Added: 0016353
2016-11-27 16:00Torr SamahoStatusnew => feedback
2016-12-24 22:42DuskTarget Version => 3.0
2017-04-08 12:34Torr SamahoNote Added: 0017097
2017-04-08 12:34Torr SamahoAssigned To => Torr Samaho
2017-04-08 12:34Torr SamahoStatusfeedback => needs testing
2017-04-19 23:29MarcaekNote Added: 0017235
2017-04-20 06:02Torr SamahoNote Added: 0017240
2017-04-20 06:02Torr SamahoNote Edited: 0017240bug_revision_view_page.php?bugnote_id=17240#r10369
2017-04-20 06:03Torr SamahoRelationship addedrelated to 0001469
2017-06-21 03:43CombinebobntNote Added: 0017861
2017-06-21 03:47Ru5tK1ngStatusneeds testing => resolved
2017-06-21 03:47Ru5tK1ngResolutionopen => fixed
2017-06-21 03:47Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:43Blzut3Statusresolved => closed

Notes
(0016353)
Torr Samaho   
2016-11-27 16:00   
I kept the code as simple as possible. SavedPackets.Tick() does nothing when the buffers are empty, which is the case when there is no client in the corresponding slot. If you'd like to replace the loop with an iterator over the connected clients, that should be fine.
(0017097)
Torr Samaho   
2017-04-08 12:34   
I went ahead and made the loop skip invalid clients.
(0017235)
Marcaek   
2017-04-19 23:29   
Is there any way for us code-illiterates to test this out? I don't understand the issue well enough the way it's worded.
(0017240)
Torr Samaho   
2017-04-20 06:02   
Testing whether the maps / situations from 0001469 still work better in 3.0 than they do in 2.1.2 should be sufficient.
(0017861)
Combinebobnt   
2017-06-21 03:43   
ok yea i tested. maybe i only ever played sod map32 in rga2 or something, I could remain connected in 2.1.2. However there was very noticeable jitter and lag besides my normal; the 3.0 playthrough was way better.

but thats not enough. I ran through some dark tartarus tests with some laggy gameplay wads and I was able to get heavy lag and a lag-out (finally) in 2.1.2. None of that in 3.0. Was pretty smooth in 3.0 actually.