MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002900Zandronum[All Projects] Bugpublic2016-10-17 19:102018-09-30 21:49
ReporterFused 
Assigned ToEdward-san 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002900: ACS_ExecuteWithResult does not send its fourth argument with clientsided scripts online
DescriptionThe bug is supposedly caused here:'https://bitbucket.org/Torr_Samaho/zandronum/src/2e635dceb3ceafc40b9df431bb049359e59b3298/src/p_lnspec.cpp?at=default&fileviewer=file-view-default#p_lnspec.cpp-1844 [^]'
Steps To Reproduce
Additional Informationoffline:'https://i.imgur.com/FcjWJjF.png [^]'
online:'https://i.imgur.com/671PjQR.png [^]'
'http://allfearthesentinel.net/download?file=findingarg4themovie.wad [^]' example wad
TagsNo tags attached.
Relationships
Attached Files? findingarg4themovie.wad (1,841) 2016-10-17 19:16
/tracker/file_download.php?file_id=1955&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-10-17 19:10FusedNew Issue
2016-10-17 19:16WaTaKiDFile Added: findingarg4themovie.wad
2016-10-17 20:27Edward-sanAssigned To => Edward-san
2016-10-17 20:27Edward-sanStatusnew => assigned
2016-10-17 20:36Edward-sanNote Added: 0016040
2016-10-17 20:36Edward-sanStatusassigned => feedback
2016-10-17 21:04WaTaKiDNote Added: 0016042
2016-10-17 21:29FusedNote Added: 0016043
2016-10-17 21:29FusedStatusfeedback => assigned
2016-10-18 11:03Edward-sanNote Added: 0016045
2016-10-18 11:03Edward-sanStatusassigned => feedback
2016-10-19 16:25unknownnaNote Added: 0016060
2016-10-19 16:55Edward-sanNote Added: 0016061
2016-10-19 16:56Edward-sanNote Edited: 0016061bug_revision_view_page.php?bugnote_id=16061#r9794
2016-10-19 17:13unknownnaNote Added: 0016062
2016-11-26 09:36Edward-sanNote Added: 0016322
2016-11-26 09:36Edward-sanStatusfeedback => needs review
2016-11-27 15:52Torr SamahoNote Added: 0016352
2016-11-27 15:52Torr SamahoNote Edited: 0016352bug_revision_view_page.php?bugnote_id=16352#r9919
2016-11-27 15:52Torr SamahoStatusneeds review => feedback
2016-11-27 20:05Edward-sanNote Added: 0016369
2016-11-27 20:05Edward-sanStatusfeedback => needs review
2016-11-29 20:18Torr SamahoNote Added: 0016375
2016-11-29 20:18Torr SamahoStatusneeds review => needs testing
2016-11-29 20:18Torr SamahoTarget Version => 3.0
2016-12-17 02:18CombinebobntNote Added: 0016513
2017-02-06 18:59DuskStatusneeds testing => resolved
2017-02-06 18:59DuskFixed in Version => 3.0
2017-02-06 18:59DuskResolutionopen => fixed
2018-09-30 21:49Blzut3Statusresolved => closed

Notes
(0016040)
Edward-san   
2016-10-17 20:36   
'https://bitbucket.org/zandronum/zandronum-sandbox/commits/6eba389681dfdebbde41ff2ee5f0bec746af9c9f [^]' should handle this. Please check that this doesn't break anything ACS-heavy.
(0016042)
WaTaKiD   
2016-10-17 21:04   
this 3.0 build contains the above commit: 'https://www.dropbox.com/s/mepvpztquokwoq1/zandronum-3.0-r161017-2033-6eba389-windows.zip?dl=0 [^]'
(0016043)
Fused   
2016-10-17 21:29   
The above build fixes the problem.
(0016045)
Edward-san   
2016-10-18 11:03   
Sure, but we have some time before adding it, so it would be appreciated if this was tested on mods with a lot of ACS scripts.
(0016060)
unknownna   
2016-10-19 16:25   
I tested some Complex Doom/LCA with that build and found one odd server crash with hpbar-v15.pk3 + h_phobia.wad on MAP11 if a bot is present before the changemap map change.

1. zandronum -host -iwad doom2.wad -file h_phobia.wad hpbar-v15.pk3
2. "addbot" in the server console.
3. "changemap map11" in the server console.
4. zandronum -iwad doom2.wad -file h_phobia.wad hpbar-v15.pk3 -connect localhost
(0016061)
Edward-san   
2016-10-19 16:55   
(edited on: 2016-10-19 16:56)
I get the crash also without my fix (its parent changeset is'https://bitbucket.org/zandronum/zandronum-sandbox/commits/2e635dceb3ceafc40b9df431bb049359e59b3298 [^]' ).
(0016062)
unknownna   
2016-10-19 17:13   
So when did it break? I have a 161017-0733 build and it doesn't crash there. I'll make a new ticket so we can figure it out there.
(0016322)
Edward-san   
2016-11-26 09:36   
The bug reported in comment 0002900:0016060 was reported in ticket 0002904 and fixed, so no other issues appear to block this. For better coverage, I rebased the fix to the tip with this changeset:'https://bitbucket.org/zandronum/zandronum-sandbox/commits/36a445390c87516f5398e7ad0aa315b24ccaf2d7 [^]' so a new build is required.
(0016352)
Torr Samaho   
2016-11-27 15:52   
I left some notes on bitbucket.
(0016369)
Edward-san   
2016-11-27 20:05   
Ok, how about'https://bitbucket.org/zandronum/zandronum-sandbox/commits/eece5f0a24f3db78aef813cbf9187d7e8e8d55c3 [^]' ?
(0016375)
Torr Samaho   
2016-11-29 20:18   
Looks good! Added.
(0016513)
Combinebobnt   
2016-12-17 02:18   
tested in a lan server, got:
101 102 103 104
201 202 203 204, etc.

so i guess it works