MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000290Zandronum[All Projects] Bugpublic2011-02-13 08:162013-04-10 23:19
ReporterDevilHunter 
Assigned To 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionunable to reproduce 
PlatformLinuxOSUbuntuOS Version10.04 x86-64
Product Version98d 
Target VersionFixed in Version 
Summary0000290: addban does not work correctly in Linux 64 bit Servers
DescriptionAs said in the Title, when you type "addban ip perm reason" it will only add the :reason part into the banlist file. I think C knows why..

[01:56:31] [@c] uint32 is always 32 bits wide
[01:56:39] [@c] int is the native word size
[01:56:49] [@c] which is, on 64 bit systems, 64 bits, naturally
[01:57:10] [@c] IPv4 addresses are 32 bits long, so they can easily fir in a uint32
[01:57:44] [@c] Of course, the function which flushes the ban to disk (or processes the ban, or anything along the way)
[01:58:03] [@c] might fall flat on its face when it sees a 64 bit integer, and only read the LAST bits which could contain random garbage, or zero.
Steps To Reproduce1. Grab Linux base and 64 binarys
2. Setup and Run a Server with said stuff above.
3. Try adding a ban the normal way. (timed bans are the same way)
4. Look at your banlist file. It will say ":reason"
Additional InformationI like to point out, this happens with Votekicks, Client Info Floods.. Just about any kind of Ban is bugged.
TagsNo tags attached.
Relationships
Attached Filespng linux64bitserverbug.PNG (58,391) 2011-02-14 03:00
/tracker/file_download.php?file_id=156&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-02-13 08:16DevilHunterNew Issue
2011-02-13 12:19Torr SamahoNote Added: 0001059
2011-02-13 13:45Torr SamahoNote Added: 0001060
2011-02-13 13:45Torr SamahoStatusnew => feedback
2011-02-13 22:54DevilHunterNote Added: 0001076
2011-02-13 22:54DevilHunterStatusfeedback => new
2011-02-14 01:50Blzut3Note Added: 0001078
2011-02-14 03:00DevilHunterFile Added: linux64bitserverbug.PNG
2011-02-14 03:00DevilHunterNote Added: 0001079
2011-02-14 12:56Torr SamahoNote Added: 0001082
2011-02-14 12:57Torr SamahoStatusnew => feedback
2011-02-15 03:50DevilHunterNote Added: 0001090
2011-02-15 03:50DevilHunterStatusfeedback => new
2011-02-16 03:06Torr SamahoNote Added: 0001095
2011-02-16 03:07Torr SamahoNote Edited: 0001095bug_revision_view_page.php?bugnote_id=1095#r551
2011-02-16 03:07Torr SamahoStatusnew => feedback
2011-02-16 19:40DevilHunterNote Added: 0001096
2011-02-16 19:40DevilHunterStatusfeedback => new
2011-02-21 00:23Torr SamahoNote Added: 0001111
2011-03-13 08:16DevilHunterNote Added: 0001153
2011-03-27 00:09Torr SamahoNote Added: 0001187
2011-03-27 00:11Torr SamahoNote Edited: 0001187bug_revision_view_page.php?bugnote_id=1187#r607
2011-03-27 00:12Torr SamahoNote Edited: 0001187bug_revision_view_page.php?bugnote_id=1187#r608
2011-03-27 00:12Torr SamahoStatusnew => feedback
2011-04-13 22:28DevilHunterNote Added: 0001361
2011-04-13 22:28DevilHunterStatusfeedback => new
2011-04-13 23:12Torr SamahoNote Added: 0001362
2012-02-15 22:13DevilHunterNote Added: 0002608
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2013-04-08 04:11DevilHunterNote Added: 0006271
2013-04-10 23:19Blzut3Statusnew => closed
2013-04-10 23:19Blzut3Resolutionopen => unable to reproduce

Notes
(0001059)
Torr Samaho   
2011-02-13 12:19   
Well, to quote yourself from the corresponding forum thread:

"well i just tried the 32 bit binary, no difference, still omits the damn ip address. I looked in the rcon after i set the ban, it shows only "addban ip perm" after I type it in, so it seems to not add the reason in it."

If the 32bit binaries don't work for you, I don't see how this could be a problem with 64 bit.
(0001060)
Torr Samaho   
2011-02-13 13:45   
I just tested this under FreeBSD 8.1 64bit and everything works fine there. So whatever problem you are having, it doesn't seem to have anything to do with 64 bit.
(0001076)
DevilHunter   
2011-02-13 22:54   
We are using the Linux Binarys btw. It only happens in the 64 bit binarys, even Konar6 has the same issue.
(0001078)
Blzut3   
2011-02-14 01:50   
Works for me
1.2.3.4<02/23/2011 20:49>:heh
1.2.3.5:worksforme
(0001079)
DevilHunter   
2011-02-14 03:00   
Well, it don't for me, I did it as shown in the screenshot I attached.
(0001082)
Torr Samaho   
2011-02-14 12:56   
The screenshot shows that the ban command is properly parsed and that the IP is added to the list. Wait seems to fail is the appending of the ban to the file. I'd assume that the ban works properly till the banfile is reparsed. Do the bans work properly if you don't restart the server and set sv_banfilereparsetime to 0?
(0001090)
DevilHunter   
2011-02-15 03:50   
I tried this on a Server that hasn't been restarted, same thing.. just adds :reason like before.
(0001095)
Torr Samaho   
2011-02-16 03:06   
(edited on: 2011-02-16 03:07)
No, I didn't mean to check the banfile if sv_banfilereparsetime is 0, but to check if the bans work properly in case the banfile is never read. In other words, if you call addban, is the corresponding IP kicked and prevented from rejoining?
(0001096)
DevilHunter   
2011-02-16 19:40   
Oh, Well no it is not. When the Ip gets kicked, it can rejoin instantly, thus the ban is never read by the server, simply cuse it never logs the ip into the banfile
(0001111)
Torr Samaho   
2011-02-21 00:23   
> Oh, Well no it is not. When the Ip gets kicked, it can rejoin instantly, thus the ban is never read by the server, simply cuse it never logs the ip into the banfile

The completely contradicts what Konar6 is reporting in the forum thread:'http://www.skulltag.com/forum/viewtopic.php?p=353882#p353882 [^]'
(0001153)
DevilHunter   
2011-03-13 08:16   
Well, I have no other clue of whats going on.. It just seems its only Armada having this issue, unless Konar is still using the same thing we are. i guess this will never get fixed.
(0001187)
Torr Samaho   
2011-03-27 00:09   
(edited on: 2011-03-27 00:12)
According to Konar6 this is not a Skulltag bug, but a problem with the system:'http://www.skulltag.com/forum/viewtopic.php?p=354336#p354336 [^]'

And I fully agree with this: If your system doesn't support file append operations, something is horribly wrong with it. I suggest asking about this at your Linux distro's forum.
(0001361)
DevilHunter   
2011-04-13 22:28   
Ok well, even after reinstalling to Fendora Linux, it still bugs out.. I wonder, if either Torr or Blzut3 could come on the Armada server and see if you can fix it.

I have tried everything, and cost c and Cyber there time, getting this OS reinstall, only to find out, that even that did not fix the issue, so it cannot be the OS we were on before.

I have a feeling we might have to go to 32 bit in order to have addban and votekicks and such to work right.
(0001362)
Torr Samaho   
2011-04-13 23:12   
Does the logging Konar6 describes here work for you? If not, something is wrong with your system.

> I have a feeling we might have to go to 32 bit in order to have addban and votekicks and such to work right.

You told earlier that the 32bit binaries do the same thing.
(0002608)
DevilHunter   
2012-02-15 22:13   
I know I havnt posted on this topic in awhile. For now, I have no net at my house, so I can't test this out any further till i get net back, witch will be awhile.
(0006271)
DevilHunter   
2013-04-08 04:11   
Welp, sorry for Bumping this but.. You can go ahead and close this. I can't figure out the reason as to why this happens, and yet nobody else has this problem.. Not worth worrying about it anymore, since I can ban the Ip, but have to go in by hand, and add the reason to the ban.