MantisBT - Zandronum
View Issue Details
0002899Zandronum[All Projects] Bugpublic2016-10-16 10:562018-09-30 21:55
unknownna 
Dusk 
normaltextalways
closedfixed 
3.0-beta 
3.03.0 
0002899: Spectating string doesn't show line number when coop spying in 3.0
See summary and attached screenshot. The green spectator message is not updated in 3.0 when you join the queue.
Additionally, the "Your position in line is: x" message isn't displayed if you join the game again after initially joining the queue in 3.0.
No tags attached.
png 3.0vs2.1.2.png (178,725) 2016-10-16 10:56
/tracker/file_download.php?file_id=1952&type=bug
png

png Screenshot_Doom_20161017_161435.png (54,631) 2016-10-17 14:16
/tracker/file_download.php?file_id=1954&type=bug
png
Issue History
2016-10-16 10:56unknownnaNew Issue
2016-10-16 10:56unknownnaFile Added: 3.0vs2.1.2.png
2016-10-16 14:50unknownnaNote Added: 0016021
2016-10-16 14:51unknownnaSummarySpectating string doesn't show line number in 3.0 => Spectating string doesn't show line number when coop spying in 3.0
2016-10-16 14:53unknownnaNote Edited: 0016021bug_revision_view_page.php?bugnote_id=16021#r9771
2016-10-17 13:58Edward-sanNote Added: 0016031
2016-10-17 13:59Edward-sanStatusnew => feedback
2016-10-17 14:04Edward-sanNote Added: 0016032
2016-10-17 14:16unknownnaFile Added: Screenshot_Doom_20161017_161435.png
2016-10-17 14:17unknownnaNote Added: 0016033
2016-10-17 14:17unknownnaStatusfeedback => new
2016-10-17 16:18Edward-sanNote Added: 0016036
2016-10-17 16:19Edward-sanStatusnew => feedback
2016-10-17 16:24Edward-sanNote Edited: 0016036bug_revision_view_page.php?bugnote_id=16036#r9777
2016-10-17 16:45unknownnaNote Added: 0016037
2016-10-17 16:45unknownnaStatusfeedback => new
2016-10-17 18:10Edward-sanStatusnew => feedback
2016-10-17 20:02WaTaKiDNote Added: 0016038
2016-10-17 20:10DuskAssigned To => Dusk
2016-10-17 20:10DuskStatusfeedback => assigned
2016-10-17 20:20DuskNote Added: 0016039
2016-10-17 20:20DuskStatusassigned => needs review
2016-11-21 07:02Torr SamahoNote Added: 0016235
2016-11-21 07:02Torr SamahoStatusneeds review => needs testing
2016-11-21 07:03Torr SamahoTarget Version => 3.0
2016-12-08 04:02Ru5tK1ngNote Added: 0016447
2016-12-08 04:02Ru5tK1ngStatusneeds testing => resolved
2016-12-08 04:02Ru5tK1ngResolutionopen => fixed
2016-12-08 04:02Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:55Blzut3Statusresolved => closed

Notes
(0016021)
unknownna   
2016-10-16 14:50   
(edited on: 2016-10-16 14:53)
Actually, the spectator message is updated, but is broken if coop spying.

(0016031)
Edward-san   
2016-10-17 13:58   
Quote
Additionally, the "Your position in line is: x" message isn't displayed if you join the game again after initially joining the queue in 3.0.


Can you elaborate?
(0016032)
Edward-san   
2016-10-17 14:04   
I'd like to know also which beta regressed.
(0016033)
unknownna   
2016-10-17 14:17   
The message in the upper left of the screen isn't repeated when you select "join game" through the menu after having joined once already. I attached a screenshot to show you how it worked before.

It started to break in 151228-1140.
(0016036)
Edward-san   
2016-10-17 16:18   
(edited on: 2016-10-17 16:24)
Quote from unknownna
Actually, the spectator message is updated, but is broken if coop spying.


I'd like to see this bisected, because actually I have a patch which works but the piece of code I change was always present since old times, hence it's not clear what exactly changed.

(0016037)
unknownna   
2016-10-17 16:45   
If it helps, here's what I found in the changelog for that build regarding line queues. There were a lot of changes:

* 9381:c801abda95a7 : Made the join queue TArray-based
* 9382:c5bf89850ea2 : Remove use of hungarian notation and LONG/ULONG in join queue code
* 9383:4b5ba1fea3e5 : Renamed JOINSLOT_t to JoinSlot and made it private
* 9384:92a3264f3984 : Join queue is now synchronized to clients in full.
* 9385:f6f2087ded57 : Render the join queue position on the scoreboard (addresses 1028)
* 9386:9d7a137168e7 : Handle the "your position in line is: #" message on the client side now that we can. (Perhaps this one for the message on the upper left.)
* 9388:cd1886c2eaa6 : Store JOINQUEUE_AddPlayer parameters as local variables or the bytestream will be read incorrectly on Windows
(0016038)
WaTaKiD   
2016-10-17 20:02   
ok so heres wut i got:
from
'https://bitbucket.org/Torr_Samaho/zandronum/commits/92a3264f3984218f6663229420695f7f4eaeac34 [^]'

to
'https://bitbucket.org/Torr_Samaho/zandronum/commits/5254b2c231e39c79daeda442bf5951953e6049d4 [^]'

the "spectating - space to join" message shows, regardless if f12ing or in queue
"waiting to play" doesnt show at all
the top left "your position" message doesnt show at all

however, starting with
'https://bitbucket.org/Torr_Samaho/zandronum/commits/cd1886c2eaa6f6c1ff7fb039d4e9c3e9db0d7342 [^]'

the "spectating - space to join" message shows if im f12ing and in queue
"waiting to play" shows if i dont f12 and am in queue
the top left "your position" message shows only once, when first entering the queue, instead of every time i try to join it
(0016039)
Dusk   
2016-10-17 20:20   
Fixed
(0016235)
Torr Samaho   
2016-11-21 07:02   
I added this a while ago.
(0016447)
Ru5tK1ng   
2016-12-08 04:02   
Works fine now even after spectating and rejoining the queue.