MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002886Zandronum[All Projects] Bugpublic2016-10-12 02:092018-09-30 21:50
Reporterunknownna 
Assigned ToEdward-san 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002886: Temporary team starts (team selection rooms) are slightly bugged in 3.0
DescriptionTeam selection rooms no longer work properly in 3.0 for players that join the game from being a spectator. When joining they're automatically put on a team. It only works properly if you manually use the join command. It does seem to work however after changemap map changes.
Steps To Reproduce1. zandronum -iwad doom2.wad -file teamroom.wad +ctf 1 +map map01
2. "spectate" in the console.
3. Join the game with the menu. It'll put you on a team instead of a temporary team start.
Additional InformationIt might have something to do with the new menu code.
TagsNo tags attached.
Relationships
Attached Files? teamroom.wad (2,897) 2016-10-12 02:09
/tracker/file_download.php?file_id=1936&type=bug
? teamroom-ticket2886.wad (3,940) 2016-10-17 00:29
/tracker/file_download.php?file_id=1953&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-10-12 02:09unknownnaNew Issue
2016-10-12 02:09unknownnaFile Added: teamroom.wad
2016-10-12 07:38WaTaKiDNote Added: 0015916
2016-10-12 11:16Edward-sanNote Added: 0015920
2016-10-12 11:16Edward-sanAssigned To => Edward-san
2016-10-12 11:16Edward-sanStatusnew => feedback
2016-10-12 11:16Edward-sanNote Edited: 0015920bug_revision_view_page.php?bugnote_id=15920#r9691
2016-10-12 16:00WaTaKiDNote Added: 0015922
2016-10-12 16:23Edward-sanNote Added: 0015923
2016-10-12 19:20WaTaKiDNote Added: 0015929
2016-10-12 19:21WaTaKiDNote Edited: 0015929bug_revision_view_page.php?bugnote_id=15929#r9693
2016-10-12 19:29WaTaKiDNote Edited: 0015929bug_revision_view_page.php?bugnote_id=15929#r9694
2016-10-15 13:27Edward-sanStatusfeedback => needs review
2016-10-15 13:37unknownnaNote Added: 0016014
2016-10-15 13:39unknownnaNote Edited: 0016014bug_revision_view_page.php?bugnote_id=16014#r9765
2016-10-16 16:37Torr SamahoNote Added: 0016025
2016-10-16 16:37Torr SamahoStatusneeds review => feedback
2016-10-16 16:38Torr SamahoNote Edited: 0016025bug_revision_view_page.php?bugnote_id=16025#r9773
2016-10-16 16:38Torr SamahoNote Revision Dropped: 16025: 0009772
2016-10-17 00:29WaTaKiDFile Added: teamroom-ticket2886.wad
2016-10-17 00:31WaTaKiDNote Added: 0016029
2016-10-17 07:43Edward-sanNote Added: 0016030
2016-10-17 14:33unknownnaNote Added: 0016034
2016-10-17 14:33unknownnaStatusfeedback => assigned
2016-10-17 15:51WaTaKiDNote Added: 0016035
2016-10-17 16:18WaTaKiDNote Edited: 0016035bug_revision_view_page.php?bugnote_id=16035#r9775
2016-10-17 20:45Edward-sanNote Added: 0016041
2016-10-17 20:45Edward-sanStatusassigned => needs review
2016-10-23 14:28Edward-sanNote Added: 0016082
2016-10-23 14:28Edward-sanStatusneeds review => needs testing
2016-12-24 22:42DuskTarget Version => 3.0
2017-01-26 21:28Ru5tK1ngNote Added: 0016699
2017-01-26 21:28Ru5tK1ngStatusneeds testing => resolved
2017-01-26 21:28Ru5tK1ngResolutionopen => fixed
2017-01-26 21:28Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:50Blzut3Statusresolved => closed

Notes
(0015916)
WaTaKiD   
2016-10-12 07:38   
this has been difficult to bisect, even after learning about these temporary team starts

my current problem is that i dont know how to open the join menu using the console in 2.1.2 or pre 3.0 menudef rework ('https://bitbucket.org/Torr_Samaho/zandronum/commits/e63da33115b7bce6079ee3312fc6b84599f6c3fb [^]' )

the example wad works just fine in 2.1.2, but in 3.0, i can only go as far back as the commit i just linked and open the non team join menu by calling 'openmenu za_joinmenu' so that i can try and reproduce the issue

so far the best i have to offer is that the join menu is acting up either because of the menudef rework, or its something else between that and 2.0
(0015920)
Edward-san   
2016-10-12 11:16   
Can you check if this changeset fixes the issue and also if it works with multiple classes?
(0015922)
WaTaKiD   
2016-10-12 16:00   
this build contains Edward-san's commit: 'https://www.dropbox.com/s/0501yvxteozbvce/zandronum-3.0-r161012-1111-6300391-windows.zip?dl=0 [^]'

after testing it with teamroom.wad and then teamroom.wad + samsara-v0.3.pk3, joining with the menu with and without classes seems to work correctly both offline and online, as im placed on no team (after choosing a class, if present), instead of a team

i even threw in some random reconnect/map/changemap and still seems fine
(0015923)
Edward-san   
2016-10-12 16:23   
I'd like to know also if team-specific classes work fine, too.
(0015929)
WaTaKiD   
2016-10-12 19:20   
(edited on: 2016-10-12 19:29)
if i load teamroom.wad + samsara-v0.3.pk3 + samsara-naraka-v0.13b.pk3 on a server

the join menu only lists the classes from the heroes team (blue team) + random
if i choose a hero class (blue team) (doomguy, chexwarrior, corvus, blazkowicz, parias, duke, securityofficer, or ranger), stepping on the left platform will change my class to cyberdemon and my team to red
if i choose a villain class (using playerclass and join in console) (red team) (cyberdemon, dsparil, hitler, korax, or tfear), stepping on the right platform will change my class to doomguy and my team to blue
if i choose random then regardless of which class it gives me or which platform i step on, my class doesnt change, only my team
no matter which class i choose when joining, im always put into 'no team' first

on a 2.1.2 server with the same wads:
everything is the same except the join menu lists all classes from both teams + random, instead of only blue team classes + random

i dont know if theres maybe a zan error or the mod just isnt built for team selection rooms, or wut
(0016014)
unknownna   
2016-10-15 13:37   
(edited on: 2016-10-15 13:39)
Quote from WaTaKiD
on a 2.1.2 server with the same wads:
everything is the same except the join menu lists all classes from both teams + random, instead of only blue team classes + random

If this doesn't also happen in 3.0, then it sounds like a bug to me since the temporary team starts are teamless, so to speak, and should be able to select all classes before joining.
(0016025)
Torr Samaho   
2016-10-16 16:37   
(edited on: 2016-10-16 16:38)
Quote from WaTaKiD
on a 2.1.2 server with the same wads:
everything is the same except the join menu lists all classes from both teams + random, instead of only blue team classes + random

3.0 should behave the same. If it doesn't, the patch is not complete yet.
(0016029)
WaTaKiD   
2016-10-17 00:31   
i have uploaded teamroom-ticket2886.wad which combines teamroom.wad with 2 teams that each have 2 classes limited to them, along with a 5th class that isnt limited to either team, for good measure

my testing results with it exactly match that of my previous note here:'http://zandronum.com/tracker/view.php?id=2886#c15929 [^]'

except: the class that isnt limited to a team shares the same behavior as choosing 'random'

also, i didnt mention this before, but 'random' and the class that isnt team limited dont actually respawn on a team's player starts upon stepping on either platform
so in the event that the team selection room is cut off from the rest of the map, these 2 class choices would be rendered useless
(0016030)
Edward-san   
2016-10-17 07:43   
Quote from WaTaKiD
everything is the same except the join menu lists all classes from both teams + random, instead of only blue team classes + random


Should be fixed with this pull request:'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/155/fixed-joining-into-temporary-team-spawns/diff [^]' .

Quote from WaTaKiD

except: the class that isnt limited to a team shares the same behavior as choosing 'random'

also, i didnt mention this before, but 'random' and the class that isnt team limited dont actually respawn on a team's player starts upon stepping on either platform
so in the event that the team selection room is cut off from the rest of the map, these 2 class choices would be rendered useless


Are you sure this doesn't happen already in 2.1.2?
(0016034)
unknownna   
2016-10-17 14:33   
I didn't test the new example wad yet, but I assume that Player_SetTeam wasn't designed with team-restricted classes in mind, hence why it's bugged when you select a team. Once the regressions here are fixed, the remaining class issues should go to their own ticket I'd say. Feel free to make the ticket(s), WaTaKiD, as you've seemed to notice the patterns at play here.
(0016035)
WaTaKiD   
2016-10-17 15:51   
(edited on: 2016-10-17 16:18)
this 3.0 build contains the above commit: 'https://www.dropbox.com/s/q1dnfpawkb5zpo8/zandronum-3.0-r161017-0733-2b56490-windows.zip?dl=0 [^]'

"Are you sure this doesn't happen already in 2.1.2?"

it does happen in 2.1.2 and 3.0, sorry for not making that clear


using the build i just linked, the join menu now lists all available classes + random, and choosing any of them places me on 'no team' and on a temporary start (same as 2.1.2)

and y'know, now that i finally mentioned: "'random' and the class that isnt team limited dont actually respawn on a team's player starts upon stepping on either platform"

it sunk in that this also happens with team limited classes if you step on their own platform, so essentially you'd have to for example pick a blue class in order to properly spawn on the red team when stepping on the red platform

so yea i can make a separate ticket for that

edit: if im understanding'http://zandronum.com/tracker/view.php?id=1673#c9894 [^]' correctly, then the "classes not respawning on their own team starts" is actually intended behavior?
(0016041)
Edward-san   
2016-10-17 20:45   
Thanks for checking! It seems that there are no other 3.0 regressions, so I'll put it on review.
(0016082)
Edward-san   
2016-10-23 14:28   
Added to 3.0 upstream with this changeset:'https://bitbucket.org/Torr_Samaho/zandronum/commits/7b9f0f4617262d6bdaab58be8ae0de4ae993ebe3 [^]'
(0016699)
Ru5tK1ng   
2017-01-26 21:28   
Tested with r170122 and the behavior I had with the testwad mirrors Watakid's results.