MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002876Zandronum[All Projects] Bugpublic2016-10-09 23:212017-03-19 11:48
Reporterunknownna 
Assigned To 
PrioritylowSeverityfeatureReproducibilityalways
StatusclosedResolutionwon't fix 
PlatformOSOS Version
Product Version3.0-beta 
Target Version3.0Fixed in Version 
Summary0002876: Sector light mode and fog mode are completely broken in the OpenGL options menu in 3.0
DescriptionSee attached screenshot. Toggling these is completely broken currently. It's also broken in GZDoom 1.8.6, but is fixed in a GZDoom SVN build that I have. I didn't check which GZDoom version fixed the issue yet.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screenshot.png (67,392) 2016-10-09 23:21
/tracker/file_download.php?file_id=1926&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-10-09 23:21unknownnaNew Issue
2016-10-09 23:21unknownnaFile Added: Screenshot.png
2016-10-09 23:22unknownnaSummarySector light mode and fog mode are completely broken in the OpenGL options menu => Sector light mode and fog mode are completely broken in the OpenGL options menu in 3.0
2016-10-09 23:26unknownnaNote Added: 0015872
2016-10-10 07:11Edward-sanNote Added: 0015880
2016-10-10 07:12Edward-sanStatusnew => feedback
2016-10-10 07:21unknownnaNote Added: 0015881
2016-10-10 07:21unknownnaStatusfeedback => new
2016-10-10 07:32Edward-sanNote Added: 0015882
2016-10-10 07:32Edward-sanStatusnew => feedback
2016-10-10 07:34Edward-sanNote Edited: 0015882bug_revision_view_page.php?bugnote_id=15882#r9659
2016-10-10 07:39unknownnaNote Added: 0015883
2016-10-10 07:39unknownnaStatusfeedback => new
2016-10-10 07:40unknownnaNote Edited: 0015883bug_revision_view_page.php?bugnote_id=15883#r9661
2016-10-10 08:31Edward-sanNote Added: 0015884
2016-10-10 08:33Edward-sanNote Edited: 0015884bug_revision_view_page.php?bugnote_id=15884#r9663
2016-11-27 16:29Torr SamahoNote Added: 0016356
2016-11-29 20:16Torr SamahoPriorityhigh => low
2016-11-29 20:25Torr SamahoStatusnew => confirmed
2016-12-24 22:41DuskTarget Version => 3.0
2017-03-19 11:48Torr SamahoStatusconfirmed => closed
2017-03-19 11:48Torr SamahoResolutionopen => won't fix

Notes
(0015872)
unknownna   
2016-10-09 23:26   
It was first fixed in GZDoom 2.0.05.
(0015880)
Edward-san   
2016-10-10 07:11   
I see you're trying to toggle with the software renderer. If you try with opengl renderer it works fine. Can you confirm this? Also, is it still broken in GZDoom 2.0.03?
(0015881)
unknownna   
2016-10-10 07:21   
Hmm, toggling them in the OpenGL renderer seems to work fine indeed. I couldn't find 2.0.03 in'http://gzdoom.drdteam.org/archive/bin/ [^]'
(0015882)
Edward-san   
2016-10-10 07:32   
(edited on: 2016-10-10 07:34)
Then how about 1.9.1 1.8.7?
(0015883)
unknownna   
2016-10-10 07:39   
(edited on: 2016-10-10 07:40)
I tried all builds between 1.8.6 and 2.0.05 and 2.0.05 is the first build where it's fixed.

The reason why I reported it is because the options work fine in 2.1.2.
(0015884)
Edward-san   
2016-10-10 08:31   
(edited on: 2016-10-10 08:33)
This happens because of these code snippets in src/gl/renderer/gl_lightdata.cpp:


CUSTOM_CVAR(Int,gl_fogmode,1,CVAR_ARCHIVE|CVAR_NOINITCALL)
...
if (self == 2 && gl.shadermodel < 4) self = 1;



CUSTOM_CVAR(Int, gl_lightmode, 3 ,CVAR_ARCHIVE|CVAR_NOINITCALL)
...
if ((newself == 2 || newself == 8) && gl.shadermodel < 4) newself = 3;


in software renderer the gl stuff is initialized to 0, including the shadermodel part, causing the other modes to not appear at all.

In zand 2.x, the shadermodel check is present, but it's innocuous.

In gzdoom 2.x, there's no trace of shadermodel at all.

I don't know if there's a solution to this without causing more delta than needed.
(0016356)
Torr Samaho   
2016-11-27 16:29   
I think it's acceptable if one cannot select all OpenGL options while using the software renderer.